filegroup can't include file whose names contains '$'

[Ming Zhao]

For some legacy reason, we have some java class files in the source
tree and we would like to include them in a filegroup. But bazel
doesn't allow that because some class file contains '$' in the name.
Can we loose that restriction? Thanks!

[Damien Martin-guillerez]

+Ulf Adams who has a better understanding of all the implication

This sounds reasonable but we have one problem: each file of filegroup create a corresponding label and that means that $ should be accepted in the label syntax.

Alternatively, we could mangle the filename when finding a special character to create the corresponding label,

Anyway, that's a non-trivial change, created an issue to track it: https://github.com/google/bazel/issues/374

--
You received this message because you are subscribed to the Google Groups "bazel-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to bazel-discus...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/bazel-discuss/CAN0GiO3__5jXo5rZqroSj0mFxpqCzUZZVkY%3DSNsJK1%2BZ1BdJLg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[Han-Wen Nienhuys]

Couldn't you zip them up into a jar?

> https://groups.google.com/d/msgid/bazel-discuss/CAN3hOS-t_FDSCZBujwvOsxAOaXZUBdMMXQ2xGPj2XFH70fbN3Q%40mail.gmail.com.

>
> For more options, visit https://groups.google.com/d/optout.

--
Han-Wen Nienhuys
Google Munich
han...@google.com

[Ming Zhao]

Technically we can, there is no point of even putting class file in
the source tree in the first place.
But the issue is we are inheriting some upstream release in the source
tree, which contains the class files. We'd like the preserve the
original directory structure as much as possible, otherwise we could
just jar them.