Requesting Review for #13391

24 views
Skip to first unread message

Brandon Adams

unread,
Jan 25, 2022, 12:09:37 AM1/25/22
to 'John Cater' via bazel-dev

Hi,

 

I’d like to request review for PR #14391 (https://github.com/bazelbuild/bazel/pull/14391) . This is a patch that unbreaks docker platforms running bazel inside a non-native container (m1 mac using linux x86_64; linux x86_64 running bazel for linux/arm). It does so by means of changing the method that bazel uses to calculate the path to the running binary when extracting the server to use a method that is properly supported under binfmt_misc and qemu-user-static (used by docker to support non-native platforms).  The API used, getauxval(3), is well supported in Linux when running natively and is properly patched by qemu-user-static for running emulated binaries. It would be ideal to get this reviewed and backported into 4.x and 5.x as well as 6.0 since it fixes a bug that actively prevents users from using existing bazel containers on common developer platforms like M1 Macbooks.

 

Thanks!

 

Brandon Adams

Brando...@imc.com

Brandon Adams
Software Engineer
T +13122047540
E brando...@imc.com
233 South Wacker Drive # 4300,
Chicago, Illinois 60606, US

IMC Logo

F

t

I

in

imc.com





The information in this e-mail is intended only for the person or entity to which it is addressed.

It may contain confidential and /or privileged material, the disclosure of which is prohibited. Any unauthorized copying, disclosure or distribution of the information in this email outside your company is strictly forbidden.

If you are not the intended recipient (or have received this email in error), please contact the sender immediately and permanently delete all copies of this email and any attachments from your computer system and destroy any hard copies. Although the information in this email has been compiled with great care, neither IMC nor any of its related entities shall accept any responsibility for any errors, omissions or other inaccuracies in this information or for the consequences thereof, nor shall it be bound in any way by the contents of this e-mail or its attachments.

Messages and attachments are scanned for all known viruses. Always scan attachments before opening them.

Tony Aiuto

unread,
Jan 25, 2022, 12:37:48 AM1/25/22
to Brandon Adams, bazel-dev
Hi Brandon:
I'll try to hunt down the right person for this.

--
You received this message because you are subscribed to the Google Groups "bazel-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to bazel-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/bazel-dev/8D3CF870-CD78-486B-AEFE-A1EBAFE5558C%40imc.com.
Reply all
Reply to author
Forward
0 new messages