Change in bazel[master]: Remove unused constructor.

0 views
Skip to first unread message

Janak Ramakrishnan (Gerrit)

unread,
Jul 17, 2015, 12:27:52 PM7/17/15
to bazel-de...@googlegroups.com
Janak Ramakrishnan has uploaded a new change for review.

https://bazel-review.googlesource.com/1640

Change subject: Remove unused constructor.
......................................................................

Remove unused constructor.

Change-Id: Ica96bd719fe9d7e152fbe78e71669fddefe12e92
---
M
src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java
1 file changed, 0 insertions(+), 16 deletions(-)



diff --git
a/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java
b/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java
index a1ac8e2..0035300 100644
---
a/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java
+++
b/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java
@@ -110,22 +110,6 @@
this.diffAwarenessManager = new
DiffAwarenessManager(diffAwarenessFactories, reporter);
}

- private SequencedSkyframeExecutor(Reporter reporter, PackageFactory
pkgFactory,
- TimestampGranularityMonitor tsgm, BlazeDirectories directories,
- Factory workspaceStatusActionFactory,
- ImmutableList<BuildInfoFactory> buildInfoFactories,
- Set<Path> immutableDirectories,
- Iterable<? extends DiffAwareness.Factory> diffAwarenessFactories,
- Predicate<PathFragment> allowedMissingInputs,
- Preprocessor.Factory.Supplier preprocessorFactorySupplier,
- ImmutableMap<SkyFunctionName, SkyFunction> extraSkyFunctions,
- ImmutableList<PrecomputedValue.Injected> extraPrecomputedValues) {
- this(reporter, InMemoryMemoizingEvaluator.SUPPLIER, pkgFactory, tsgm,
- directories, workspaceStatusActionFactory, buildInfoFactories,
immutableDirectories,
- diffAwarenessFactories, allowedMissingInputs,
preprocessorFactorySupplier,
- extraSkyFunctions, extraPrecomputedValues);
- }
-
private static SequencedSkyframeExecutor create(Reporter reporter,
EvaluatorSupplier evaluatorSupplier, PackageFactory pkgFactory,
TimestampGranularityMonitor tsgm, BlazeDirectories directories,

--
To view, visit https://bazel-review.googlesource.com/1640
To unsubscribe, visit https://bazel-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica96bd719fe9d7e152fbe78e71669fddefe12e92
Gerrit-PatchSet: 1
Gerrit-Project: bazel
Gerrit-Branch: master
Gerrit-Owner: Janak Ramakrishnan <jan...@google.com>

Nathan Harmata (Gerrit)

unread,
Jul 22, 2015, 11:37:10 AM7/22/15
to Janak Ramakrishnan
Nathan Harmata has posted comments on this change.

Change subject: Remove unused constructor.
......................................................................


Patch Set 1: Code-Review+2

--
To view, visit https://bazel-review.googlesource.com/1640
To unsubscribe, visit https://bazel-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica96bd719fe9d7e152fbe78e71669fddefe12e92
Gerrit-PatchSet: 1
Gerrit-Project: bazel
Gerrit-Branch: master
Gerrit-Owner: Janak Ramakrishnan <jan...@google.com>
Gerrit-Reviewer: Nathan Harmata <nhar...@google.com>
Gerrit-HasComments: No

Damien Martin-guillerez (Gerrit)

unread,
Jul 27, 2015, 5:11:58 AM7/27/15
to Janak Ramakrishnan, Nathan Harmata
Damien Martin-guillerez has posted comments on this change.

Change subject: Remove unused constructor.
......................................................................


Patch Set 1:

Was this merged?

--
To view, visit https://bazel-review.googlesource.com/1640
To unsubscribe, visit https://bazel-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica96bd719fe9d7e152fbe78e71669fddefe12e92
Gerrit-PatchSet: 1
Gerrit-Project: bazel
Gerrit-Branch: master
Gerrit-Owner: Janak Ramakrishnan <jan...@google.com>
Gerrit-Reviewer: Damien Martin-guillerez <dmar...@google.com>

Janak Ramakrishnan (Gerrit)

unread,
Jul 27, 2015, 8:26:08 AM7/27/15
to Nathan Harmata, Damien Martin-guillerez
Hello Nathan Harmata,

I'd like you to reexamine a change. Please visit

https://bazel-review.googlesource.com/1640

to look at the new patch set (#2).

Change subject: Remove unused constructor and inline create method.
......................................................................

Remove unused constructor and inline create method.

Change-Id: Ica96bd719fe9d7e152fbe78e71669fddefe12e92
---
M
src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java
1 file changed, 6 insertions(+), 38 deletions(-)


--
To view, visit https://bazel-review.googlesource.com/1640
To unsubscribe, visit https://bazel-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ica96bd719fe9d7e152fbe78e71669fddefe12e92
Gerrit-PatchSet: 2
Gerrit-Project: bazel
Gerrit-Branch: master
Gerrit-Owner: Janak Ramakrishnan <jan...@google.com>

Janak Ramakrishnan (Gerrit)

unread,
Jul 27, 2015, 11:45:02 AM7/27/15
to Nathan Harmata
Janak Ramakrishnan has posted comments on this change.

Change subject: Remove unused constructor and inline create method.
......................................................................


Patch Set 2:

> Was this merged?

Yes, just now.

--
To view, visit https://bazel-review.googlesource.com/1640
To unsubscribe, visit https://bazel-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica96bd719fe9d7e152fbe78e71669fddefe12e92
Gerrit-PatchSet: 2
Gerrit-Project: bazel
Gerrit-Branch: master
Gerrit-Owner: Janak Ramakrishnan <jan...@google.com>
Gerrit-Reviewer: Janak Ramakrishnan <jan...@google.com>

Damien Martin-guillerez (Gerrit)

unread,
Jul 27, 2015, 12:49:32 PM7/27/15
to Janak Ramakrishnan, Nathan Harmata
Hello Nathan Harmata,

I'd like you to reexamine a change. Please visit

https://bazel-review.googlesource.com/1640

to look at the new patch set (#3).

Change subject: Remove unused constructor and inline create method.
......................................................................

Remove unused constructor and inline create method.

--
Change-Id: Ica96bd719fe9d7e152fbe78e71669fddefe12e92
Reviewed-on: https://bazel-review.googlesource.com/#/c/1640/
MOS_MIGRATED_REVID=99182210
---
M
src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java
1 file changed, 20 insertions(+), 39 deletions(-)


--
To view, visit https://bazel-review.googlesource.com/1640
To unsubscribe, visit https://bazel-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ica96bd719fe9d7e152fbe78e71669fddefe12e92
Gerrit-PatchSet: 3
Gerrit-Project: bazel
Gerrit-Branch: master
Gerrit-Owner: Janak Ramakrishnan <jan...@google.com>
Gerrit-Reviewer: Damien Martin-guillerez <dmar...@google.com>

Damien Martin-guillerez (Gerrit)

unread,
Jul 27, 2015, 12:49:32 PM7/27/15
to Janak Ramakrishnan, Nathan Harmata
Damien Martin-guillerez has submitted this change and it was merged.

Change subject: Remove unused constructor and inline create method.
......................................................................


Remove unused constructor and inline create method.

--
Change-Id: Ica96bd719fe9d7e152fbe78e71669fddefe12e92
Reviewed-on: https://bazel-review.googlesource.com/#/c/1640/
MOS_MIGRATED_REVID=99182210
---
M
src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java
1 file changed, 20 insertions(+), 39 deletions(-)



diff --git
a/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java
b/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java
index a1ac8e2..4d6fffc 100644
---
a/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java
+++
b/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java
@@ -110,8 +110,11 @@
this.diffAwarenessManager = new
DiffAwarenessManager(diffAwarenessFactories, reporter);
}

- private SequencedSkyframeExecutor(Reporter reporter, PackageFactory
pkgFactory,
- TimestampGranularityMonitor tsgm, BlazeDirectories directories,
+ public static SequencedSkyframeExecutor create(
+ Reporter reporter,
+ PackageFactory pkgFactory,
+ TimestampGranularityMonitor tsgm,
+ BlazeDirectories directories,
Factory workspaceStatusActionFactory,
ImmutableList<BuildInfoFactory> buildInfoFactories,
Set<Path> immutableDirectories,
@@ -120,45 +123,23 @@
Preprocessor.Factory.Supplier preprocessorFactorySupplier,
ImmutableMap<SkyFunctionName, SkyFunction> extraSkyFunctions,
ImmutableList<PrecomputedValue.Injected> extraPrecomputedValues) {
- this(reporter, InMemoryMemoizingEvaluator.SUPPLIER, pkgFactory, tsgm,
- directories, workspaceStatusActionFactory, buildInfoFactories,
immutableDirectories,
- diffAwarenessFactories, allowedMissingInputs,
preprocessorFactorySupplier,
- extraSkyFunctions, extraPrecomputedValues);
- }
-
- private static SequencedSkyframeExecutor create(Reporter reporter,
- EvaluatorSupplier evaluatorSupplier, PackageFactory pkgFactory,
- TimestampGranularityMonitor tsgm, BlazeDirectories directories,
- Factory workspaceStatusActionFactory,
ImmutableList<BuildInfoFactory> buildInfoFactories,
- Set<Path> immutableDirectories,
- Iterable<? extends DiffAwareness.Factory> diffAwarenessFactories,
- Predicate<PathFragment> allowedMissingInputs,
- Preprocessor.Factory.Supplier preprocessorFactorySupplier,
- ImmutableMap<SkyFunctionName, SkyFunction> extraSkyFunctions,
- ImmutableList<PrecomputedValue.Injected> extraPrecomputedValues) {
- SequencedSkyframeExecutor skyframeExecutor = new
SequencedSkyframeExecutor(reporter,
- evaluatorSupplier, pkgFactory, tsgm, directories,
workspaceStatusActionFactory,
- buildInfoFactories, immutableDirectories, diffAwarenessFactories,
allowedMissingInputs,
- preprocessorFactorySupplier,
- extraSkyFunctions, extraPrecomputedValues);
+ SequencedSkyframeExecutor skyframeExecutor =
+ new SequencedSkyframeExecutor(
+ reporter,
+ InMemoryMemoizingEvaluator.SUPPLIER,
+ pkgFactory,
+ tsgm,
+ directories,
+ workspaceStatusActionFactory,
+ buildInfoFactories,
+ immutableDirectories,
+ diffAwarenessFactories,
+ allowedMissingInputs,
+ preprocessorFactorySupplier,
+ extraSkyFunctions,
+ extraPrecomputedValues);
skyframeExecutor.init();
return skyframeExecutor;
- }
-
- public static SequencedSkyframeExecutor create(Reporter reporter,
PackageFactory pkgFactory,
- TimestampGranularityMonitor tsgm, BlazeDirectories directories,
- Factory workspaceStatusActionFactory,
- ImmutableList<BuildInfoFactory> buildInfoFactories,
- Set<Path> immutableDirectories,
- Iterable<? extends DiffAwareness.Factory> diffAwarenessFactories,
- Predicate<PathFragment> allowedMissingInputs,
- Preprocessor.Factory.Supplier preprocessorFactorySupplier,
- ImmutableMap<SkyFunctionName, SkyFunction> extraSkyFunctions,
- ImmutableList<PrecomputedValue.Injected> extraPrecomputedValues) {
- return create(reporter, InMemoryMemoizingEvaluator.SUPPLIER,
pkgFactory, tsgm,
- directories, workspaceStatusActionFactory, buildInfoFactories,
immutableDirectories,
- diffAwarenessFactories, allowedMissingInputs,
preprocessorFactorySupplier,
- extraSkyFunctions, extraPrecomputedValues);
}

@VisibleForTesting

--
To view, visit https://bazel-review.googlesource.com/1640
To unsubscribe, visit https://bazel-review.googlesource.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ica96bd719fe9d7e152fbe78e71669fddefe12e92
Gerrit-PatchSet: 3
Gerrit-Project: bazel
Gerrit-Branch: master
Gerrit-Owner: Janak Ramakrishnan <jan...@google.com>
Reply all
Reply to author
Forward
0 new messages