Making decisions on Bazel design proposals

[Lukács T. Berki]

Hey Ivo (Cc Yannic and Giorgi as authors of proposals),

There are a number of Bazel design proposals of varying ages in the "In review" stage, some quite old. Let's make a decision on them?

• "Toolchainifying proto rules" (2021 Feb): this is quite old and there doesn't seem to be a consensus on it, so let's drop it?
• "proto_common module" (2022 Mar): This is happening, isn't it?
• "Build Stamping API for Starlark rules" (2023 Jan): This is "only" two months old so I wouldn't mind keeping it open, but two months should be enough to reach a decision... have y'all decided what to do here?
• "Coding Guidelines for Starlark rules" (2022 Jun): Discussion is stalled on this one, so let's drop it?

--

Lukács T. Berki | Software Engineer | lbe...@google.com | 

Google Germany GmbH | Erika-Mann-Str. 33  | 80636 München | Germany | Geschäftsführer: Paul Manicle, Halimah DeLaine Prado | Registergericht und -nummer: Hamburg, HRB 86891

[Yannic Bonenberger]

Migrating the proto rules to toolchains is still something I’d like to see happening. The design doc from 2021 predates the starlarkification and needs some changes at least because of that. I’m fine with considering it dropped for now.

[Lukács T. Berki]

I'll send out a pull request for that one then. The reason the "Dropped" section exists is so that we have a reference in case we need to resurrect them.

[Lukács T. Berki]

https://github.com/bazelbuild/proposals/pull/303

[Ivo Ristovski List]

On Thursday, March 30, 2023 at 12:43:08 PM UTC+2 lbe...@google.com wrote:

Hey Ivo (Cc Yannic and Giorgi as authors of proposals),

There are a number of Bazel design proposals of varying ages in the "In review" stage, some quite old. Let's make a decision on them?

• "Toolchainifying proto rules" (2021 Feb): this is quite old and there doesn't seem to be a consensus on it, so let's drop it?

Let's say dropped in the current form, however I agree with the objective, since Kythe has a good use case for it.

 

• "proto_common module" (2022 Mar): This is happening, isn't it?

Implemented.

 

• "Build Stamping API for Starlark rules" (2023 Jan): This is "only" two months old so I wouldn't mind keeping it open, but two months should be enough to reach a decision... have y'all decided what to do here?

In progress 

• "Coding Guidelines for Starlark rules" (2022 Jun): Discussion is stalled on this one, so let's drop it?

Dropped. I think this needs to be addressed using API so follow-up documents are coming.