Change in bazel[master]: Tag all the six java test targets that shouldn't run on Windows

[Yun Peng (Gerrit)]

Yun Peng has uploaded a new change for review.

https://bazel-review.googlesource.com/3970

Change subject: Tag all the six java test targets that shouldn't run on
Windows
......................................................................

Tag all the six java test targets that shouldn't run on Windows

Now, we can use:

bazel query 'tests(//src/test/java/...) - attr(tags, no_windows,
tests(//src/test/java/...))'

to find all the tests passing on Windows.

Change-Id: I5c7f05fbf9718bc335e19fd17916a14c286bedbf
---
M src/test/java/com/google/devtools/build/lib/BUILD
1 file changed, 6 insertions(+), 4 deletions(-)



diff --git a/src/test/java/com/google/devtools/build/lib/BUILD
b/src/test/java/com/google/devtools/build/lib/BUILD
index 7e7575d..066c987 100644
--- a/src/test/java/com/google/devtools/build/lib/BUILD
+++ b/src/test/java/com/google/devtools/build/lib/BUILD
@@ -118,7 +118,7 @@
],
),
data = glob(["vfs/*.zip"]),
- tags = ["foundations"],
+ tags = ["foundations", "no_windows"],
test_class = "com.google.devtools.build.lib.AllTests",
deps = [
":foundations_testutil",
@@ -448,7 +448,7 @@
"analysis/*.java",
]),
shard_count = 2,
- tags = ["analysis"],
+ tags = ["analysis", "no_windows"],
test_class = "com.google.devtools.build.lib.AllTests",
deps = [
":actions_testutil",
@@ -646,7 +646,7 @@
":shell/killmyself",
],
flaky = True,
- tags = ["shell"],
+ tags = ["shell", "no_windows"],
test_class = "com.google.devtools.build.lib.AllTests",
deps = [
":foundations_testutil",
@@ -669,7 +669,7 @@
srcs = glob([
"server/*.java",
]),
- tags = ["server"],
+ tags = ["server", "no_windows"],
test_class = "com.google.devtools.build.lib.AllTests",
deps = [
":foundations_testutil",
@@ -976,6 +976,7 @@
"//third_party:junit4",
"//third_party:truth",
],
+ tags = ["no_windows"],
)

java_test(
@@ -1005,6 +1006,7 @@
"//third_party:junit4",
"//third_party:truth",
],
+ tags = ["no_windows"],
)

java_test(

--
To view, visit https://bazel-review.googlesource.com/3970
To unsubscribe, visit https://bazel-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c7f05fbf9718bc335e19fd17916a14c286bedbf
Gerrit-PatchSet: 1
Gerrit-Project: bazel
Gerrit-Branch: master
Gerrit-Owner: Yun Peng <pcl...@google.com>

[Damien Martin-guillerez (Gerrit)]

Damien Martin-guillerez has posted comments on this change.

Change subject: Tag all the six java test targets that shouldn't run on
Windows
......................................................................

Patch Set 1: Code-Review+2

`--test_tag_filters -no_windows` is simpler :)

--
To view, visit https://bazel-review.googlesource.com/3970
To unsubscribe, visit https://bazel-review.googlesource.com/settings

Gerrit-MessageType: comment

Gerrit-Change-Id: I5c7f05fbf9718bc335e19fd17916a14c286bedbf
Gerrit-PatchSet: 1
Gerrit-Project: bazel
Gerrit-Branch: master
Gerrit-Owner: Yun Peng <pcl...@google.com>

Gerrit-Reviewer: Damien Martin-guillerez <dmar...@google.com>
Gerrit-Reviewer: Dmitry Lomov <dsl...@google.com>
Gerrit-HasComments: No

[Kristina Chodorow (Gerrit)]

Hello Damien Martin-guillerez,

I'd like you to reexamine a change. Please visit

https://bazel-review.googlesource.com/3970

to look at the new patch set (#2).

Change subject: Tag all the six java test targets that shouldn't run on
Windows
......................................................................

Tag all the six java test targets that shouldn't run on Windows

Now, we can use:

bazel query 'tests(//src/test/java/...) - attr(tags, no_windows,
tests(//src/test/java/...))'

to find all the tests passing on Windows.

--
Change-Id: I5c7f05fbf9718bc335e19fd17916a14c286bedbf
Reviewed-on: https://bazel-review.googlesource.com/#/c/3970
MOS_MIGRATED_REVID=127078158
---
M src/test/java/com/google/devtools/build/lib/BUILD
1 file changed, 18 insertions(+), 4 deletions(-)

--
To view, visit https://bazel-review.googlesource.com/3970
To unsubscribe, visit https://bazel-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5c7f05fbf9718bc335e19fd17916a14c286bedbf
Gerrit-PatchSet: 2

Gerrit-Project: bazel
Gerrit-Branch: master
Gerrit-Owner: Yun Peng <pcl...@google.com>

Gerrit-Reviewer: Damien Martin-guillerez <dmar...@google.com>
Gerrit-Reviewer: Dmitry Lomov <dsl...@google.com>

Gerrit-Reviewer: Kristina Chodorow <kcho...@google.com>

[Kristina Chodorow (Gerrit)]

Kristina Chodorow has submitted this change and it was merged.

Change subject: Tag all the six java test targets that shouldn't run on
Windows
......................................................................


Tag all the six java test targets that shouldn't run on Windows

Now, we can use:

bazel query 'tests(//src/test/java/...) - attr(tags, no_windows,
tests(//src/test/java/...))'

to find all the tests passing on Windows.

--
Change-Id: I5c7f05fbf9718bc335e19fd17916a14c286bedbf
Reviewed-on: https://bazel-review.googlesource.com/#/c/3970
MOS_MIGRATED_REVID=127078158

---
M src/test/java/com/google/devtools/build/lib/BUILD
1 file changed, 18 insertions(+), 4 deletions(-)



diff --git a/src/test/java/com/google/devtools/build/lib/BUILD
b/src/test/java/com/google/devtools/build/lib/BUILD
index af217e0..42b06d7 100644
--- a/src/test/java/com/google/devtools/build/lib/BUILD
+++ b/src/test/java/com/google/devtools/build/lib/BUILD
@@ -118,7 +118,10 @@

],
),
data = glob(["vfs/*.zip"]),
- tags = ["foundations"],
+ tags = [

+ "foundations",
+ "no_windows",
+ ],

test_class = "com.google.devtools.build.lib.AllTests",
deps = [
":foundations_testutil",

@@ -448,7 +451,10 @@

"analysis/*.java",
]),
shard_count = 2,
- tags = ["analysis"],
+ tags = [

+ "analysis",
+ "no_windows",
+ ],

test_class = "com.google.devtools.build.lib.AllTests",
deps = [
":actions_testutil",

@@ -646,7 +652,10 @@

":shell/killmyself",
],
flaky = True,
- tags = ["shell"],
+ tags = [

+ "no_windows",
+ "shell",
+ ],

test_class = "com.google.devtools.build.lib.AllTests",
deps = [
":foundations_testutil",

@@ -669,7 +678,10 @@

srcs = glob([
"server/*.java",
]),
- tags = ["server"],
+ tags = [

+ "no_windows",
+ "server",
+ ],

test_class = "com.google.devtools.build.lib.AllTests",
deps = [
":foundations_testutil",

@@ -954,6 +966,7 @@
name = "sandbox-tests",
srcs = glob(["sandbox/*.java"]),
data = [":embedded_scripts"],

+ tags = ["no_windows"],

test_class = "com.google.devtools.build.lib.AllTests",
deps = [
":actions_testutil",

@@ -981,6 +994,7 @@
name = "standalone-tests",
srcs = glob(["standalone/*.java"]),
data = [":embedded_scripts"],

+ tags = ["no_windows"],

test_class = "com.google.devtools.build.lib.AllTests",
deps = [
":actions_testutil",

--
To view, visit https://bazel-review.googlesource.com/3970
To unsubscribe, visit https://bazel-review.googlesource.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5c7f05fbf9718bc335e19fd17916a14c286bedbf
Gerrit-PatchSet: 2

Gerrit-Project: bazel
Gerrit-Branch: master
Gerrit-Owner: Yun Peng <pcl...@google.com>