Auto-sheriff and bugs #1093 and #1094

Lukács T. Berki

unread,

Feb 19, 2021, 5:11:46 AM2/19/21

to Philipp Wollermann, bazel-dev

Hey Philipp,

I'm in the process of fixing the #1093 and #1094. How come it took about a week to pin it on a commit and that also turned out to be the wrong commit?

It looks like a genuine bug with a one-line fix, but getting test breakages 11 days after submitting a change is not optimal.

--

Lukács T. Berki | Software Engineer | lbe...@google.com |

Philipp Wollermann

unread,

Feb 19, 2021, 6:42:49 AM2/19/21

to Lukács T. Berki, bazel-engprod, Yun Peng, Christopher Parsons, Ivo List, bazel-dev

-bazel-dev +bazel-engprod +Yun Peng +Ivo List +Christopher Parsons

I don't think it's cool to write e-mails like this to a list, especially a public list.

Yun, as the author of auto-sheriff might be able to answer your question. Or Ivo or Chris, who were on the Green Team rotation during your quoted 11 day window.

Cheers,

Philipp

--

Philipp Wollermann | Software Engineer | phi...@google.com
Google Germany GmbH | Erika-Mann-Straße 33 | 80636 München

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Lukács T. Berki

unread,

Feb 19, 2021, 7:52:59 AM2/19/21

to Philipp Wollermann, bazel-engprod, Yun Peng, Christopher Parsons, Ivo List, bazel-dev

On Fri, Feb 19, 2021 at 12:42 PM Philipp Wollermann <phi...@google.com> wrote:

-bazel-dev +bazel-engprod +Yun Peng +Ivo List +Christopher Parsons

I don't think it's cool to write e-mails like this to a list, especially a public list.

Erm, sorry, I didn't mean this as an admonishment; I thought I simply don't know how auto-sheriff and our CI work and the delay is completely expected or else there was a glitch I missed.

Yun, as the author of auto-sheriff might be able to answer your question. Or Ivo or Chris, who were on the Green Team rotation during your quoted 11 day window.

Cheers,
Philipp

On Fri, Feb 19, 2021 at 11:11 AM Lukács T. Berki <lbe...@google.com> wrote:
Hey Philipp,

I'm in the process of fixing the #1093 and #1094. How come it took about a week to pin it on a commit and that also turned out to be the wrong commit?

It looks like a genuine bug with a one-line fix, but getting test breakages 11 days after submitting a change is not optimal.

--
Lukács T. Berki | Software Engineer | lbe...@google.com |

Google Germany GmbH | Erika-Mann-Str. 33 | 80636 München | Germany | Geschäftsführer: Paul Manicle, Halimah DeLaine Prado | Registergericht und -nummer: Hamburg, HRB 86891

--
Philipp Wollermann | Software Engineer | phi...@google.com
Google Germany GmbH | Erika-Mann-Straße 33 | 80636 München

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Reply all

Reply to author

Forward