Minor bug found in Entity.getEntitiesByClass()

[Balthazar Auger]

Hi!

While implementing a collision test for a drag and drop behavior, I wanted to use getEntitiesByClass to narrow down candidates for collision testing a bit. 

Strangely, the array always came out empty, no matter what combination of parameters I used, so I dug in a little further, doing a step by step analysis of the method.

When you bubble down in the for loop,

for ( i in l_entities )

{

if ( Std.is( i, p_classType ) )

{

l_result.push( cast i );

}

if ( p_isBubbleDown )

{

l_result.concat( i.getEntitiesByClass( p_classType, p_agenda, true ) );

}

}

results that match the class type are correctly added to the result array, but when we get back to the upper level of recursion, the result array comes back empty.

It turns out that Array.concat() returns the concatenated array, but doesn't modify the calling instance. So the results weren't being stored anywhere after concatenation.

To fix this method, you would need to change the following lines of Entity.hx (my additions are underlined)

254:

l_result = l_result.concat( i.getEntitiesByClass( p_classType, p_agenda, true ) );

259:

l_result = l_result.concat( parent.getEntitiesByClass( p_classType, p_agenda, false, true ) );

Once you do that, getEntitiesByClass returns what it is supposed to.

[Rob Fell]

Thank you, fixed in revision 638

https://code.google.com/p/awe6/source/detail?r=638