Awaitility 4.0.2 releases on maven central

[Kannan Ekanath]

I can see awaitility released correctly to https://repo.maven.apache.org/maven2/org/awaitility/awaitility/4.0.2/ and I can see the pom https://repo.maven.apache.org/maven2/org/awaitility/awaitility/4.0.2/awaitility-4.0.2.pom contains the following 

<dependency>

<groupId>org.awaitility</groupId>

<artifactId>awaitility-test-support</artifactId>

</dependency>

However I don't see "awaitility-test-support" 4.0.2 at all at https://repo.maven.apache.org/maven2/org/awaitility/awaitility-test-support/ 

Is this something that has been missed? 

[Kannan Ekanath]

Also I am wondering why the scope for the dependency is NOT set to "test"? 

[Johan Haleby]

awaitility-test-support is an internal module that just contains a bunch of classes and other utilities that to test awaitility itself. I manually remove this (and other modules) when releasing so that it's not synced to maven central. If there's a better way then I'm all ears :)

--
You received this message because you are subscribed to the Google Groups "Awaitility" group.
To unsubscribe from this group and stop receiving emails from it, send an email to awaitility+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/awaitility/e4dcdce3-deed-4856-9125-43688d4dba71%40googlegroups.com.

[Kannan Ekanath]

The awaitility pom contains a compile dependency to awaitility-test-support. So you have to also remove that dependency manually since that pom is no longer valid. The reason I ask this question is because in large enterprises like mine they have internal maven/nexus repositories that have very strict validation on missing dependencies. This tripped us up because we now have a pom which references a dependency which is not found anywhere.

I think it might just be simpler if you just published awaitility-test-support too just like you used to do in v3.x. Obviously the description of the module will clearly state that it is an internal module and clients are not expected to use this which will be enough I think.

Lastly well done on the framework! It is amazing work and simplifies a lot of boiler plate code. 

Thanks

Kannan

On Wednesday, 6 May 2020 08:39:20 UTC+1, Johan Haleby wrote:

awaitility-test-support is an internal module that just contains a bunch of classes and other utilities that to test awaitility itself. I manually remove this (and other modules) when releasing so that it's not synced to maven central. If there's a better way then I'm all ears :)

On Fri, May 1, 2020 at 12:19 PM Kannan Ekanath <kannan...@gmail.com> wrote:

Also I am wondering why the scope for the dependency is NOT set to "test"? 

On Friday, 1 May 2020 10:58:00 UTC+1, Kannan Ekanath wrote:

I can see awaitility released correctly to https://repo.maven.apache.org/maven2/org/awaitility/awaitility/4.0.2/ and I can see the pom https://repo.maven.apache.org/maven2/org/awaitility/awaitility/4.0.2/awaitility-4.0.2.pom contains the following 

<dependency>

<groupId>org.awaitility</groupId>

<artifactId>awaitility-test-support</artifactId>

</dependency>

However I don't see "awaitility-test-support" 4.0.2 at all at https://repo.maven.apache.org/maven2/org/awaitility/awaitility-test-support/ 

Is this something that has been missed? 

--
You received this message because you are subscribed to the Google Groups "Awaitility" group.

To unsubscribe from this group and stop receiving emails from it, send an email to await...@googlegroups.com.

[Johan Haleby]

On Wed, May 13, 2020 at 5:29 PM Kannan Ekanath <kannan....@gmail.com> wrote:

The awaitility pom contains a compile dependency to awaitility-test-support. So you have to also remove that dependency manually since that pom is no longer valid. The reason I ask this question is because in large enterprises like mine they have internal maven/nexus repositories that have very strict validation on missing dependencies. This tripped us up because we now have a pom which references a dependency which is not found anywhere.

Hmm where do you see a compile dependency to awaitility-test-support? This is not the intension. I know (now) that it's bad practise to specify a default scope in dependency management section of the pom.xml, but it says there that it should be a "test" dependency (https://github.com/awaitility/awaitility/blob/master/pom.xml#L218). 

 

I think it might just be simpler if you just published awaitility-test-support too just like you used to do in v3.x. Obviously the description of the module will clearly state that it is an internal module and clients are not expected to use this which will be enough I think.

I was never the intension to publish this artifact. I think it was just a mistake from my part that it has ever been published :) 

Lastly well done on the framework! It is amazing work and simplifies a lot of boiler plate code. 

Thanks :) Let's hope we can figure this out.

Thanks

Kannan

On Wednesday, 6 May 2020 08:39:20 UTC+1, Johan Haleby wrote:

awaitility-test-support is an internal module that just contains a bunch of classes and other utilities that to test awaitility itself. I manually remove this (and other modules) when releasing so that it's not synced to maven central. If there's a better way then I'm all ears :)

On Fri, May 1, 2020 at 12:19 PM Kannan Ekanath <kannan...@gmail.com> wrote:

Also I am wondering why the scope for the dependency is NOT set to "test"? 

On Friday, 1 May 2020 10:58:00 UTC+1, Kannan Ekanath wrote:

I can see awaitility released correctly to https://repo.maven.apache.org/maven2/org/awaitility/awaitility/4.0.2/ and I can see the pom https://repo.maven.apache.org/maven2/org/awaitility/awaitility/4.0.2/awaitility-4.0.2.pom contains the following 

<dependency>

<groupId>org.awaitility</groupId>

<artifactId>awaitility-test-support</artifactId>

</dependency>

However I don't see "awaitility-test-support" 4.0.2 at all at https://repo.maven.apache.org/maven2/org/awaitility/awaitility-test-support/ 

Is this something that has been missed? 

--
You received this message because you are subscribed to the Google Groups "Awaitility" group.
To unsubscribe from this group and stop receiving emails from it, send an email to await...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/awaitility/e4dcdce3-deed-4856-9125-43688d4dba71%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Awaitility" group.

To unsubscribe from this group and stop receiving emails from it, send an email to awaitility+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/awaitility/d69a5829-5387-4e4b-8872-c0aec03e56f8%40googlegroups.com.

[Kannan Ekanath]

Hi Johan

Thank you for the reply. If you look at the output of the pom at https://repo.maven.apache.org/maven2/org/awaitility/awaitility/4.0.2/awaitility-4.0.2.pom you can see awaitility-test-support as a dependency.

As you have rightly said the root level aggregator pom https://github.com/awaitility/awaitility/blob/master/pom.xml#L218 only contains this in test scope however there is a catch the first child which is the "awaitility" module itself is what we are using https://github.com/awaitility/awaitility/blob/master/awaitility/pom.xml#L79 and you can see here that awaitility-test-support does not have test scope. 

Does that make sense? If we make it test scope it might still solve our problem.

Thanks

Kannan

You received this message because you are subscribed to a topic in the Google Groups "Awaitility" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/awaitility/7AlNeWvvkcE/unsubscribe.
To unsubscribe from this group and all its topics, send an email to awaitility+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/awaitility/CAK3tncLsKauv8i8DMtDbzD7udm%3D70AoJKJ_M%2B_saH16f7%2BESXg%40mail.gmail.com.

--

Regards,
Kannan Ekanath

[Johan Haleby]

Hi, 

I've now removed <scope>test</scope> from the dependencyManagement section in the root pom and using it explicitly in child poms instead. I've pushed this to master as well as published a new snapshot (4.0.3-SNAPSHOT). Does this solve the problem?

/Johan

To view this discussion on the web visit https://groups.google.com/d/msgid/awaitility/CAGjnJ1_ciNgMV%3Dznj0XyhzuaRB8fO6OxrbTFhtmjy0unnE_yLg%40mail.gmail.com.

[Kannan Ekanath]

Thank you Johan.

This looks good to me. I work for a big enterprise so any external maven dependencies will be submitted to our internal tool which will try to crawl the pom, look at dependencies ensure we have all the pre-reqs. 

If you can release this version I will re-run my internal tool to see if this fixes the issue.

To view this discussion on the web visit https://groups.google.com/d/msgid/awaitility/CAK3tnc%2Bxkp54h0Sk0vO4ufGv4QxLyKdqHB0mNmQYWQr3UzwyYw%40mail.gmail.com.

--

Regards,
Kannan Ekanath

[Johan Haleby]

I've released 4.0.3 now, but I still had to remove awaitility-test-support from sonatype manually.

To view this discussion on the web visit https://groups.google.com/d/msgid/awaitility/CAGjnJ1_G_NFZ%3Dr_VJ%2BUdDmKuUM1TPbN9JKxe37AxVdzHUXxXmA%40mail.gmail.com.

[Kannan Ekanath]

Thank you Johan! This works perfectly fine for us now!

The one thing I'd suggest is to not remove the awaitility-test-support manually. The description clearly says it is an internal artifact and it is published to keep the world consistent :) but then again that would be your call!

Regards

Kannan

To view this discussion on the web visit https://groups.google.com/d/msgid/awaitility/CAK3tncJF_BCBXh1GL__zq44YMFU%2Bcgep-%2BsrPj5ypNQ_hNXFWA%40mail.gmail.com.

--

Regards,
Kannan Ekanath

[Johan Haleby]

Thanks for trying it out, glad you got it working :)

To view this discussion on the web visit https://groups.google.com/d/msgid/awaitility/CAGjnJ1-O%3DUtS37tB0JwOsK%2BRogAUEMCUe5W5Cy%3DK3hgx_TsfkA%40mail.gmail.com.