LinkConfig Constructor Unused Parameter

[Nicholas Lee]

I've just discovered one of the LinkConfig constructors has a parameter called useConfirms, which is never used.  Should it be removed?  It was used in an older version of opendnp3: you could set it through the now retired OutstationStackConfig::link.UseConfirms member, though I don't recall if it ever did anything.

My understanding is that enabling it would contravene the DNP3 specification, so I understand why it may have been removed. We did support it in our application, though as I don't think we've ever used it, I don't think we'll miss it.

Should the unused parameter be removed entirely to avoid confusion?

[Adam Crain]

Yes, it should have been removed.