missing "module" and our friend control-m

[percious]

I have the latest update, and I ran the test suite this morning. It
looks like the repository is missing win32security.

Also, our friend ^M has returned! methods.py is the offender. Here is
the nostests --coverage dump:

======================================================================
ERROR: Failure: ImportError (No module named win32security)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/local/lib/python2.5/site-packages/nose-0.10.1-py2.5.egg/
nose/loader.py", line 364, in loadTestsFromName
addr.filename, addr.module)
File "/usr/local/lib/python2.5/site-packages/nose-0.10.1-py2.5.egg/
nose/importer.py", line 39, in importFromPath
return self.importFromDir(dir_path, fqname)
File "/usr/local/lib/python2.5/site-packages/nose-0.10.1-py2.5.egg/
nose/importer.py", line 84, in importFromDir
mod = load_module(part_fqname, fh, filename, desc)
File "/Users/cperkins1/offsite/authority/authority/test/
test_schemes.py", line 1, in <module>
from authority.schemes import *
File "/Users/cperkins1/offsite/authority/authority/schemes/
__init__.py", line 1, in <module>
from schemes import *
File "/Users/cperkins1/offsite/authority/authority/schemes/
schemes.py", line 5, in <module>
from authority.checkers import MatchChecker
File "/Users/cperkins1/offsite/authority/authority/checkers/
__init__.py", line 1, in <module>
from checkers import *
File "/Users/cperkins1/offsite/authority/authority/checkers/
checkers.py", line 95, in <module>
from win32security import LogonUser
ImportError: No module named win32security

Name Stmts Exec Cover Missing
-------------------------------------------------------------
authority 0 0 100%
authority.conditions 76 76 100%
authority.methods 1 1 100%
authority.methods.methods <class 'coverage.CoverageException'>:
Couldn't parse '/Users/cperkins1/offsite/authority/authority/methods/
methods.py' as Python source: 'invalid syntax' at line 113
authority.providers 1 1 100%
authority.providers.providers 10 6 60% 12-13, 19, 25
authority.user 7 7 100%
authority.utils 21 5 23% 7-23, 33
-------------------------------------------------------------

enjoy!

-chris

[Kevin Horn]

On Sun, Mar 16, 2008 at 10:20 AM, percious <ch...@percious.com> wrote:

I have the latest update, and I ran the test suite this morning.  It
looks like the repository is missing win32security.

Thanks for the info Chris...win32security comes from pywin32 of course, and it isn't in the repos anywhere.  It shouldn't be necessary unless you're using the SMBChecker, but I admit I haven't run teh tests on a machine where it isn't present.
 

Also, our friend ^M has returned! methods.py is the offender.  Here is
the nostests --coverage dump:

Tarnation!  I went though on Friday and fixed a bunch of this, but I guess I missed one.

Arg!  I have never had this much trouble with line endings.

Kevin Horn

[Kevin Horn]

On Mon, Mar 17, 2008 at 10:33 AM, Kevin Horn <kevin...@gmail.com> wrote:

On Sun, Mar 16, 2008 at 10:20 AM, percious <ch...@percious.com> wrote:

I have the latest update, and I ran the test suite this morning.  It
looks like the repository is missing win32security.

Thanks for the info Chris...win32security comes from pywin32 of course, and it isn't in the repos anywhere.  It shouldn't be necessary unless you're using the SMBChecker, but I admit I haven't run the tests on a machine where it isn't present.
 

Aha! Felix had submited a patch for this, which I thought that I had applied...but hadn't.


I'll get it (or something like it) in there soonish.

Kevin Horn

[Felix Schwarz]

Kevin Horn wrote:
> Tarnation! I went though on Friday and fixed a bunch of this, but I
> guess I missed one.
>
> Arg! I have never had this much trouble with line endings.

I fixed this in r42.

Furthermore I like to add "svn:eol-style" "native" for all .py files in the
repository to avoid these troubles in the future.
Command to be issued:
find . -type 'f' -name '*.py' | xargs -n 1 svn propset \
"svn:eol-style" "native"

And I think that we should ignore all *.pyc:
svn status | grep pyc | xargs -n 1 dirname | grep -v '\.' | sort | uniq \
| xargs -n 1 svn propset 'svn:ignore' '*.pyc'

If no one objects, I will commit these changes in two days (on Wednesday).
And we should look into Subversion's auto-properties so that all new items
get these, too.

--
Felix Schwarz
Dipl.-Informatiker

Gubener Str. 38
10243 Berlin
Germany

www.schwarz.eu - software development and consulting