Audit4j-core FileAuditHandler variable "path" versus getProperty("log.file.location")

[Franck Benault]

For my understanding the variable "path" of FileAuditHandler is not used.
the full path of the audit file is defined by the value associated to the key "log.file.location" in the map property

I would say it is more logical to have a variable path than have a log.file.location key
because this path is a property related to FileAuditHandler only.
but the risk is now the user will have to change their configuration
So I suggest to remove the variable path inside FileAuditHandler

What do you suggest
1) removing this variable Path in this FileHandler
2) or change the init method of the FileHandler
writer = new ZeroCopyFileWriter(getProperty("log.file.location"));
to writer = new ZeroCopyFileWriter(path);
+ add getter for the path (for xml configuration)

[Franck Benault]

Hello,

I have created the pull request

https://github.com/audit4j/audit4j-core/pull/63

removing path variable

Regards Franck

[Janith Bandara]

Hi Franck,

I agree to have path variable is more logical than log.file.location as property key. 

we can have both configuration for now but he logic should be "log.file.location" is not available, Path variable is selected. This way "log.file.location" can be eliminated in the future versions.

I would not suggest not to remove path variable for now.

Regards,

Janith

[Franck Benault]

Hello

thanks for your answer

I have closed the pull request 63 https://github.com/audit4j/audit4j-core/pull/63

Regards Franck