Proposal to drop code review, start meeting regularly

9 views
Skip to first unread message

Lane Smith

unread,
Feb 8, 2012, 2:11:53 AM2/8/12
to Austin Student Mentorship
Hi all,

I am proposing to downscale the code review event we have had in the pipeline for the past few months. I am taking this stance because given our present situation, it does not seem feasible nor in our best interests to invest large amounts of effort trying to arrange this for next Monday (my previously proposed date). Instead of a large code review event, we should meet next Monday as a normal meeting---no flyers, posters, or pizza necessary. I think it is most important that we start meeting again regularly.

My reasons are as follows:

-I put in a room reservation request after my last email two weeks ago and still do not have confirmation on a room reservation. Though the student org office states that it should take about 3-5 business days, in my experience this is rarely the case. It is unusual that it is taking this long; I emailed yesterday and am waiting on a response.

-I have received lukewarm responses from other student organizations about cross-publicizing this event. Several organization officers had difficulty seeing the benefit to a code review, and after a back-and-forth with an ACM officer, I understand why. As students, the only "code review" you get is the grade on an assignment, and if you've never been exposed to industry, then it's hard to see the value of the process. Of course, this *is* the goal of ASM--to expose students to best practices to prepare them for industry--but it's a hard sell. I am unsure of how to sell it effectively and lack the time to keep pressing the issue.

-With less than a week away, it would be a struggle to design, print, and post flyers and to have any effective exposure.

If you all agree, let's meet Monday at 6pm, in the ENS commons area (ENS 313) and have just a normal meeting. I still have the code I wrote for the purpose of the code review event. Why not start off by reviewing and critiquing my code, and then use discussions to carry us further on? Again, I think the most important thing is that we start meeting again regularly.

I would like to host a large event, but based on this experience, we need to begin planning *months* in advance. We can talk about this as well.

I would appreciate any feedback and questions you have.

Cheers,
Lane Smith


Sukant Hajra

unread,
Feb 8, 2012, 10:14:28 AM2/8/12
to atx-sw-m...@googlegroups.com
Excerpts from Lane Smith's message of Wed Feb 08 01:11:53 -0600 2012:

>
> -I have received lukewarm responses from other student organizations about
> cross-publicizing this event. Several organization officers had difficulty
> seeing the benefit to a code review, and after a back-and-forth with an ACM
> officer, I understand why. As students, the only "code review" you get is the
> grade on an assignment, and if you've never been exposed to industry, then
> it's hard to see the value of the process. Of course, this *is* the goal of
> ASM--to expose students to best practices to prepare them for industry--but
> it's a hard sell. I am unsure of how to sell it effectively and lack the time
> to keep pressing the issue.

This is a real problem. We need a plan to tackle it. Any student too deeply
invested in such insular thinking is on a path towards throwing away millions
of dollars in wasted efforts. It's not that they'll never figure it out. But
they'll be wasting so many resources in the process of learning on the job.

As far as I can tell -- a huge majority of students have never seen well
written code and certainly don't know how to write it. Students of academic
excellence are no exception. In fact, they're more problematic because they
are being rewarded for badly written code.

Let's talk about this Monday.

> -With less than a week away, it would be a struggle to design, print, and
> post flyers and to have any effective exposure.
>
> If you all agree, let's meet Monday at 6pm, in the ENS commons area (ENS 313)
> and have just a normal meeting. I still have the code I wrote for the purpose
> of the code review event. Why not start off by reviewing and critiquing my
> code, and then use discussions to carry us further on? Again, I think the
> most important thing is that we start meeting again regularly.
>
> I would like to host a large event, but based on this experience, we need to
> begin planning *months* in advance. We can talk about this as well.

This sounds fine. Let's meet next Monday and think about what to do moving
forward. Getting a room and student support has been easier in the past. I
think we can figure something out.

-Sukant

Christopher Grant

unread,
Feb 8, 2012, 10:51:37 AM2/8/12
to atx-sw-m...@googlegroups.com
I completely agree with the importance and the inexperience. Just a thought but "Code Review" doesn't sound fun. Since attendance isn't required you need to "Sell" it better. Maybe hide "Code Review" in Paired Programming practices or "Trash the Code: Ripping apart open source project X" Maybe apply some game theory and make a contest asking teams to demonstrate code review practices to the others, best team wins.

Don't get discouraged, just give them spoon full of sugar. You guys are doing fantastic things. Keep it up.   

-Christopher Grant
IT Architect - HomeDepot.com
Voice: (512) 522-1260
Email: CRG...@gmail.com
Web: http://cgrant.wordpress.com




--
--------
Austin Software Mentors

   post:  atx-sw-m...@googlegroups.com
   unsubscribe:  atx-sw-mentors...@googlegroups.com
   url:  http://groups.google.com/group/atx-sw-mentorship/web?hl=en

Lane Smith

unread,
Feb 12, 2012, 6:50:42 PM2/12/12
to atx-sw-m...@googlegroups.com
I really like that the ideas you brought up, Chris. Thanks for putting them out there.

I think for tomorrow's meeting, we should focus on getting solving this sort of problem. We're going to continue to be limited in attendance until we find a way to bring new students in and convince them that it's worth their time.
--
Lane
Reply all
Reply to author
Forward
0 new messages