Auto-formatting C code in astropy

[Thomas Robitaille]

Hi everyone,

I just wanted to draw your attention to the following issue:

https://github.com/astropy/astropy/issues/18654

I am proposing enabling clang-format in pre-commit to auto-format C code in astropy core (except for files vendored from other packages such as in cextern). This will save time for people working on C code to avoid having to try and get e.g. all the indentation right and consistent with the rest of each file. We already do auto-formatting for Python code, so this would just be an extension of that.

If you have any opinions about this, please feel free to chime in!

Thanks,

Tom

[Clément Robert]

Hi Tom, thanks for proposing this. I think the biggest win from formatting with black (and latter, ruff format) was that we could embrace the defaults and stop discussing formatting (almost) entirely, so, even though clang-format *does* support configuration, I agree with going for defaults all the way.

Clément

[Thomas Robitaille]

Hi everyone,

I have updated the pull request to add automated formatting of C code with clang-format:

https://github.com/astropy/astropy/pull/18674

Following some feedback, I have tweaked the config a little, and the PR reformats all sub-packages except astropy/wcs for now – since that subpackage dominates the number of C lines by far in astropy, it was more productive to do a PR without for now in terms of discussing the config, and that can be reformatted in a separate PR later.

In the interest of not dwelling too long on config tweaks etc, I'd like to propose that if anyone would like to look at the PR and has any feedback, please do so by the end of March 17th – after that, we can merge if there are no objections.

Thanks!

Tom

--
You received this message because you are subscribed to the Google Groups "astropy-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to astropy-dev...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/astropy-dev/a8387a77-5805-42ff-b863-579f01c23d7dn%40googlegroups.com.