This is from the astropy list. I'm wondering if we want to implement HJD in astropy?The funny thing about Heliocentric Julian Dates (and their cousin, BJD) is that they depend on where you're looking, so they aren't a simple timescale. So the question is how this could fit into the existing `Time` framework. Currently we have some time scales that depend on location on the earth, so in principal this could be done the same way, but then we'd have to add further attributes to `time` that don't really make sense in other contexts.So perhaps this is a call to not store `lat/lon` in Time, but rather in an `EarthLocation`. Then we can treat BJD/HJD the same way, but using the celestial coordinate objects instead of `EarthLocation`?
On Wed, Mar 26, 2014 at 8:05 AM, Erik Tollerud <erik.t...@gmail.com> wrote:
This is from the astropy list. I'm wondering if we want to implement HJD in astropy?The funny thing about Heliocentric Julian Dates (and their cousin, BJD) is that they depend on where you're looking, so they aren't a simple timescale. So the question is how this could fit into the existing `Time` framework. Currently we have some time scales that depend on location on the earth, so in principal this could be done the same way, but then we'd have to add further attributes to `time` that don't really make sense in other contexts.So perhaps this is a call to not store `lat/lon` in Time, but rather in an `EarthLocation`. Then we can treat BJD/HJD the same way, but using the celestial coordinate objects instead of `EarthLocation`?
I agree that replacing bare "lat/lon" with an object would give us more flexibility. For some spectral coordinate frames we also need to know where we are and where we are looking, and obviously you have azimuth, elevation coordinates. Presumably some thought is required in dealing with a location in the time and a location in the coordinate when we are associating a time with a coordinate (and what do we do if the coordinate has a different location to the time object).
--Tim Jenness--
You received this message because you are subscribed to the Google Groups "astropy-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to astropy-dev...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
It's easy enough in Time to add attributes that are available for doing transformations. So you are suggesting to replace Time.lat/lon with e.g. Time.earth_location, and then add something like Time.sky_coordinate?
I agree that replacing bare "lat/lon" with an object would give us more flexibility. For some spectral coordinate frames we also need to know where we are and where we are looking, and obviously you have azimuth, elevation coordinates. Presumably some thought is required in dealing with a location in the time and a location in the coordinate when we are associating a time with a coordinate (and what do we do if the coordinate has a different location to the time object).It seems like there should be a way to thread through these issues, but I agree it requires some thought.
- Tom--Tim Jenness--
You received this message because you are subscribed to the Google Groups "astropy-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to astropy-dev...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "astropy-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to astropy-dev...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
It's easy enough in Time to add attributes that are available for doing transformations. So you are suggesting to replace Time.lat/lon with e.g. Time.earth_location, and then add something like Time.sky_coordinate?
That's one possibility (I definitely think we want to replace `lat`/`lon` with `earth_location` once `EarthLocation` exists, but I think there's already agreement on that?).
It's easy enough in Time to add attributes that are available for doing transformations. So you are suggesting to replace Time.lat/lon with e.g. Time.earth_location, and then add something like Time.sky_coordinate?
That's one possibility (I definitely think we want to replace `lat`/`lon` with `earth_location` once `EarthLocation` exists, but I think there's already agreement on that?).A second option is to not have these be `Time` attributes at all, but rather require a transformation function or something like that to go from TDB to something else (or from something else to BJD/HJD). This goes back to the discussion around `sidereal_time`: there are some contexts where it's not really clear if `Time` should be an attribute of a coordinate, or if the coordinate should be an attribute of `Time`. So to prevent confusion, I was advocating neither - instead, use a function that must be given both. I'm not sure that's the best solution here, but it's something to consider, at least.
Yeah, that's a good point. To be fully general, I guess it's that we need a `from_location` and a `to_location`. That is, HJD/BJD care about what you're looking *at*, while TBD cares about where you're observing *from*. There's probably some better name for that, though - it's not really obvious that `to_location` is typically a celestial coordinate.
On Wed, Mar 26, 2014 at 6:19 PM, Thomas Robitaille <thomas.r...@gmail.com> wrote:
It's easy enough in Time to add attributes that are available for doing transformations. So you are suggesting to replace Time.lat/lon with e.g. Time.earth_location, and then add something like Time.sky_coordinate?
That's one possibility (I definitely think we want to replace `lat`/`lon` with `earth_location` once `EarthLocation` exists, but I think there's already agreement on that?).
Just a minor point - this should be Time.location (which could end up being set to EarthLocation, SpacecraftLocation, MarsLocation, etc), as earth_location would be too constraining, right?Tom
A second option is to not have these be `Time` attributes at all, but rather require a transformation function or something like that to go from TDB to something else (or from something else to BJD/HJD). This goes back to the discussion around `sidereal_time`: there are some contexts where it's not really clear if `Time` should be an attribute of a coordinate, or if the coordinate should be an attribute of `Time`. So to prevent confusion, I was advocating neither - instead, use a function that must be given both. I'm not sure that's the best solution here, but it's something to consider, at least.
--Erik T
--Erik T
Hello,
This just caught my attention. There has been a small bit of discussion between the SunPy devs about a general 'Observer' class. Mainly to deal with knowing where observations were taken from to deal with incomplete WCS headers etc.
I am wondering if making this slightly more general than Time is of interest to anyone else?
Stuart
Hi Stuart,This is definitely something on the horizon, although I think most of the discussion thus far has been between Marten and I. We had talked about an "Observatory" class, which would be a subclass of `EarthLocation` (although as I say, that, a more general `Location` is necessary here, given that SunPy and perhaps others would want to allow observer locations like satellites and such). This would contain the location information, *and* extra information like lists of telescopes at that location and maybe (down the road) instruments on those telescopes,instrument parameters, and the like.Is that the sort of thing you were thinking of?
Yeah, that's great, thanks Brett. Panoptes will indeed use something similar and I'm going to see if I can't just use that as a base class for our concept of Observatory. Our system is fundamentally an observatory control system (OCS) so does more than just what astroplan is doing but if we can use it and contribute back that would be great.
Thanks for responses.
You received this message because you are subscribed to a topic in the Google Groups "astropy-dev" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/astropy-dev/5KH5Ny1m6WY/unsubscribe.
To unsubscribe from this group and all its topics, send an email to astropy-dev...@googlegroups.com.