Patch with features proven useful

[huksley]

I am active user of Aseisql for two years. I have found this tool
very helpful.
Today I became aware that this project was outsourced. Right after
that I have created a patch
with features I have been missing all this time.

Here is description from patch:

- Removed completely insecure idea to grant execution of procedure to
public
if no grants found.

- Fixed view extract to include grants too.

- Removed annoying dialog when trying to reconnect already having
connection:
[ You are already connected to server ]
[ Do you want to disconnect now? ]

- Added context menu templates 'View rights', 'Table rights' to
extract
rights for corresponding objects.

- Replaced use <database> at the top of extracted object with comment
'-- from <database>'
this is especially usefull if you have different databases
with identical procedures.

- Added CRLF in grants in extracted objects. Usefull when you have
many
grant statements.

- Write all SQL statements to aseisql.log file in current directory.

Patch:
http://huksley.sdot.ru/wp-content/uploads/2009/07/aseisql-20090723.patch

Precompiled version (extract over existing installation)
http://huksley.sdot.ru/wp-content/uploads/2009/07/aseisql-patched-20090723.zip

[huksley]

I should note that this patch is made against SVN trunk version and
should be used with caution.

P.S. Sorry for the mess in format. I haven`t found any preview button.

[Julio C. Rodriguez]

Thanks Huskley for the new features,  I'm also an active user of AseIsql so you'll read from me if something goes wrong with them.

And talking about new features, have anyone noticed this 2 things?

1. when opening a view and recompiling it, the select permissions to it are not restored
2. open a stored procedure that contains a select statement that have a "for xml" clause, the "for xml" is not shown

If anyone can address this issues, we AseIsql users will be even happier!

Thanks a lot all of you for your great effort.

[aseisql]

hey huksley!
want to participate in project?
so you can commit it into svn...

[huksley]

> want to participate in project?
> so you can commit it into svn...

I would like to. However, not all modifications I have done are
equally usefull for everybody.
At least I believe there must be some discussions about them.

For example I commented out reconnection confirm dialog. I think it is
better implemented
as options checkbox, e.g. [x] Show reconnection warning.

And aseisql.log writing must be done with options checkbox too. And
write to temporary folder by default.

I am not very experienced in PowerBuilder. In fact, I have seen it
first time yesterday.

[huksley]

Hello Julio!

> when opening a view and recompiling it, the select permissions to it are not restored

My patch fixes this.

[aseisql]

On 24 июл, 08:35, huksley <rusla...@gmail.com> wrote:
> For example I commented out reconnection confirm dialog. I think it is
> better implemented
> as options checkbox, e.g. [x] Show reconnection warning.

I think it's not necessary, because if you press CTRL button when
reconnect, there will be no dialog box displayed.

About other changes, I'll check your code and apply it if it's Ok this
weekend.

[huksley]

> I think it's not necessary, because if you press CTRL button when
> reconnect, there will be no dialog box displayed.

Yes, I know about this. I meant not reconnection to the same database,
but to select other profile. We have dozen of servers so I use this
button very frequently.

Maybe it is better to implement using another button? E.g. "Connect to
profile"
and directly choose "Profiles" tab.

But such change is beyond my skill in PowerBuilder I`am afraid.

[Michel Henry de Generet]

Hello aseisql group,

Should you have to connect to multiple databases, it would be nice to set
specific colors for each class of connection (red for production, green for
user testing, white for development, ...)

Regards,
Michel

[aseisql]

And where to display this color?
In the status bar?

On 24 июл, 13:25, "Michel Henry de Generet" <m...@construsoft.be>
wrote:

[aseisql]

Ok. It's clear. I'll check it.

[Michel Henry de Generet]

As putty: in every content windows. Even better: in the task bar, but I
don't know if it easy.

[aseisql]

Huksley,

could you do the patch with TortoiseSVN?
just rightclick on the modified svn workcopy and select menu item
"tortoisesvn -> create patch"


On Jul 23, 7:17 pm, huksley <rusla...@gmail.com> wrote:
> Patch:http://huksley.sdot.ru/wp-content/uploads/2009/07/aseisql-20090723.patch

[huksley]

I can try only on monday.

And I don`t know is it possible, because I don`t have an
internet connection at the virtual machine I have installed all
aseisql toolchain to.

Do you have any problems applying a patch? Maybe need to remove added
comment from the top of the file?

You can try to use patch tool from gnuwin32
http://gnuwin32.sourceforge.net/packages/patch.htm

Must be used like this:
patch -p1 < file.patch
better make first run with --dry-run to check is everything ok.

[aseisql]

new version published trunk.92
new features:
- save history log into file (parametrized in options)
- disconnect confirmation (parametrized in options)
- object header now generated from stubs.sql (Procedure header, View
header)
if you want to customize it, add corresponding sections in
ustubs.sql
- colored profiles (default,yellow, and green)

[huksley]

Hello!

As far as I understand, this new version includes all my changes.

Only need to add modified templates to ustubs.sql
for Procedure header && View header for commenting out database use...

Thanks!

[Gabriel Tran (GôTô)]

Hi,

More colors could have been great, and I don't really like the way profiles are named (we have the same user name in DEV/REC/PROD but different database name so I prefer to have base name first).

But customizing profiles is really a good idea !

Thanks !

Gabriel

[aseisql]

Huksley,

As initiator, could you please test those features, and notify if
everything is ok.

[Thibaut Brard]

We can select and save the color when we create a profile and display this color on the text of the current connect database in the status bar?


Cordialement,
Thibaut Brard

2009/7/24 Michel Henry de Generet <m...@construsoft.be>

[Gabriel Tran (GôTô)]

Nope, only the aseisql icon changes and gets the color selected.
You can also change the color of an existing profile.

[huksley]

After 3 days of testing I can say everything is working fine.

[Julio C. Rodriguez]

sometimes when you try to double click>table ddl I get the message:

Attempt to insert NULL value into column 'id_order', table '#tmp'; column does not allow nulls. Update fails.

[Julio C. Rodriguez]

when you press the stop button and select "suicide" I get the following message

[aseisql]

Julio,

Please create separate issues here http://code.google.com/p/aseisql/issues/list
also for table ddl i need more infore
for which table (generate ddl in sybase central) you got this error?

On Jul 30, 12:46 am, "Julio C. Rodriguez" <juliocrodrig...@gmail.com>
wrote:

> when you press the stop button and select "suicide" I get the following message

> huksley wrote:After 3 days of testing I can say everything is working fine. On Jul 27, 2:55 pm, aseisql<dlukya...@ukr.net>wrote:Huksley, As initiator, could you please test those features, and notify if everything is ok. On 27 июл, 08:10, huksley<rusla...@gmail.com>wrote:Hello!As far as I understand, this new version includes all my changes.Only need to add modified templates to ustubs.sql for Procedure header && View header for commenting out database use...Thanks!
>
>  moz-screenshot-18.jpg
> 8KViewDownload