role attribute for html4.conf?

46 views
Skip to first unread message

Simon Ruderich

unread,
Mar 9, 2011, 12:27:33 PM3/9/11
to asci...@googlegroups.com
Hi,

Would a patch to add support for the role attribute for
html4.conf get accepted?

I know html4.conf is normally not used with CSS but I have a
setup where I use it with CSS and AFAIK the role attribute is the
only way to style block elements and I'd prefer if I could use
the official html4.conf sources.

Regards,
Simon
--
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9

Lex Trotman

unread,
Mar 9, 2011, 7:56:35 PM3/9/11
to asci...@googlegroups.com, Simon Ruderich
On 10 March 2011 04:27, Simon Ruderich <si...@ruderich.org> wrote:
> Hi,
>
> Would a patch to add support for the role attribute for
> html4.conf get accepted?

Hi Simon,

Probably not, since role is not an HTML4 attribute.

>
> I know html4.conf is normally not used with CSS but I have a
> setup where I use it with CSS and AFAIK the role attribute is the
> only way to style block elements and I'd prefer if I could use
> the official html4.conf sources.

The User Guide 11.2 states that role gets translated to the class
attribute for HTML which would be ok for you, but it doesn't, for
html4 or xhtml11. That looks like a bug in Asciidoc or the User Guide
:-).

Cheers
Lex

Simon Ruderich

unread,
Mar 10, 2011, 2:59:53 PM3/10/11
to asci...@googlegroups.com
On Thu, Mar 10, 2011 at 11:56:35AM +1100, Lex Trotman wrote:
> [snip]

>
>> I know html4.conf is normally not used with CSS but I have a
>> setup where I use it with CSS and AFAIK the role attribute is the
>> only way to style block elements and I'd prefer if I could use
>> the official html4.conf sources.
>
> The User Guide 11.2 states that role gets translated to the class
> attribute for HTML which would be ok for you, but it doesn't, for
> html4 or xhtml11. That looks like a bug in Asciidoc or the User Guide
> :-).

Hi Lex,

It works for xhtml11, the role gets translated to a class
attribute. Here's a part of the xhtml11.conf file:

[paragraph]
<div class="paragraph{role? {role}}"{id? id="{id}"}>{title?<div class="title">{title}</div>}<p>

I'd like the same for html4.conf so I can use it with CSS; the
patch is trivial, I just want to ask before I write (and use) it.

Lex Trotman

unread,
Mar 11, 2011, 3:12:54 AM3/11/11
to asci...@googlegroups.com, Simon Ruderich
On 11 March 2011 06:59, Simon Ruderich <si...@ruderich.org> wrote:
> On Thu, Mar 10, 2011 at 11:56:35AM +1100, Lex Trotman wrote:
>> [snip]
>>
>>> I know html4.conf is normally not used with CSS but I have a
>>> setup where I use it with CSS and AFAIK the role attribute is the
>>> only way to style block elements and I'd prefer if I could use
>>> the official html4.conf sources.
>>
>> The User Guide 11.2 states that role gets translated to the class
>> attribute for HTML which would be ok for you, but it doesn't, for
>> html4 or xhtml11.  That looks like a bug in Asciidoc or the User Guide
>> :-).
>
> Hi Lex,
>
> It works for xhtml11, the role gets translated to a class
> attribute. Here's a part of the xhtml11.conf file:
>
>    [paragraph]
>    <div class="paragraph{role? {role}}"{id? id="{id}"}>{title?<div class="title">{title}</div>}<p>
>
> I'd like the same for html4.conf so I can use it with CSS; the
> patch is trivial, I just want to ask before I write (and use) it.
>
>> Cheers
>> Lex

Hi Simon,

Ok, documentation needs improving, its doesn't say that

[role="abc"]
balh blah

translates to class="paragraph abc"

Naturally my css couldn't find a class abc. Does the same for other
block types.

Rather than change the documentation, I think it should use the role
as specified, otherwise the CSS needs to handle all the possible
compositions of the role and the block type, bet I forget one (at
least) :-)

That means something like:

[paragraph]
<div class="{role=paragraph}"{id? id="{id}"}>{title?<div


class="title">{title}</div>}<p>

And on reading more closely I see that the user guide doesn't claim
role works for html4, just xhtml.

Whilst it could be added, thing is you would have to add it to all the
block types, trivial but boring.

Simon Ruderich

unread,
Mar 11, 2011, 12:05:27 PM3/11/11
to asci...@googlegroups.com
On Fri, Mar 11, 2011 at 07:12:54PM +1100, Lex Trotman wrote:
> Hi Simon,
>
> Ok, documentation needs improving, its doesn't say that
>
> [role="abc"]
> balh blah
>
> translates to class="paragraph abc"

Well, it does say it, but not for html4, only for xhtml and
docbook, that's why I asked if a patch would get accepted to add
this ;-)

> [snip]


>
> [paragraph]
> <div class="{role=paragraph}"{id? id="{id}"}>{title?<div
> class="title">{title}</div>}<p>
>
> And on reading more closely I see that the user guide doesn't claim
> role works for html4, just xhtml.
>
> Whilst it could be added, thing is you would have to add it to all the
> block types, trivial but boring.

Yep, that's why I asked - to see if this trivial change would get
included before doing the boring work. Sorry if that wasn't
clear.

Lex Trotman

unread,
Mar 11, 2011, 7:08:15 PM3/11/11
to asci...@googlegroups.com, Simon Ruderich
On 12 March 2011 04:05, Simon Ruderich <si...@ruderich.org> wrote:
> On Fri, Mar 11, 2011 at 07:12:54PM +1100, Lex Trotman wrote:
>> Hi Simon,
>>
>> Ok, documentation needs improving, its doesn't say that
>>
>> [role="abc"]
>> balh blah
>>
>> translates to class="paragraph abc"
>
> Well, it does say it, but not for html4, only for xhtml and
> docbook,

Sorry I can't find where it says that, can you point me to it?

that's why I asked if a patch would get accepted to add
> this ;-)
>
>> [snip]
>>
>>  [paragraph]
>>  <div class="{role=paragraph}"{id? id="{id}"}>{title?<div
>> class="title">{title}</div>}<p>
>>
>> And on reading more closely I see that the user guide doesn't claim
>> role works for html4, just xhtml.
>>
>> Whilst it could be added, thing is you would have to add it to all the
>> block types, trivial but boring.
>
> Yep, that's why I asked - to see if this trivial change would get
> included before doing the boring work. Sorry if that wasn't
> clear.

Well I read your original as that you wanted to create a role
attribute, not the class attribute. Class makes sense. For a patch
as big as this we need Stuart, the main developer to decide.

Cheers
Lex

Simon Ruderich

unread,
Mar 11, 2011, 9:16:11 PM3/11/11
to asci...@googlegroups.com
On Sat, Mar 12, 2011 at 11:08:15AM +1100, Lex Trotman wrote:
>> Well, it does say it, but not for html4, only for xhtml and
>> docbook,
>
> Sorry I can't find where it says that, can you point me to it?

Quote from asciidoc.txt:

Common attributes
~~~~~~~~~~~~~~~~~
Most block elements support the following attributes:

[cols="1e,1,5a",frame="topbot",options="header"]
|====================================================================
|Name |Backends |Description

|id |html4, xhtml11, docbook |
Unique identifier typically serve as link targets.
Can also be set by the 'BlockId' element.

|role |xhtml11, docbook |
Role contains a string used to classify or subclassify an element and
can be applied to AsciiDoc block elements. The AsciiDoc 'role'
attribute is translated to the 'role' attribute in DocBook outputs and
to the 'class' attribute in HTML outputs.

[snip]

|====================================================================

Lex Trotman

unread,
Mar 11, 2011, 9:41:24 PM3/11/11
to asci...@googlegroups.com, Simon Ruderich
On 12 March 2011 13:16, Simon Ruderich <si...@ruderich.org> wrote:
> On Sat, Mar 12, 2011 at 11:08:15AM +1100, Lex Trotman wrote:
>>> Well, it does say it, but not for html4, only for xhtml and
>>> docbook,
>>
>> Sorry I can't find where it says that, can you point me to it?
>
> Quote from asciidoc.txt:
>
>    Common attributes
>    ~~~~~~~~~~~~~~~~~
>    Most block elements support the following attributes:
>
>    [cols="1e,1,5a",frame="topbot",options="header"]
>    |====================================================================
>    |Name |Backends |Description
>
>    |id |html4, xhtml11, docbook |
>    Unique identifier typically serve as link targets.
>    Can also be set by the 'BlockId' element.
>
>    |role |xhtml11, docbook |
>    Role contains a string used to classify or subclassify an element and
>    can be applied to AsciiDoc block elements.  The AsciiDoc 'role'
>    attribute is translated to the 'role' attribute in DocBook outputs and
>    to the 'class' attribute in HTML outputs.


Yes, I quoted 11.2 and I read that as it translates [role="abc"] to
class="abc" I don't see that it says anything that could be construed
as producing class="paragraph abc"

And as I said before the "paragraph abc" approach has the potential
for multiplying the names that the CSS has to look for, ie paragraph
abc, literal abc, listing abc, paragraph def, listing def, literal def
etc I guess we need to know from Stuart why it is done that way.

Cheers
Lex

Simon Ruderich

unread,
Mar 18, 2011, 10:06:57 AM3/18/11
to asci...@googlegroups.com, Stuart Rackham
On Wed, Mar 09, 2011 at 06:27:33PM +0100, Simon Ruderich wrote:
> Hi,
>
> Would a patch to add support for the role attribute for
> html4.conf get accepted?
>
> I know html4.conf is normally not used with CSS but I have a
> setup where I use it with CSS and AFAIK the role attribute is the
> only way to style block elements and I'd prefer if I could use
> the official html4.conf sources.
>
> Regards,
> Simon

Hi Stuart,

What do you think?

Stuart Rackham

unread,
Apr 11, 2011, 1:36:46 AM4/11/11
to asci...@googlegroups.com

On 10/03/11 06:27, Simon Ruderich wrote:
> Hi,
>
> Would a patch to add support for the role attribute for
> html4.conf get accepted?

I don't have a problem with it, for consistency the coverage should be the same
as currently for xhtml11.

Cheers, Stuart

Simon Ruderich

unread,
Apr 11, 2011, 11:46:10 AM4/11/11
to asci...@googlegroups.com
On Mon, Apr 11, 2011 at 05:36:46PM +1200, Stuart Rackham wrote:
> On 10/03/11 06:27, Simon Ruderich wrote:
>> Hi,
>>
>> Would a patch to add support for the role attribute for
>> html4.conf get accepted?

Hi Stuart,

> I don't have a problem with it, for consistency the coverage should be the
> same as currently for xhtml11.

There's one problem with that. xhtml11.conf uses <div>s around
every element which makes using {role} very easy. However
html4.conf never uses <div>s, making it impossible to get the
same coverage as in xhtml11.conf.

My current approach is to apply the {role} only to the main
element (like <ol>, <table>, <p>, ...). I don't want to add
<div>s around each element as it changes the design.

What do you think? Is it okay to get a different {role} behavior?

Stuart Rackham

unread,
Apr 11, 2011, 4:36:55 PM4/11/11
to asci...@googlegroups.com

On 12/04/11 03:46, Simon Ruderich wrote:
> On Mon, Apr 11, 2011 at 05:36:46PM +1200, Stuart Rackham wrote:
>> On 10/03/11 06:27, Simon Ruderich wrote:
>>> Hi,
>>>
>>> Would a patch to add support for the role attribute for
>>> html4.conf get accepted?
>
> Hi Stuart,
>
>> I don't have a problem with it, for consistency the coverage should be the
>> same as currently for xhtml11.
>
> There's one problem with that. xhtml11.conf uses<div>s around
> every element which makes using {role} very easy. However
> html4.conf never uses<div>s, making it impossible to get the
> same coverage as in xhtml11.conf.

The Devil is always in the details :-)

>
> My current approach is to apply the {role} only to the main
> element (like<ol>,<table>,<p>, ...). I don't want to add
> <div>s around each element as it changes the design.
>
> What do you think? Is it okay to get a different {role} behavior?

I agree that adding div's is not a good idea (the rationale of the html4 backend
is to generate minimal HTML), so let's got with what you've got.

Cheers, Stuart


>
> Regards,
> Simon

Simon Ruderich

unread,
Apr 12, 2011, 3:35:18 PM4/12/11
to asci...@googlegroups.com
On Tue, Apr 12, 2011 at 08:36:55AM +1200, Stuart Rackham wrote:
> I agree that adding div's is not a good idea (the rationale of the html4
> backend is to generate minimal HTML), so let's got with what you've got.
>
> Cheers, Stuart

Great, here's my patch.

Btw. why has html4.conf DOS line endings?

Regards,
Simon
---
doc/asciidoc.txt | 2 +-
html4.conf | 48 +++++++++++++++++++++++-----------------------
tests/data/testcases.txt | 6 +++++
3 files changed, 31 insertions(+), 25 deletions(-)

diff --git a/doc/asciidoc.txt b/doc/asciidoc.txt
index 5800a94..1fab2d8 100644
--- a/doc/asciidoc.txt
+++ b/doc/asciidoc.txt
@@ -1011,7 +1011,7 @@ Most block elements support the following attributes:


Unique identifier typically serve as link targets.
Can also be set by the 'BlockId' element.

-|role |xhtml11, docbook |
+|role |html4, xhtml11, docbook |


Role contains a string used to classify or subclassify an element and
can be applied to AsciiDoc block elements. The AsciiDoc 'role'
attribute is translated to the 'role' attribute in DocBook outputs and

diff --git a/html4.conf b/html4.conf
index 01b16f4..b8b6c6d 100644
--- a/html4.conf
+++ b/html4.conf
@@ -37,13 +37,13 @@ endif::asciidoc7compatible[]
template::[pi-blockmacro]

[image-inlinemacro]
-<a href="{link}">
+<a href="{link}"{role? class="{role}"}>
# src attribute must be first attribute for blogpost compatibility.
<img src="{imagesdir=}{imagesdir?/}{target}" style="border-width: 0;" alt="{alt={target}}"{width? width="{width}"}{height? height="{height}"}{title? title="{title}"}>
{link#}</a>

[image-blockmacro]
-<div{align? align="{align}"}{float? style="float:{float};"}>
+<div{align? align="{align}"}{role? class="{role}"}{float? style="float:{float};"}>
<a name="{id}"></a>
<a href="{link}">
<img src="{imagesdir=}{imagesdir?/}{target}" style="border-width: 0;" alt="{alt={target}}"{width? width="{width}"}{height? height="{height}"}>
@@ -95,12 +95,12 @@ item=<li>|</li>
text=<p>|</p>

[listtags-numbered]
-list={id?<a name="{id}"></a>}{title?<p><b>{title}</b></p>}<ol type="{style@arabic:1}{style@loweralpha:a}{style@upperalpha:A}{style@lowerroman:i}{style@upperroman:I}"{start? start="{start}"}>|</ol>
+list={id?<a name="{id}"></a>}{title?<p><b>{title}</b></p>}<ol type="{style@arabic:1}{style@loweralpha:a}{style@upperalpha:A}{style@lowerroman:i}{style@upperroman:I}"{start? start="{start}"}{role? class="{role}"}>|</ol>
item=<li>|</li>
text=<p>|</p>

[listtags-labeled]
-list={id?<a name="{id}"></a>}{title?<p><b>{title}</b></p>}<dl>|</dl>
+list={id?<a name="{id}"></a>}{title?<p><b>{title}</b></p>}<dl{role? class="{role}"}>|</dl>
entry=
label=
term=<dt>{strong-option?<strong>}|{strong-option?</strong>}</dt>
@@ -108,7 +108,7 @@ item=<dd>|</dd>
text=<p>|</p>

[listtags-horizontal]
-list={id?<a name="{id}"></a>}{title?<p><b>{title}</b></p>}<table cellpadding="4">|</table>
+list={id?<a name="{id}"></a>}{title?<p><b>{title}</b></p>}<table cellpadding="4"{role? class="{role}"}>|</table>
entry=<tr valign="top">|</tr>
label=<td{labelwidth? width="{labelwidth}%"}>{strong-option?<strong>}|{strong-option?</strong>}</td>
term=|<br>
@@ -116,12 +116,12 @@ item=<td{itemwidth? width="{itemwidth}%"}>|</td>
text=<p>|</p>

[listtags-callout]
-list={id?<a name="{id}"></a>}{title?<p><b>{title}</b></p>}<ol>|</ol>
+list={id?<a name="{id}"></a>}{title?<p><b>{title}</b></p>}<ol{role? class="{role}"}>|</ol>
item=<li>|</li>
text=<p>|</p>

[listtags-qanda]
-list={id?<a name="{id}"></a>}{title?<p><b>{title}</b></p>}<ol>|</ol>
+list={id?<a name="{id}"></a>}{title?<p><b>{title}</b></p>}<ol{role? class="{role}"}>|</ol>
entry=<li>|</li>
label=
term=<p><em>|</em></p>
@@ -129,7 +129,7 @@ item=
text=<p>|</p>

[listtags-glossary]
-list={id?<a name="{id}"></a>}{title?<p><b>{title}</b></p>}<dl>|</dl>
+list={id?<a name="{id}"></a>}{title?<p><b>{title}</b></p>}<dl{role? class="{role}"}>|</dl>
entry=
label=
term=<dt>|</dt>
@@ -137,7 +137,7 @@ item=<dd>|</dd>
text=<p>|</p>

[listtags-bibliography]
-list={id?<a name="{id}"></a>}{title?<p><b>{title}</b></p>}<ul>|</ul>
+list={id?<a name="{id}"></a>}{title?<p><b>{title}</b></p>}<ul{role? class="{role}"}>|</ul>
item=<li>|</li>
text=<p>|</p>

@@ -207,7 +207,7 @@ endif::deprecated-quotes[]

# Paragraph substitution.
[paragraph]
-<p>{id?<a name="{id}"></a>}{title?<b>{title}</b><br>}
+<p{role? class="{role}"}>{id?<a name="{id}"></a>}{title?<b>{title}</b><br>}
|
</p>

@@ -221,7 +221,7 @@ template::[admonitionblock]
[listingblock]
<a name="{id}"></a>
<p><b>{title}</b></p>
-<table border="0" bgcolor="#e8e8e8" width="100%" cellpadding="10"><tr><td>
+<table border="0" bgcolor="#e8e8e8" width="100%" cellpadding="10"{role? class="{role}"}><tr><td>
<pre>
|
</pre>
@@ -230,13 +230,13 @@ template::[admonitionblock]
[literalblock]
<a name="{id}"></a>
<p><b>{title}</b></p>
-<pre>
+<pre{role? class="{role}"}>
|
</pre>

[sidebarblock]
<a name="{id}"></a>
-<table frame="border" bgcolor="#ffffee" width="100%" cellpadding="15">
+<table frame="border" bgcolor="#ffffee" width="100%" cellpadding="15"{role? class="{role}"}>
<tr><td>
<p><em>{title}</em></p>
|
@@ -256,7 +256,7 @@ template::[quoteblock]

[quoteblock]
<a name="{id}"></a>
-<blockquote>
+<blockquote{role? class="{role}"}>
<p><b>{title}</b></p>
|
<p align="right">
@@ -267,7 +267,7 @@ template::[quoteblock]

[verseblock]
<a name="{id}"></a>
-<blockquote>
+<blockquote{role? class="{role}"}>
<p><b>{title}</b></p>
# Font inheritance broken in IE6.
<pre style="font-family: inherit;">
@@ -282,14 +282,14 @@ template::[quoteblock]
[exampleblock]
<a name="{id}"></a>
<p><b>{caption={example-caption} {counter:example-number}. }</b>{title}</p>
-<table frame="border" width="100%" cellpadding="15">
+<table frame="border" width="100%" cellpadding="15"{role? class="{role}"}>
<tr><td style="border-left: 2px solid silver;">
|
</td></tr></table>

[admonitionblock]
<a name="{id}"></a>
-<table frame="void" cellpadding="8">
+<table frame="void" cellpadding="8"{role? class="{role}"}>
<tr valign="top"><td><p><b><u>{caption}</u></b></p></td>
<td style="border-left: 1px solid silver;">
<p><b>{title}</b></p>
@@ -301,7 +301,7 @@ template::[quoteblock]
# JavaScripts).
<a name="{id}"></a>
<p><b>{title}</b></p>
-<div>
+<div{role? class="{role}"}>
|
</div>

@@ -338,7 +338,7 @@ bodydata=<td {colspan@1::colspan="{colspan}" }{rowspan@1::rowspan="{rowspan}" }a
paragraph=

[table]
-<div{align? align="{align}"}>
+<div{align? align="{align}"}{role? class="{role}"}>
<a name="{id}"></a>
<table rules="{grid=all}"
style="float:{float};"
@@ -412,24 +412,24 @@ cellspacing="0" cellpadding="4">

[sect1]
{doctype-manpage%}<hr>
-<h2>{id?<a name="{id}"></a>}{numbered?{sectnum} }{title}</h2>
+<h2{role? class="{role}"}>{id?<a name="{id}"></a>}{numbered?{sectnum} }{title}</h2>
|

[sect2]
-<h3>{id?<a name="{id}"></a>}{numbered?{sectnum} }{title}</h3>
+<h3{role? class="{role}"}>{id?<a name="{id}"></a>}{numbered?{sectnum} }{title}</h3>
|

[sect3]
-<h4>{id?<a name="{id}"></a>}{numbered?{sectnum} }{title}</h4>
+<h4{role? class="{role}"}>{id?<a name="{id}"></a>}{numbered?{sectnum} }{title}</h4>
|

[sect4]
-<h5>{id?<a name="{id}"></a>}{title}</h5>
+<h5{role? class="{role}"}>{id?<a name="{id}"></a>}{title}</h5>
|

[appendix]
<hr>
-<h2>{id?<a name="{id}"></a>}{numbered?{sectnum} }{appendix-caption} {counter:appendix-number:A}: {title}</h2>
+<h2{role? class="{role}"}>{id?<a name="{id}"></a>}{numbered?{sectnum} }{appendix-caption} {counter:appendix-number:A}: {title}</h2>
|

[footer]
diff --git a/tests/data/testcases.txt b/tests/data/testcases.txt
index 2feaae9..4160a5e 100644
--- a/tests/data/testcases.txt
+++ b/tests/data/testcases.txt
@@ -130,6 +130,12 @@ ifdef::backend-xhtml11[]
endif::[]


+== role attribute ==
+
+[role="test"]
+Paragraph with a role attribute.
+
+
== Break list nesting ==
1. List 1.
2. List 1.
--
1.7.4.4

Stuart Rackham

unread,
Apr 12, 2011, 6:57:59 PM4/12/11
to asci...@googlegroups.com
Thanks Simon, I've committed your patch to the trunk:
http://code.google.com/p/asciidoc/source/detail?r=ef9d33a8599489ac38e897f4a9aedb705e288b6e


Cheers, Stuart

Stuart Rackham

unread,
Apr 13, 2011, 10:11:40 PM4/13/11
to asci...@googlegroups.com

On 13/04/11 07:35, Simon Ruderich wrote:

>
> Btw. why has html4.conf DOS line endings?
>

Can't remember, historical accident probably.


Cheers, Stuart

Simon Ruderich

unread,
Apr 15, 2011, 11:07:33 AM4/15/11
to asci...@googlegroups.com
On Thu, Apr 14, 2011 at 02:11:40PM +1200, Stuart Rackham wrote:
> Can't remember, historical accident probably.
>
> Cheers, Stuart

Plans to fix it? Looks like most files are "affected".

Regards,
Simon

Stuart Rackham

unread,
Apr 15, 2011, 8:01:10 PM4/15/11
to asci...@googlegroups.com
OK, I've converted the 39 DOS formatted conf and text files for the sake of
consistency.
http://code.google.com/p/asciidoc/source/detail?r=92bb88255ccd584a4a277161626cd50700ce9ca6

I think the reason for the DOS formated files was so that users of early
versions of Internet Explorer could view the source without it being garbled
(but this is no longer necessary). Hopefully there was no deeper reason.


Cheers, Stuart

Simon Ruderich

unread,
Apr 16, 2011, 3:12:32 PM4/16/11
to asci...@googlegroups.com
On Sat, Apr 16, 2011 at 12:01:10PM +1200, Stuart Rackham wrote:
> OK, I've converted the 39 DOS formatted conf and text files for the sake of
> consistency.
> http://code.google.com/p/asciidoc/source/detail?r=92bb88255ccd584a4a277161626cd50700ce9ca6
>
> I think the reason for the DOS formated files was so that users of early
> versions of Internet Explorer could view the source without it being garbled
> (but this is no longer necessary). Hopefully there was no deeper reason.
>
> Cheers, Stuart

Thanks for your quick response and fix.

Simon Ruderich

unread,
Apr 23, 2011, 6:28:53 PM4/23/11
to asci...@googlegroups.com
On Sat, Apr 16, 2011 at 09:12:32PM +0200, Simon Ruderich wrote:
> On Sat, Apr 16, 2011 at 12:01:10PM +1200, Stuart Rackham wrote:
>> OK, I've converted the 39 DOS formatted conf and text files for the sake of
>> consistency.
>> http://code.google.com/p/asciidoc/source/detail?r=92bb88255ccd584a4a277161626cd50700ce9ca6
>>
>> I think the reason for the DOS formated files was so that users of early
>> versions of Internet Explorer could view the source without it being garbled
>> (but this is no longer necessary). Hopefully there was no deeper reason.
>>
>> Cheers, Stuart
>
> [snip]

Hi Stuart,

Just remembered that the default asciidoc.conf sets newline=\r\n,
should this get changed as well or is this a too intrusive
change?

Stuart Rackham

unread,
Apr 23, 2011, 8:51:19 PM4/23/11
to asci...@googlegroups.com

On 24/04/11 10:28, Simon Ruderich wrote:
> On Sat, Apr 16, 2011 at 09:12:32PM +0200, Simon Ruderich wrote:
>> On Sat, Apr 16, 2011 at 12:01:10PM +1200, Stuart Rackham wrote:
>>> OK, I've converted the 39 DOS formatted conf and text files for the sake of
>>> consistency.
>>> http://code.google.com/p/asciidoc/source/detail?r=92bb88255ccd584a4a277161626cd50700ce9ca6
>>>
>>> I think the reason for the DOS formated files was so that users of early
>>> versions of Internet Explorer could view the source without it being garbled
>>> (but this is no longer necessary). Hopefully there was no deeper reason.
>>>
>>> Cheers, Stuart
>>
>> [snip]
>
> Hi Stuart,
>
> Just remembered that the default asciidoc.conf sets newline=\r\n,
> should this get changed as well or is this a too intrusive
> change?

I'll leave this, unlike the source files it's documented and it can be easily
changed by setting the newline attribute.

Cheers, Stuart

>
> Regards,
> Simon

Simon Ruderich

unread,
Apr 24, 2011, 1:56:15 PM4/24/11
to asci...@googlegroups.com
On Sun, Apr 24, 2011 at 12:51:19PM +1200, Stuart Rackham wrote:
> I'll leave this, unlike the source files it's documented and it can be
> easily changed by setting the newline attribute.
>
> Cheers, Stuart

Good point.

Thanks for the quick reply.

Reply all
Reply to author
Forward
0 new messages