E-Mails not expanded when used with manual line breaks

38 views
Skip to first unread message

Simon Ruderich

unread,
May 16, 2009, 10:40:38 AM5/16/09
to asci...@googlegroups.com
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

I'm using AsciiDoc 8.4.4. In the following example the E-Mail is
not converted to a link.

Text +
te...@example.org +
Text

It works if I use the mailto macro.

Thanks,
Simon
- --
+ privacy is necessary
+ using http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iQIcBAEBCAAGBQJKDtBmAAoJEJL+/bfkTDL5LX4P/RgcWQvUQrWmrRMwOE9oLQfA
e+3zd7cx1zN9ZHzEHR0tPUWHtqnxPiPpPjQSYXOMoo169mr0p3tsM2XHqp9L6F32
XBMc8g6EbKOcqDTH8kayheWdt5IDSybrDLMXS13WB9lS0ofoEmHwQPpcFYh/rqWw
aAyN7hASW7vRSPf6M+FVEAsK09wy5kPkQA/SVPneOUog9iLXeE5lXp5fl/JxaXIX
860PaQHpbH9qq2xWVEIXysCo8Dg/KKwV3KVLpDxzunwVh1hloyxKvYmUQQ18tcH7
hSUwdr8gvTsOa/mX5XdzqQWvdszuRWu+b829JB4D8zqGzNy0Qk9i5wB6OSayMBf0
uXQoeLeCJzHNfSfN62lQM17SiRU/LgQWQ5rWVlf9xQK9i6DaDB53AFpT/ndweZ1Q
MuccDsmG7ccUnjtFb4H3BnA9zId5vtxS6RIb4MCPKwjC45vJ86qeCuSLGb9lQMvG
EhgigoZvQJoeGBb+RgwgQs799gzb/vbtKEt3jITwCWB2kBDiE6m9gK/Y0rLSsw2M
JG7fhnwJZAV8bAayq+N9hSXhhJaUd7ncENzm5iqm+yp09TiYx0BLjIcjmCjfO4Bg
CrH9nKZ/s+78H9udjIwRrC3847CAP7xVQf00OHrnOAIiha+9G0nzQ4RxStSZlJ1r
mGakSU46txri2sjqi+cd
=A2ZB
-----END PGP SIGNATURE-----

Stuart Rackham

unread,
May 17, 2009, 5:26:13 PM5/17/09
to asci...@googlegroups.com
Simon Ruderich wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Hi,
>
> I'm using AsciiDoc 8.4.4. In the following example the E-Mail is
> not converted to a link.
>
> Text +
> te...@example.org +
> Text
>
> It works if I use the mailto macro.

This anomoly will only occur is an email address is followed immediately
by a + line break. It can be cured by moving the line break replacement
from [replacements] to [replacements2] so the replacement occurs after
the mailto macro, if there are no side effects I'll put it in the trunk.

Cheers, Stuart

Simon Ruderich

unread,
May 22, 2009, 6:00:57 AM5/22/09
to asci...@googlegroups.com
On Mon, May 18, 2009 at 09:26:13AM +1200, Stuart Rackham wrote:
> This anomoly will only occur is an email address is followed immediately
> by a + line break. It can be cured by moving the line break replacement
> from [replacements] to [replacements2] so the replacement occurs after
> the mailto macro, if there are no side effects I'll put it in the trunk.
>
> Cheers, Stuart

Hi,

I tested it and for me it works fine (patch for xhtml and html
attached).

I tried to add a test for the testsuite but I don't understand
how it works. If running `testasciidoc.py update` creates the
test files how can a `testasciidoc.py run` check if the result is
fine? Shouldn't the result files be added to Mercurial as well?

Thanks,
Simon

patch.diff
signature.asc

Stuart Rackham

unread,
May 25, 2009, 12:25:52 AM5/25/09
to asci...@googlegroups.com
Simon Ruderich wrote:
> On Mon, May 18, 2009 at 09:26:13AM +1200, Stuart Rackham wrote:
>> This anomoly will only occur is an email address is followed immediately
>> by a + line break. It can be cured by moving the line break replacement
>> from [replacements] to [replacements2] so the replacement occurs after
>> the mailto macro, if there are no side effects I'll put it in the trunk.
>>
>> Cheers, Stuart
>
> Hi,
>
> I tested it and for me it works fine (patch for xhtml and html
> attached).
>
> I tried to add a test for the testsuite but I don't understand
> how it works. If running `testasciidoc.py update` creates the
> test files how can a `testasciidoc.py run` check if the result is
> fine? Shouldn't the result files be added to Mercurial as well?

I always run the tests before committing so you can guarantee that the
'testasciidoc.py --force update' will generate a good set of result
files (provided you run it before making any changes to asciidoc.

Cheers, Stuart


>
> Thanks,
> Simon
>

Simon Ruderich

unread,
May 25, 2009, 6:46:42 AM5/25/09
to asci...@googlegroups.com
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Mon, May 25, 2009 at 04:25:52PM +1200, Stuart Rackham wrote:
> I always run the tests before committing so you can guarantee that the
> 'testasciidoc.py --force update' will generate a good set of result
> files (provided you run it before making any changes to asciidoc.
>
> Cheers, Stuart

Hi,

Good to know, thanks.

I tried to run `testasciidoc.py --force update` from the
Mercurial source tree but I get some errors.

WRITING: data/testcases-html4.html
WRITING: data/testcases-xhtml11.html
WRITING: data/testcases-docbook.xml
WRITING: data/testcases-wordpress.html
Traceback (most recent call last):
File "./testasciidoc.py", line 407, in <module>
tests.update(number, backend, force=force)
File "./testasciidoc.py", line 318, in update
test.update(backend, force=force)
File "./testasciidoc.py", line 205, in update
self.update_expected(backend)
File "./testasciidoc.py", line 184, in update_expected
lines = self.generate_expected(backend)
File "./testasciidoc.py", line 177, in generate_expected
asciidoc.execute(infile, outfile, backend)
File "/home/simon/development/editor/asciidoc/tests/asciidocapi.py", line 231, in execute
raise AsciiDocError(self.messages[-1])
asciidocapi.AsciiDocError: FAILED: filters-test.txt: line 35: undefined filter attribute in command: graphviz2png.py {verbose?-v} -o "{outdir}/{target}" -L {layout=dot} -

Do I need a special setup to run the tests?

I tried to skip this test and ran `./testasciidoc.py --force
update 4` and got this error:

WRITING: data/source-highlight-filter-html4.html
WRITING: data/source-highlight-filter-xhtml11.html
WRITING: data/source-highlight-filter-docbook.xml
Traceback (most recent call last):
File "./testasciidoc.py", line 407, in <module>
tests.update(number, backend, force=force)
File "./testasciidoc.py", line 318, in update
test.update(backend, force=force)
File "./testasciidoc.py", line 205, in update
self.update_expected(backend)
File "./testasciidoc.py", line 184, in update_expected
lines = self.generate_expected(backend)
File "./testasciidoc.py", line 177, in generate_expected
asciidoc.execute(infile, outfile, backend)
File "/home/simon/development/editor/asciidoc/tests/asciidocapi.py", line 231, in execute
raise AsciiDocError(self.messages[-1])
asciidocapi.AsciiDocError: FAILED: source-highlight-filter.txt: line 40: unexpected error:

Thanks for your help,
Simon
- --

+ privacy is necessary
+ using http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iQIcBAEBCAAGBQJKGncSAAoJEJL+/bfkTDL5WWUP/jVrrM8Fy6uyolk1ijLs3BUh
Rs9lNDdfJwmTXsG5DrgQwA0b72LEDItdZHPTh7OLWeISNahTClDeNxR9EhHagaWT
3Y2kO14UaFTHs1h6bmOzxdAevK/kAGPVTvN7PZgZhHfq2Yv9dNAIEPQUjKhTf/ty
yYX0+E5igRDYUx4ADg+Hqnz6/RsCogmVcEq6sxuiiOuGQ3D4Z3lKYecNnTbHh8TN
Y5G1kxhT/UYnzvMF0ggtacKzGfo+g82byxqU3sLDQfg/23Ho12cPbySh6AZmPIdn
hN1Wn0yfNgkQbBQPthB4FJ3/ya8+YebhkwWaWi5daLAHf3q60I7kCPzxP/PxHKgE
e7YxbREjPGrAPVM7qUDfpkInCykJydk6wZbOQzIZ+08wpfDeAQu151WC5eEEUAmm
YgjH4MGA+eegMLKk6MOLyzmLPvgN5gPxbIPWY/M8bKLPVRz9WG/Df5myoPM6tyBc
CUuE0FlkYc+62IUpY55JDeaOpP9udvy26+XAuDWurpPUJ4/K8Met5WCxnFB/0Izd
1svr8mGyOJLYq7rYKMMBOt3B5gulvbASYInaoB09i+WLHmDUmfrGai8mzhSbvRoV
n+4lylx0XpkOT8BV1rCQL1HvZTO1D1yY1BT273eChvmcgAZ6466PcOSbi/hIGEcw
yryiESfS5rSxcscz5niS
=xF8M
-----END PGP SIGNATURE-----

Stuart Rackham

unread,
May 25, 2009, 4:14:11 PM5/25/09
to asci...@googlegroups.com
You need to run from the current trunk version (the version you're
running here is not the latest).

Cheers, Stuart

Simon Ruderich

unread,
May 26, 2009, 3:35:21 AM5/26/09
to asci...@googlegroups.com
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Tue, May 26, 2009 at 08:14:11AM +1200, Stuart Rackham wrote:
> You need to run from the current trunk version (the version you're
> running here is not the latest).
>
> Cheers, Stuart

Thanks, now it works. I had an older version of AsciiDoc in
/usr/bin but I assumed the tests would automatically use the
asciidoc in the Mercurial checkout. I removed AsciiDoc from
/usr/bin and it works fine.

Thanks,


Simon
- --
+ privacy is necessary
+ using http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iQIcBAEBCAAGBQJKG5u5AAoJEJL+/bfkTDL5PosP/RUDGqZ2JLpqlmZzFNf8Jh2G
FQYZId/Zr4zN5tnuF05/UFiaPwjllzoVsSg9br+MRJy8xV/7Scv4iViSFF30f0FI
Yfp2R3u8uQCQew5OKCf5O7VuH2Pmz2cjkKlHp53jTbtnC/NHw1nrYsZgCjAgdJxV
T2fGwf6CeQwt6xR9iAUwSXJ/1iSNeSojl7a87hGoldsRk3uhGVOnbZjvQ6urFBfN
12fe33N3t98T1Esx3TCuN2UVzT78zCU0r3Af0hQN/W0+ZvAuMHUeUQgszr0sD30Z
LjxiF9h9TvgLmO657odJ+xyRrDWB2wlDEZVvk+7C+qD3jccJfsnu77qqiJ5vzf7y
8bJwF41YJQ1DKVGGjsI7qhcJKCAIROppRCbSM0mHgJBqcPKozdoGNfN8iSkz57w1
YOc7SLHLAcBuxeKErzyrrNgC83FxxucvI5py/jZjjkbaZbI6UR+a6XpVqNYKkoqd
oC0OppJPUmq16crQa7qh7qLOiq/1Z/DoNhwVZSotTZU12RxojK7vDuoWAMViabER
jUiIl0A+gva4WRb8xN+b1YoppTl3wCNsD1cIlvd5nOLQAXVacp5WklQ7BJuN8SEY
32qdYLj/YnfV/7DCi+MS404+K4lAFXwj8jJfhB3VO27jx9vN71yVRN8XLRmlj9n8
ejUnLpECq5pxxR1R88zd
=LBe1
-----END PGP SIGNATURE-----

Reply all
Reply to author
Forward
0 new messages