Bug fix in Upload.as

[Quentin]

Hi there,
I just downloaded the sources from SVN and played with it a bit and
I've noticed a strange behaviour with some parameters in
Upload.upload...

In fact, it seems like hidden, is_family, is_friend and is_public are
not handled correctly.
I commented the "if ([parameter])" on lines with "sig +=" and "vars.
[parameter]" and everything was smooth!

Here what the blocks now look like:

/*if ( hidden ) */sig += "hidden" + ( hidden ? 1 : 0 );
/*if ( is_family ) */sig += "is_family" + ( is_family ? 1 : 0 );
/*if ( is_friend ) */sig += "is_friend" + ( is_friend ? 1 : 0 );
/*if ( is_public ) */sig += "is_public" + ( is_public ? 1 : 0 );

and

/*if ( hidden ) */sig += vars.hidden = ( hidden ? 1 : 0 );
/*if ( is_family ) */vars.is_family = ( is_family ? 1 : 0 );
/*if ( is_friend ) */vars.is_friend = ( is_friend ? 1 : 0 );
/*if ( is_public ) */vars.is_public = ( is_public ? 1 : 0 );

Anyone confirms that?

[Quentin]

Outch!
And I've just notice the oddity in the first line of the second block!
I guess it should be:

/*if ( hidden ) */vars.hidden = ( hidden ? 1 : 0 );

[Quentin]

I've also found errors in ManualFlickrTest.as, is there any way I can
commit to the SVN?
I guess I have to be added to the members' list...

Mike Chambers' reading?
I hope I can help.

Quentin.

[Quentin]

I've also got issues with special chars in the title, description and
tag arguments!
Couldn't find any fix, even with escape or encodeURIComponent...

Any idea?