Signal and boolean flag property names

23 views
Skip to first unread message

eidiot

unread,
Jun 2, 2011, 9:42:56 PM6/2/11
to as3-s...@googlegroups.com
Hi all, 

I have a problem with signal and boolean flag property names, like "selected" signal and "selected" property:

public interface IActionItem 
{
    function get selected():Signal;
    function get isSelected():Boolean;

    function get started():Signal;
    function get isStarted():Boolean;

    function get completed():Signal;
    function get isCompleted():Boolean;
}
 
Or 

public interface IActionItem 
{
    function get selectedSignal():Signal;
    function get selected():Boolean;

    function get startedSignal():Signal;
    function get started():Boolean;

    function get completedSignal():Signal;
    function get completed():Boolean;
}

Which is better, or, any other suggestions?

Best Regards & Thanks
eidiot

Robert Penner

unread,
Jun 2, 2011, 11:23:52 PM6/2/11
to as3-s...@googlegroups.com

Are you sure you need both?

eidiot

unread,
Jun 2, 2011, 11:33:40 PM6/2/11
to as3-s...@googlegroups.com
Sometimes I do need a signal been dispatched and a boolean property to mark something has happened. 
And a similar problem with boolean argument and method name like:

public function displayAvatar(id:String, drawShadow:Boolean = false):void 
{
    ...
    if (drawShadow) 
    {
        drawShadow();
    }
}

public function displayAvatar(id:String, drawShadow:Boolean = false):void 
{
    ...
    if (drawShadow) 
    {
        doDrawShadow();
    }
}

public function displayAvatar(id:String, ifDrawShadow:Boolean = false):void 
{
    ...
    if (ifDrawShadow) 
    {
        drawShadow();
    }
}

These two naming-problem have confused me for several times.
Reply all
Reply to author
Forward
0 new messages