Re: AS3 byte encoding bug

[Ben Hood]

Peter,

On Wed, Aug 20, 2008 at 7:50 PM, Peter Kieltyka
<peter.k...@gmail.com> wrote:
> Hey Ben,
>
> I found a bug in the AS3 that has to do with passing arguments to a queue
> declaration. Below is the code example:
>
> connection <0.165.0> (running), channel 1 - error:
> {amqp,frame_error,
> "cannot decode
> <<0,0,0,8,0,0,0,28,17,114,97,98,98,105,116,109,113,46,112,114,101,115,101,110,99,101,83,5,103,97,109,101,120>>",
> 'queue.declare'}
>
>
> code:
> var queue:org.amqp.methods.queue.Declare = new
> org.amqp.methods.queue.Declare();
> queue.queue = q;
> queue.autodelete = true;
> queue.arguments.put("rabbitmq.presence", exchange);
> sessionHandler.dispatch(new Command(queue));
>
> exchange is a variable with the string "gamex".
>
> I tried to look into a fix but it'll take me a bit of time to get familiar
> with your communication layer.

Thanks for reporting this. Until now, there was no test coverage of
table encoding.

I've applied a provisional fix in github which seems to work for some
rudimentary testing, but I'd like to follow this up with some proper
unit tests when time permits.

HTH,

Ben

[Ben Hood]

Peter,

On Thu, Aug 21, 2008 at 1:24 AM, Ben Hood <0x6e...@gmail.com> wrote:
> I've applied a provisional fix in github which seems to work for some
> rudimentary testing, but I'd like to follow this up with some proper
> unit tests when time permits.

BTW, I deliberately left the tabs in that changeset so as to not
complicate any small merges. I'd like to remove the tabs in one go for
all files after all of your changes have been merged. I think this
will provide more comprehensible diffs for merging. Is this OK?

Ben