Issue 81 in ardb: ARDB can't export to Secret Library

[codesite...@google.com]

Status: New
Owner: ----

New issue 81 by gsan...@gmail.com: ARDB can't export to Secret Library
http://code.google.com/p/ardb/issues/detail?id=81

What steps will reproduce the problem?
1. Create a deck
2. Export deck to Secret Library (Ctrl + L)
3. Enter SL login details

What is the expected output? What do you see instead?
I expected some notification that the deck was successfully uploaded to SL,
but instead I see "Invalid username or password" (even if login information
is correct).

What version of the product are you using? On what operating system?
3.1.1 on WinXP (XP Mode in Win7)

Please provide any additional information below.
This has also been raised in the VEKN forum (http://bit.ly/qY3HMy)

[codesite...@google.com]

Comment #1 on issue 81 by Woodru...@gmail.com: ARDB can't export to
Secret Library
http://code.google.com/p/ardb/issues/detail?id=81

I have looked at the code.
On Windows Vista, I was able to use version 3.1.1 successfully.
Uploaded two decks with success.
I will look into this further.

Rob

[codesite...@google.com]

Updates:
Status: Accepted
Labels: Type-Defect Component-Logic Usability

Comment #2 on issue 81 by gokturk....@gmail.com: ARDB can't export to
Secret Library
http://code.google.com/p/ardb/issues/detail?id=81

We make a simple HTTP POST. One thing in my mind is that when the user has
a special character as a part of his password, it may not be escaped
correctly. For example, having '&' in the password might cause a problem
like that.

[...]

In fact I just stopped typing and tested this claim on my Windows 7 VM with
WxWidgets-2.9.2 and ardb-3.1.1. Given this:

Password: ardb&issue/81?

I was able to reproduce the problem. For another account that does not have
anything but ASCII letters in its password, it worked fine.

I need to look at the code again to confirm but this is the mostly likely
explanation IMHO.

[codesite...@google.com]

Comment #3 on issue 81 by gokturk....@gmail.com: ARDB can't export to
Secret Library
http://code.google.com/p/ardb/issues/detail?id=81

DeckUpload.cpp:
------------------
67 | postBuffer += wxT("username=") + sUserName + wxT("&");
68 | postBuffer += wxT("password=") + sPassword + wxT("&");

This confirms it I guess. I'll go over HTTP and try to submit a patch;

[codesite...@google.com]

Comment #4 on issue 81 by gsan...@gmail.com: ARDB can't export to Secret
Library
http://code.google.com/p/ardb/issues/detail?id=81

Thanks for the quick action! Indeed, my password has special characters.

[codesite...@google.com]

Updates:
Status: Started

Comment #5 on issue 81 by gokturk....@gmail.com: ARDB can't export to
Secret Library
http://code.google.com/p/ardb/issues/detail?id=81

(No comment was entered for this change.)

[codesite...@google.com]

Comment #6 on issue 81 by gokturk....@gmail.com: ARDB can't export to
Secret Library
http://code.google.com/p/ardb/issues/detail?id=81

I don't a Windows build environment to test this. Can anyone test the
attached patch? This should, in theory, solve the problem.

Attachments:
ardb-issue86-uriencode-fix.patch 848 bytes

[codesite...@google.com]

Comment #7 on issue 81 by Woodru...@gmail.com: ARDB can't export to
Secret Library
http://code.google.com/p/ardb/issues/detail?id=81

I will try and use this fix. As I have a build environment. I appreciate
the help.

[codesite...@google.com]

Comment #8 on issue 81 by carl.ced...@gmail.com: ARDB can't export to
Secret Library
http://code.google.com/p/ardb/issues/detail?id=81

Any chance of a new windows build with the latest couple of fixes, this one
and 69?

[codesite...@google.com]

Comment #9 on issue 81 by gokturk....@gmail.com: ARDB can't export to
Secret Library
http://code.google.com/p/ardb/issues/detail?id=81

Well I've spent the last two days trying to build it on Windows. So far I
had the linker dying on me while building wxwidgets, libxml2 refusing to
statically link against libiconv and g++ insisting on linking against
libstdc++ dynamically even though I pass "-static-libgcc -static-libstdc++'.

I actually don't know why we have to do static linking. I mean it's good
that you can take the binary wherever you want but that wouldn't work for
us as we check the current binary's folder for the config file, card images
etc.

If I can't do it the static way, I'll just distribute the dlls along with
the package.

[codesite...@google.com]

Comment #10 on issue 81 by gokturk....@gmail.com: ARDB can't export to
Secret Library
http://code.google.com/p/ardb/issues/detail?id=81

I have uploaded the new version (3.2). It's a static binary just like
before. I even removed the dependency on mingw dll, if there ever was one.
Please have a look. I'll move it to the main page in two days.

[codesite...@google.com]

Updates:
Status: Fixed

Comment #11 on issue 81 by gokturk....@gmail.com: ARDB can't export to
Secret Library
http://code.google.com/p/ardb/issues/detail?id=81

This is fixed in 3.2. Closing.