Issue 68 in ardb: Inventory does not work.

6 views
Skip to first unread message

codesite...@google.com

unread,
Apr 21, 2010, 3:59:49 AM4/21/10
to ardb-...@googlegroups.com
Status: Accepted
Owner: graham.r.smith

New issue 68 by graham.r.smith: Inventory does not work.
http://code.google.com/p/ardb/issues/detail?id=68

Hi,

I just found a very (very, very) annoying bug in ARDB 3.1.0. Okay, maybe
I'm exaggerating a bit because I just realised the bug has messed up my
ARDB inventory containing all of my 10000:s of cards which means I may have
to redo it all. But anyway, as many other problems with ARDB this is
related to entering new cards when having selected a specific expansion.

Previously, there was a bug/dysfunction in that whenever a specific
expansion was chosen and new cards entered into the inventory, these new
cards would be "transferred" to the first expansion featuring those cards
rather than staying in the expansion where they were entered, and added to
the total amount there. This made it impossible to record how many cards in
the inventory were from which expansion, but that's perhaps a minor
problem.

Now however, when selecting a specific expansion and entering cards there
(which is still useful when entering many new cards which are all from the
same expansion, as it makes finding the cards' entries faster), the amount
entered is no longer added to the previous number of those cards; rather,
the previous number of those cards is -replaced- by the amount entered for
the specific expansion!

Needless to say, this is a rather severe bug for anyone who uses ARDB for
inventory tracking, as it actually destroys the inventory when entering new
cards. Which is what happened to me in this case.




--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups "ardb-devel" group.
To post to this group, send email to ardb-...@googlegroups.com.
To unsubscribe from this group, send email to ardb-devel+...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/ardb-devel?hl=en.

codesite...@google.com

unread,
Apr 21, 2010, 4:17:03 AM4/21/10
to ardb-...@googlegroups.com
Updates:
Labels: Type-Defect Priority-Critical OpSys-All

Comment #1 on issue 68 by gokturk....@gmail.com: Inventory does not work.
http://code.google.com/p/ardb/issues/detail?id=68

Do you think we should implement some sort of back up mechanism for the
database so
that in any situation the db would be backed up.

In initial state we can ask user with a message box whether he wants back
up feature,
then create a backup/ directory, copy the current db, and whenever another
backup is
required, take the diff, save it and that way you don't have only the
current one but
also couple previous database states as well.

codesite...@google.com

unread,
Apr 21, 2010, 4:27:25 AM4/21/10
to ardb-...@googlegroups.com

Comment #2 on issue 68 by graham.r.smith: Inventory does not work.
http://code.google.com/p/ardb/issues/detail?id=68

I think we need something for the inventory. The data is to valuable to be
left
hanging around in the database.

We also need a better UI that allow user to more easily add cards for a
specific set.

codesite...@google.com

unread,
Apr 21, 2010, 4:42:42 AM4/21/10
to ardb-...@googlegroups.com

Comment #3 on issue 68 by gokturk....@gmail.com: Inventory does not work.
http://code.google.com/p/ardb/issues/detail?id=68

A quick question, how do we save the inventory? Inside the database or in a
simple file?

codesite...@google.com

unread,
Apr 21, 2010, 4:46:45 AM4/21/10
to ardb-...@googlegroups.com

Comment #4 on issue 68 by graham.r.smith: Inventory does not work.
http://code.google.com/p/ardb/issues/detail?id=68

A xml file right now.

codesite...@google.com

unread,
Apr 21, 2010, 5:45:35 AM4/21/10
to ardb-...@googlegroups.com

Comment #5 on issue 68 by gokturk....@gmail.com: Inventory does not work.
http://code.google.com/p/ardb/issues/detail?id=68

Do you think it's worth saving it into a database? I'm not very well
familiar with
libsqlite but i can work on backup implementation. What do you think?

codesite...@google.com

unread,
Apr 21, 2010, 7:03:28 AM4/21/10
to ardb-...@googlegroups.com

Comment #6 on issue 68 by graham.r.smith: Inventory does not work.
http://code.google.com/p/ardb/issues/detail?id=68

Probably a good idea to make a copy of the database table each time it
starts up.

g.

codesite...@google.com

unread,
Apr 21, 2010, 7:07:30 AM4/21/10
to ardb-...@googlegroups.com

Comment #7 on issue 68 by graham.r.smith: Inventory does not work.
http://code.google.com/p/ardb/issues/detail?id=68

That should be make a copy of the inventory table each time ardb starts up.

codesite...@google.com

unread,
Jul 29, 2010, 4:28:12 PM7/29/10
to ardb-...@googlegroups.com

Comment #8 on issue 68 by JFHarden: Inventory does not work.
http://code.google.com/p/ardb/issues/detail?id=68

Is anyone actively working on backing up the database?

If not how about something as simple as making a copy of cards.db at
program start up (before the database is read)? Allow the user to specify a
maximum amount of space to use for backups and just keep as many cards.db
backups as possible, named by date and time? This gives an advantage of
being able to restore the whole database even in the event of filesystem
corruption.

For now just keep the backup copies and allow the user to manually replace
them. In the future add an interface to load a backup db instead of the
current one? I'm just picturing a list of backups available. If the
database is so corrupt it cant load the user could be informed and
presented a list of database backups to load.

I'm imagining a preferences option with a tick box for keep backups (which
should be the default IMHO) and a text box (or slider) to pick a maximum
number of MB of Databases.

I have my cards inventoried as well btw, hence why I care :)

As an aside the backups could be compressed which reduces the db size from
about 5MB to about 900K using gzip.

codesite...@google.com

unread,
Jul 29, 2010, 7:10:01 PM7/29/10
to ardb-...@googlegroups.com

Comment #9 on issue 68 by gokturk....@gmail.com: Inventory does not work.
http://code.google.com/p/ardb/issues/detail?id=68

Personally, no. I still wanna work on unit testing and automake-autoconf
stuff first. I had couple ideas for backing up the database but have no
time for it.

codesite...@google.com

unread,
Jul 30, 2010, 12:40:18 PM7/30/10
to ardb-...@googlegroups.com

Comment #10 on issue 68 by Woodruffr1973: Inventory does not work.
http://code.google.com/p/ardb/issues/detail?id=68

Just a note about this bug. It was a small error in the way information
was written to the database so now the error should be fixed. I think that
the database backup is more a feature request than a bug anymore and should
be designated as such.

However, I do think its a good idea to always backup a database.

Rob Woodruff

codesite...@google.com

unread,
Aug 1, 2010, 12:07:28 AM8/1/10
to ardb-...@googlegroups.com

Comment #11 on issue 68 by Woodruffr1973: Inventory does not work.
http://code.google.com/p/ardb/issues/detail?id=68

JFHarden, Just another less vague comment.
I like the idea of what your talking about with the backup database.
It sounds nice. And if and when graham does another build I would like for
you to see the fix I made to the inventory function. Any changes you would
recommend I will look at. I will hack away at the source and see if I can
get it to do the backup your talking about. I am also playing around with
having DRAFT text added to certain cards.

Rob

codesite...@google.com

unread,
Jan 21, 2013, 10:16:11 AM1/21/13
to ardb-...@googlegroups.com
Updates:
Status: Fixed

Comment #12 on issue 68 by gokturk....@gmail.com: Inventory does not work.
http://code.google.com/p/ardb/issues/detail?id=68

Revision 243 (https://code.google.com/p/ardb/source/detail?r=243) claims to
solve this issue. I'll close this bug and file a separate bug for the
backup mechanism.

Reply all
Reply to author
Forward
0 new messages