Critize Model and Comments

[Thomas Kellerer]

Hi,

MySQL does not allow column comments to be longer than 255 characters
and table comments longer than 60 characters.

I wrote a new Critic that checks these limits.

Any objection if I commit that?


Btw: why is get/setRemarks() not defined on SQLObject level?

Databases like Postgres or DB2 allow comments on any database object,
so from my perspective it would make sense to move get/setRemarks() to
SQLObject

Regards
Thomas

[Jonathan Fuerth]

On Tue, Jun 8, 2010 at 4:33 AM, Thomas Kellerer <google...@sql-workbench.net> wrote:

MySQL does not allow column comments to be longer than 255 characters
and table comments longer than 60 characters.

I wrote a new Critic that checks these limits.

That's great! I'm very excited about having a Critic contributed already.

Any objection if I commit that?

Thomas O'Brien is in the middle of a refactoring (well, more like completion) of that API right now. There may be some breaking changes, but we can absorb them. So commit away!

I'm especially interested in any feedback you might have from the point of view of implementing a critic, either now or after the refactorings are in place.

 

Btw: why is get/setRemarks() not defined on SQLObject level?

Databases like Postgres or DB2 allow comments on any database object,
so from my perspective it would make sense to move get/setRemarks() to
SQLObject

You're right. I'd also vote to move Remarks to SQLObject. Even where they can't be reverse/forward engineered, they still add value to the model. This is an easy change that shouldn't break file format compatibility in either direction (although remarks would get lost after re-saving a newer project in an older version of the app.)

-Jonathan

[Thomas Kellerer]

Hi Jonathan,

> That's great! I'm very excited about having a Critic contributed already.
>
>
> Any objection if I commit that?
>
>
> Thomas O'Brien is in the middle of a refactoring (well, more like
> completion) of that API right now. There may be some breaking changes,
> but we can absorb them. So commit away!

It's comitted.

Regards
Thomas