Physical name of a FK constraint

[Thomas Kellerer]

Hi,

I posted a bug report about changing the names of FK relationships:
http://www.sqlpower.ca/forum/posts/list/2601.page

As far as I can tell, the fix is quite simple:

In RelationshipEditPanel.applyChanges() on only needs to call

relationship.setPhysicalName(relationshipName.getText());

after setting the logical name.

At least until there is a logical/physical input field in the dialog
this should fix the problem.

Is it really that simple or am I missing something?

Regards
Thomas

[Jonathan Fuerth]

On Fri, Feb 5, 2010 at 1:59 PM, Thomas Kellerer <google...@sql-workbench.net> wrote:

In RelationshipEditPanel.applyChanges() on only needs to call

relationship.setPhysicalName(relationshipName.getText());

after setting the logical name.

At least until there is a logical/physical input field in the dialog
this should fix the problem.

Is it really that simple or am I missing something?

As simple as it sounds, I think you have it exactly right. It's probably an oversight that the relationship properties dialog is missing the physical name field in the first place.

Feel free to apply either fix (add the physical name field, or update physical name to match logical in applyChanges()).

-Jonathan

[Thomas Kellerer]

Jonathan Fuerth wrote on 05.02.2010 21:13:
> On Fri, Feb 5, 2010 at 1:59 PM, Thomas Kellerer
> <google...@sql-workbench.net

OK, I'll go for setting the physical name.

I don't really see the need to have a logical and physical name for a FK constraints (especially because you can have some descriptive labels in the diagram anyway)

Thomas

[Jonathan Fuerth]

On Fri, Feb 5, 2010 at 3:17 PM, Thomas Kellerer <google...@sql-workbench.net> wrote:

I don't really see the need to have a logical and physical name for a FK constraints (especially because you can have some descriptive labels in the diagram anyway)

Good point. I agree.

-Jonathan