Review Request: Issue47 branch
Roberto Alsina
* I fixed places that were broken (pagination outside the main branch of
the catalog)
* I made it prettier (at least as far as I can ;-)
* I added progress report in the statusbar for when pages are loading
* I cleaned the template quite a bit, and some of the code, too
* I fixed the "crumbs" that were broken about half of the time
I want *YOU* to test it. If there are no obvious bugs, this works much
better than the current plugin, and deserves a merge.
Then I start refactoring and bringing the other store plugins up to spec.
Andrés Gattinoni
<ral...@netmanagers.com.ar> wrote:
> I think I have improved the feedbooks plugin a whole lot.
>
> * I fixed places that were broken (pagination outside the main branch of the
> catalog)
> * I made it prettier (at least as far as I can ;-)
> * I added progress report in the statusbar for when pages are loading
> * I cleaned the template quite a bit, and some of the code, too
> * I fixed the "crumbs" that were broken about half of the time
>
> I want *YOU* to test it. If there are no obvious bugs, this works much
> better than the current plugin, and deserves a merge.
It's certanly much better.
- I would add some text in the status bar, so that you know what the
progress bar means.
- Also I was on page 8, I did right-click and hit "Go Back" and it
showed me a long unparsed text.
- Minor issue: can we avoid displaying "Languages" when you are in
"Feedbooks" > "Public domain books" > "Languages"?
- If you go to the link "View on FeedBooks", a link with the book id
is added to the breadcrumb. If you click on that link, it adds the
same item to the breadcrumb again and again.
That's all I see for now.
Ramiro Algozino
I've just tried it, First let me say that I'm loving the changes! :D,
with that said, I found that if I am viewing a book directly from
feedbooks (trough Aranduka) and I click Download I see in the progress
bar that something is being downloaded but then when it gets to 100%
nothing seems to happen :-/, It would be nice to add some indicative
text to the progress bar to know what is aranduka doing and show a
dialog when the file is downloaded indicating that is available in the
shelves I think.. I haven't found anything else to complain about..
:-)
Keep on the good work!
--
Ramiro Algozino
Ramiro Algozino
May be adding a "default action" when clicking on the book's cover
would be nice too.. it could be view it on Feedbooks because there you
have more information about the book.. :-)
--
Ramiro Algozino
Roberto Alsina
> On Mon, Feb 7, 2011 at 11:33 PM, Roberto Alsina
> <ral...@netmanagers.com.ar> wrote:
>> I think I have improved the feedbooks plugin a whole lot.
>>
>> * I fixed places that were broken (pagination outside the main branch of the
>> catalog)
>> * I made it prettier (at least as far as I can ;-)
>> * I added progress report in the statusbar for when pages are loading
>> * I cleaned the template quite a bit, and some of the code, too
>> * I fixed the "crumbs" that were broken about half of the time
>>
>> I want *YOU* to test it. If there are no obvious bugs, this works much
>> better than the current plugin, and deserves a merge.
> It's certanly much better.
> - I would add some text in the status bar, so that you know what the
> progress bar means.
> - Also I was on page 8, I did right-click and hit "Go Back" and it
> showed me a long unparsed text.
disable the context menu, or replace it.
The problem is that the webpage history contains the real data
(basically RSS in this case) instead of the massaged data (HTML) we are
displaying.
I could reimplement the menu without much effort, too.
> - Minor issue: can we avoid displaying "Languages" when you are in
> "Feedbooks"> "Public domain books"> "Languages"?
Not really. That is done using a generic parser. I will try to make it
smarter so the items are not so huge when there are no images, at least.
> - If you go to the link "View on FeedBooks", a link with the book id
> is added to the breadcrumb. If you click on that link, it adds the
> same item to the breadcrumb again and again.
Fixed!
Roberto Alsina
> 2011/2/7 Roberto Alsina<ral...@netmanagers.com.ar>:
>> I think I have improved the feedbooks plugin a whole lot.
>>
>> * I fixed places that were broken (pagination outside the main branch of the
>> catalog)
>> * I made it prettier (at least as far as I can ;-)
>> * I added progress report in the statusbar for when pages are loading
>> * I cleaned the template quite a bit, and some of the code, too
>> * I fixed the "crumbs" that were broken about half of the time
>>
>> I want *YOU* to test it. If there are no obvious bugs, this works much
>> better than the current plugin, and deserves a merge.
>>
>> Then I start refactoring and bringing the other store plugins up to spec.
>>
> I've just tried it, First let me say that I'm loving the changes! :D,
> with that said, I found that if I am viewing a book directly from
> feedbooks (trough Aranduka) and I click Download I see in the progress
> bar that something is being downloaded but then when it gets to 100%
> nothing seems to happen :-/,
what's supposed to happen ;-)
I just added a small status bar notification for it.
> It would be nice to add some indicative
> text to the progress bar to know what is aranduka doing and show a
> dialog when the file is downloaded indicating that is available in the
> shelves I think.. I haven't found anything else to complain about..
> :-)
Yes. This is a whole other branch though, because it needs big
improvements on the downloader.
Andrés Gattinoni
<ral...@netmanagers.com.ar> wrote:
>> - Also I was on page 8, I did right-click and hit "Go Back" and it
>> showed me a long unparsed text.
>
> Good catch! I really can't see how to fix this one. Maybe I'll just disable
> the context menu, or replace it.
>
> The problem is that the webpage history contains the real data (basically
> RSS in this case) instead of the massaged data (HTML) we are displaying.
>
> I could reimplement the menu without much effort, too.
I think we could remove the context menu altogether, and add a pair of
back/forward arrows to do the trick.
Maybe even the forward arrow is not necessary, and we can use only the
back arrow to follow back the breadcrumb.