How it works

79 views
Skip to first unread message

App Engine code reviews

unread,
Nov 8, 2012, 4:48:32 AM11/8/12
to
Upload your code change lists to http://codereview.appspot.com using the attached upload.py or your own if you already have one, and add appengine-c...@googlegroups.com in CC field. Better yet, use a +suffix convention to specify which language the code is written in. For instance, appengine-code...@googlegroups.com means it is something written in Python. That way it is easier to filter messages for a specific language.

Other folks subscribed to this group will see the message and (hopefully) start reviewing your code.

Creating a new change list
 
The full command would be something like this (from the root of your app):

./upload.py -t "My issue title" -m "Longer description of the issue" \
           
--send_mail --cc appengine-code-reviews+go@googlegroups.com

The above will try to guess your versioning system, create unified diffs, create a new issue on codereview.appspot.com with specified title and description, upload unified diffs (patch set) and send email to this mailing list.

If you're not sure the upload.py would make the right choices, you could do something like this:

./upload.py --print_diffs \
           
--send_mail --cc appengine-code-reviews+java@googlegroups.com

This command will try to guess your versioning system, show the unified diffs and stop at prompting you to enter new issue title. This way you can always stop it from going forward should you be not satisfied with the output.

Updating existing issue

Use -i <issue_id> argument to upload.py, e.g.

./upload.py -i 12345 --print_diffs

This will create a new patch set on codereview.appspot.com but won't send an email just yet. You should probably browse to the issue, go through the comments and mark them as "Done" or reply with a different message. Hit "m" key after you're done with all of them. This will bring up a summary screen ready to send email with the updated issue.

More info on how to use upload.py, reviewing the code and use codereview.appspot.com in general can be found here: http://code.google.com/p/rietveld/w/list

Happy coding/reviewing!

upload.py
Reply all
Reply to author
Forward
This conversation is locked
You cannot reply and perform actions on locked conversations.
0 new messages