[appengine-afterburner] r29 committed - ...

[appengine-...@googlecode.com]

Revision: 29
Author: appengine...@gmail.com
Date: Mon Jul 18 17:23:29 2011
Log:
Fixing double registration by using sets instead of lists.

Revision created by MOE tool push_codebase.
MOE_MIGRATION=942

http://code.google.com/p/appengine-afterburner/source/detail?r=29

Modified:
/trunk/python/src/afterburner/experimental/db/materialized_map.py
/trunk/python/src/afterburner/experimental/db/triggers.py

=======================================
--- /trunk/python/src/afterburner/experimental/db/materialized_map.py Thu
Mar 17 12:28:01 2011
+++ /trunk/python/src/afterburner/experimental/db/materialized_map.py Mon
Jul 18 17:23:29 2011
@@ -16,8 +16,6 @@

__author__ = 'mike.a...@gmail.com (Mike Aizatsky)'

-import logging
-
from afterburner import util
from afterburner.experimental.db import triggers
from google.appengine.ext import db
@@ -32,7 +30,7 @@

def trigger(key):
for f in MAPS.get(key.kind(), []):
- logging.error("applying %s to %s", f, key)
+
def tx():
si_query = SourceInfo.all().ancestor(key).filter('map_name', f)
si_list = si_query.fetch(1)
@@ -64,8 +62,7 @@
# TODO: kind can be class
def materialized_map(kind):
def decorator(f):
- # TODO: duplicate registration
- MAPS.setdefault(kind, []).append(util.fq_name(f))
+ MAPS.setdefault(kind, set()).add(util.fq_name(f))
triggers.TriggerManager.register_trigger(
kind, util.fq_name(trigger))
return f
=======================================
--- /trunk/python/src/afterburner/experimental/db/triggers.py Thu Mar 17
12:37:06 2011
+++ /trunk/python/src/afterburner/experimental/db/triggers.py Mon Jul 18
17:23:29 2011
@@ -265,10 +265,8 @@
@classmethod
def register_trigger(cls, entity_kind, function_name):
cls.init_if_needed()
- # TODO: double registration
- logging.error("register_trigger: %s, %s", entity_kind, function_name)
- cls.triggers[entity_kind] = (
- cls.triggers.get(entity_kind, []) + [function_name])
+ cls.triggers.setdefault(entity_kind, set())
+ cls.triggers[entity_kind].add(function_name)

@classmethod
def get_triggers(cls, entity_kind):