Comment on revision r53 in apache-rat-pd

0 views
Skip to first unread message

codesite...@google.com

unread,
Aug 24, 2009, 9:27:54 AM8/24/09
to apache-rat...@googlegroups.com
egor.pasko commented on revision r53 in project apache-rat-pd.
Details are at http://code.google.com/p/apache-rat-pd/source/detail?r=53

Score: Positive

General Comment:
cool! should be a much more ready-to-commit now!

Respond to these comments at
http://code.google.com/p/apache-rat-pd/source/detail?r=53
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings

codesite...@google.com

unread,
Aug 24, 2009, 9:52:11 AM8/24/09
to apache-rat...@googlegroups.com
egor.pasko commented on revision r53 in project apache-rat-pd.
Details are at http://code.google.com/p/apache-rat-pd/source/detail?r=53

Score: Positive


Line-by-line comments:

File: /trunk/src/main/java/org/apache/rat/pd/engines/Managable.java (r53)
===============================================================================

Line 28: * This interface define one function to implement. This function
can retrieve
-------------------------------------------------------------------------------
s/define/defines/

Line 43: boolean gueryEngine(String possibleCopyAndPastedCode) throws
IOException, ServiceException;
-------------------------------------------------------------------------------
I suspect this is a misprint and gueryEngine() should be renamed to
queryEngine()

Reply all
Reply to author
Forward
0 new messages