[AOLSERVER] Bug in gzip compression module

4 views
Skip to first unread message

Alexey Pechnikov

unread,
Oct 12, 2009, 12:28:13 PM10/12/09
to AOLS...@listserv.aol.com
Hello!

From config:

# add compression
ns_param gzip on
ns_param gzipmin 512

With settings above I get errors in big adp pages content like this:

23.09.09 16:54:19 74955807010 7916 Москва (mob) � ������ �ˎ6Mr���U�N�bJ��:|� \


Without gzip compression all pages are correct.

Best regards, Alexey Pechnikov.
http://pechnikov.tel/


--
AOLserver - http://www.aolserver.com/

To Remove yourself from this list, simply send an email to <list...@listserv.aol.com> with the
body of "SIGNOFF AOLSERVER" in the email message. You can leave the Subject: field of your email blank.

Daniel Stasinski

unread,
Oct 12, 2009, 2:19:55 PM10/12/09
to AOLS...@listserv.aol.com
> With settings above I get errors in big adp pages content like this:

Ugh, I've fixed this bug in AOLserver twice so far. Perhaps someone
undid it again.

| ---------------------------------------------------------------
| Daniel P. Stasinski | http://www.saidsimple.com
| dan...@avenues.org | http://www.disabilities-r-us.com
| XMMP: mooo...@avenues.org | http://www.avenues.org
| Google Talk: mooooooo | http://www.scriptkitties.com

Daniel Stasinski

unread,
Oct 12, 2009, 2:32:34 PM10/12/09
to AOLS...@listserv.aol.com
Ugh, I've fixed this bug in AOLserver twice so far. Perhaps someone
undid it again.

Daniel

| ---------------------------------------------------------------
| Daniel P. Stasinski | http://www.saidsimple.com
| dan...@avenues.org | http://www.disabilities-r-us.com
| XMMP: mooo...@avenues.org | http://www.avenues.org
| Google Talk: mooooooo | http://www.scriptkitties.com

Dossy Shiobara

unread,
Oct 12, 2009, 3:41:48 PM10/12/09
to AOLS...@listserv.aol.com
On 10/12/09 2:19 PM, Daniel Stasinski wrote:
>> With settings above I get errors in big adp pages content like this:
>
> Ugh, I've fixed this bug in AOLserver twice so far. Perhaps someone
> undid it again.

Or, perhaps Alexey isn't testing with HEAD? Did your fix make it into
AOLserver 4.5.1?


--
Dossy Shiobara | do...@panoptic.com | http://dossy.org/
Panoptic Computer Network | http://panoptic.com/
"He realized the fastest way to change is to laugh at your own
folly -- then you can let go and quickly move on." (p. 70)

Tom Jackson

unread,
Oct 12, 2009, 3:57:24 PM10/12/09
to AOLS...@listserv.aol.com
Daniel,

Without version info from the original poster, who knows? But for good
measure, could you link to your fix so we can figure out if it has
been undone? Your response indicates to me that you are more alert to
the telltale signs of a particular defect. But this isn't something
that I recognize. Help us out.

thanks,

tom jackson

Alexey Pechnikov

unread,
Oct 13, 2009, 3:46:37 AM10/13/09
to AOLS...@listserv.aol.com
Hello!

On Monday 12 October 2009 23:41:48 Dossy Shiobara wrote:
> > Ugh, I've fixed this bug in AOLserver twice so far. Perhaps someone
> > undid it again.
>
> Or, perhaps Alexey isn't testing with HEAD? Did your fix make it into
> AOLserver 4.5.1?

AOL version is 4.5.1

Debian src and bin repository directory is here
http://mobigroup.ru/debian/pool/main/a/aolserver4/

Best regards, Alexey Pechnikov.
http://pechnikov.tel/

Daniel Stasinski

unread,
Oct 13, 2009, 8:41:13 PM10/13/09
to AOLS...@listserv.aol.com
> Without version info from the original poster, who knows? But for good
> measure, could you link to your fix so we can figure out if it has
> been undone? Your response indicates to me that you are more alert to
> the telltale signs of a particular defect. But this isn't something
> that I recognize. Help us out.

Sorry for the delay but since I am on a 2 year sabbatical, accessing
the data was pretty difficult.

Here is the only patch I could find for 4.0.10 compress.c, which I
believe is now part of nszlib.c in 4.5. I don't think I applied it to
4.5 since I mostly moved over to Naviserver after 4.0.10. The
problem was caused by returning incorrect CRC values as well as
sending a few too many bytes back the to the user.

Patch is attached. I also attached the fixed compress.c. It's the
best I can do at the moment.

compress.c
compress.c.patch

Daniel Stasinski

unread,
Oct 15, 2009, 12:17:04 AM10/15/09
to AOLS...@listserv.aol.com
> Without version info from the original poster, who knows? But for good
> measure, could you link to your fix so we can figure out if it has
> been undone?

I wanted to follow up and make sure my diff and source file's actually
made it through since I'm not sure if the list allows attachments.
Can someone verify please?

Jeff Hobbs

unread,
Oct 15, 2009, 10:17:11 AM10/15/09
to AOLS...@listserv.aol.com
On 14-Oct-09, at 9:17 PM, Daniel Stasinski wrote:
>> Without version info from the original poster, who knows? But for
>> good
>> measure, could you link to your fix so we can figure out if it has
>> been undone?
>
> I wanted to follow up and make sure my diff and source file's actually
> made it through since I'm not sure if the list allows attachments.
> Can someone verify please?


Received with attachments.

Reply all
Reply to author
Forward
0 new messages