Some changes in backup mechanism

[Vadim Shkolin]

File modules of ansible ("copy", module and some others) can do backup of changed data. The standard naiming schema (timestamping and adding '~' in original directory) can have bad effects in "conf.d"-like distros.

Main idea: all backups placed into separate directory tree, based on /var/lib/ansible.backups. 1st backup is suffixed by '.orig', 2nd and more later are suffixed by timestamp. This schema is more reliable, and I made patch for it.

New schema example:

 /var/lib/ansible.backups/etc/zabbix
 /var/lib/ansible.backups/etc/zabbix/zabbix_agentd.conf.20130622-172930
 /var/lib/ansible.backups/etc/zabbix/zabbix_proxy.conf.20130622-172959
 /var/lib/ansible.backups/etc/zabbix/zabbix_proxy.conf.orig
 /var/lib/ansible.backups/etc/zabbix/zabbix_agentd.conf.20130614-033941

 /var/lib/ansible.backups/etc/zabbix/zabbix_agentd.conf.orig

Do you interested it? If so, how can I commit this changes into main tree?

[James Cammarata]

Since tasks are run as potentially different users (none of which may have root access), creating a common directory for backups may not work. Most likely, if this were implemented, the backup directory would have to be under the user's home directory by default.

--
You received this message because you are subscribed to the Google Groups "Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ansible-proje...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--

James Cammarata <jcamm...@ansibleworks.com>
Sr. Software Engineer, AnsibleWorks, Inc.
http://www.ansibleworks.com/

[Vadim Shkolin]

I think, that mostly all ansible users work as root - native or over sudo. OK, path for backups can be changed.

This is not "if this were implemented". This is implemented by me :).

Old (native) backup's mechanism is unusable:

1. It has potential conflict with "conf.d"-like distros

2. There is data overriding when file is modified twice in one playbook, for example, many "lineinfile" step-by-step. The first modification will make backup with pattern %Y-%m-%d@%H:%M~, and the second one will override this backup. Original file will lost, it is a BIG problem for production systems!

I changed the pattern to %Y%m%d-%H%M%S, and added version number suffix to it, if this file still exists (if step-by-step modifications will be in same second).

I can push this modification into new git branch, and you can check and modify it (add homedir in backup path, etc.), and merge into devel branch.

суббота, 12 октября 2013 г., 1:10:19 UTC+4 пользователь James Cammarata написал:

[Michael DeHaan]

I would be interested in seeing and commenting on the pull request.

We can see what it looks like and go from there.

Thanks!

Michael DeHaan <mic...@ansibleworks.com>
CTO, AnsibleWorks, Inc.
http://www.ansibleworks.com/

[Vadim Shkolin]

I made the pull request (username: vshkolin)

суббота, 12 октября 2013 г., 4:24:07 UTC+4 пользователь Michael DeHaan написал:

[Mike Ray]

What is the status of this? My team would find a feature like this immensely helpful.

It would be additionally useful if you could force it to only maintain X backups in said backup directory.

I see nothing in the changelogs about this.

[Michael DeHaan]

Remote backups?

Honestly haven't had time to attack.   I'll bump the priority though so it doesn't get lost in the shuffle -- it's a good idea -- and an OLD idea :)

To post to this group, send email to ansible...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/7656a5b6-b992-45e2-a151-8dfdb09dbc7c%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Mike Ray]

Yes I did see that it was several months ago... hooray for necro-posting.

But no, I was not suggesting remote backups. Simply put, it would be nice if I could:

1) tell ansible what directory to backup files to ( our playbooks run as root so permissions aren't a concern for me )

2) tell ansible how many backup files to maintain ( at least in 1.6.2, if I say "backup=yes" and then run a playbook 5 times, there will be 5 backups (assuming the file is changed) )

I'm new so it'd take me awhile, but if there are problems with vshkolin pull request, let me know and perhaps I can re-implement it.

Mike Ray

--
You received this message because you are subscribed to a topic in the Google Groups "Ansible Project" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/ansible-project/zYO3sKW1oMM/unsubscribe.
To unsubscribe from this group and all its topics, send an email to ansible-proje...@googlegroups.com.

To post to this group, send email to ansible...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/CA%2BnsWgzhFMbGyOaJ4oo9sHmvF13Lhg0s4GqiTeFtKxMdxa2uOw%40mail.gmail.com.

[Michael DeHaan]

Yeah I've had this idea for a year and a half it seems.

I'm proposing we do keep the backups on the ansible control machine in a configurable location with a number-to-keep.

When I mean remote, I pretty much mean the control machine vs a delegated host, but that could obviously be a NFS mount.

To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/CAKNKEX1eRsy1wHM%3DZ3vDZCAaDEwT41UYDUEzL0EHe4E9qbhNkg%40mail.gmail.com.