Error reporting for authorized_key module

[Francisco Reyes]

If the key file to read is not found, shouldn't the authorized_key module report an error?

Have this in a playbook

- name: Manage keys for users

    authorized_key: user={{item.uname}} key="{{lookup('file','~/Ansible/keys/' + item.uname + '/authorized_keys2') }}" 

                    manage_dir=yes

                     path='/home/{{item.uname}}/.ssh/authorized_keys2'

    with_items: Ops

I originally had the folder "Ansible" called something else. Upon rename keys stopped getting installed, but the module did not report an error.

[Michael DeHaan]

If the lookup file is not found, it *should* produce an exception, yes.

If you are seeing this behavior on the development branch, please make sure there is a ticket on github.

(To be clear, this has nothing to do with the authorized key module in the end, and everything to do with the lookup plugin)

Thanks!

--
You received this message because you are subscribed to the Google Groups "Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ansible-proje...@googlegroups.com.
To post to this group, send email to ansible...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/f33e8a28-d3e1-45c3-95c5-613e5140b35c%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Francisco Reyes]

On Tuesday, April 15, 2014 5:15:43 PM UTC-4, Michael DeHaan wrote:
>If the lookup file is not found, it *should* produce an exception, yes.
>If you are seeing this behavior on the development branch, please make sure there is a ticket on github.

ansible 1.6 (devel ae29e43f93) last updated 2014/04/19 14:46:18 (GMT +000)

Still has the issue

>(To be clear, this has nothing to do with the authorized key module in the end, and everything to do with the lookup plugin)

Looking at the documentation at http://docs.ansible.com/authorized_key_module.html there is also an option to use 

# Using with_file
- name: Set up authorized_keys for the deploy user
  authorized_key: user=deploy
                  key="{{ item }}"
  with_file:
    - public_keys/doe-jane
    - public_keys/doe-john

So in that case if the key file is not found, shouldn't it also produce an error?

Doesn't that mean that authorized_key itself should check that it has a file and not only the lookup plugin?

[Brian Coca]

the module actually does not work with files, it takes a string (key) as an input, the file lookup module lets you get those strings from files.​

[Michael DeHaan]

Yes.

This mayb ethe lookup plugin you have here evaluating lazily and then the authorized key module inserting the lookup call into the file. 

Obviously we don't want that, but there are reasons the lookup plugin itself doesn't error - but we should catch that later.

Before going further, can you share what version of ansible you are using?

If 1.7.X or 1.8 (devel), please go ahead and file a bug on this.

Thanks!

On Sun, Apr 13, 2014 at 3:36 PM, Francisco Reyes <fran...@natserv.net> wrote:

--

[Michael DeHaan]

Sorry, ignore that last one.

I was in our legacy email account from before the company name change and going through the wrong mail folder :)

To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/CAEVJ8QOJH%3DA06QYjEgFc6bKBEmzBKTMQJBQWytVBYvWVE1yjVQ%40mail.gmail.com.