lineinfile module replace only if line is present, do not add

[Kavin Kankeshwar]

Hi,

Wanted to know if it is possible for lineinfile to only replace line if regex matches, if it does not match do not add new line.

Is this possible ? From looks of it , does not seem to work.

Regards,

--

Kavin.Kankeshwar

[yann lawrence]

Hello Kavin, 

"... is it possible for lineinfile to only replace line if regex matches, if it does not match do not add new line."

This is exactly what lineinfile does... could you possibly give me an example of the problems you are having.. There may be a problem with your regular expression 

Ta, 

Yann

[Kavin Kankeshwar]

Yes, Even i thought it would, only replace not add. To make it work (i just added backrefs=yes and it works as i wanted to.

if i remove back refs , it keeps adding a new line.

    -name: Replace repo with new repo 

      local_action: lineinfile dest={{ item }} regexp='.*<url>ssh://jenkins@srch-gerrit00\.sv\.xyz\.com:29418/yyy\.git</url>*' line='        <url>g...@github.com:kavin/yyy.git<url>' backrefs=yes backup=yes

      with_fileglob:

        - /home/kavin/*/config.xml

    - name: Replace wipeworkspace to true

      local_action: lineinfile dest={{ item }} regexp='.*<wipeOutWorkspace>\w+</wipeOutWorkspace>*' line='    <wipeOutWorkspace>true</wipeOutWorkspace>' backup=yes backrefs=yes

      with_fileglob:

        - /home/kavin/*/config.xml

Regards,

--

Kavin.Kankeshwar

--
You received this message because you are subscribed to the Google Groups "Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ansible-proje...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Kavin Kankeshwar]

Any recommendations, (maybe my regex is wrong ? )

Regards,

--

Kavin.Kankeshwar

[Michael DeHaan]

Don't use lineinfile? :)

--

Michael DeHaan <mic...@ansibleworks.com>
CTO, AnsibleWorks, Inc.
http://www.ansibleworks.com/

[C. Morgan Hamill]

Excerpts from Kavin Kankeshwar's message of 2013-08-27 19:49:25 -0400:

> Yes, Even i thought it would, only replace not add. To make it work (i just
> added backrefs=yes and it works as i wanted to.
>
> if i remove back refs , it keeps adding a new line.

Wait, just to make sure I'm clear, when backrefs=yes, lineinfile
*doesn't* add a line, but only replaces the line matching 'regexp' if it
is found, and if 'regexp' is not found, does nothing?

But without backrefs=yes, lineinfile replaces 'regexp' if found, and if
not, adds 'line' to the file?

It seems like that's inconsistent, and probably a bug? Also a weird
one, as I don't think backrefs should have any affect on the actual
line-replacing behavior of lineinfile, only whether backrefs are allowed
or not?
--
Morgan

[Kavin Kankeshwar]

Yes, This confused me too a lot, As i have been using lineinfile before and earlier all my use cases were same, find and replace, if not matched add the file. So it worked fine for me. (i think it does it because state=present)

But in this case, I just wanted to replace a line if found and if not found dont do anything. And i could do what i wanted with using backrefs=yes.

My first thought was my regex itself is wrong or im doing something stupid. I am no regex guru but here is a snippet of my playbook.

    -name: Replace repo with new repo 

      local_action: lineinfile dest={{ item }} regexp='.*<url>ssh://jenkins@srch-gerrit00\.sv\.xyz\.com:29418/yyy\.git</url>*' line='        <url>g...@github.com:kavin/yyy.git<url>' backrefs=yes backup=yes

      with_fileglob:

        - /home/kavin/*/config.xml

    - name: Replace wipeworkspace to true

      local_action: lineinfile dest={{ item }} regexp='.*<wipeOutWorkspace>\w+</wipeOutWorkspace>*' line='    <wipeOutWorkspace>true</wipeOutWorkspace>' backup=yes backrefs=yes

      with_fileglob:

        - /home/kavin/*/config.xml

Regards,

--

Kavin.Kankeshwar

[senorsmile]

Holy cow, this confused me as well.  This behavior really doesn't make any sense to me.  Perhaps the documentation needs to be very clear about this behavior?!?!?

---

OK, I read the doc again.  After knowing this, it does hint at this behavior, but it's still not obvious.  It seems the default should be backrefs=yes  (which is apparently what it used to be?)

[Michael DeHaan]

Perhaps we should change "backrefs" to "replace" or something to make this more obvious.

[C. Morgan Hamill]

Excerpts from Michael DeHaan's message of 2013-10-15 19:36:14 -0400:

> Perhaps we should change "backrefs" to "replace" or something to make this
> more obvious.

Is this behavior intended? I thought the 'backrefs' option was supposed
to simply enable backrefs ('\1 \2' etc), not change the actual behavior
of the module.
--
Morgan Hamill

[Michael DeHaan]

That's what I was implying.

I don't see why you would get a substring out of one line and then add another.   

Please file a docs ticket on this (github.com/ansible/ansible)

Thanks!

--
You received this message because you are subscribed to the Google Groups "Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ansible-proje...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Ming Qian]

Hello Everyone,

Has this problem been fixed?
I actually had the exact same issue today.
I am using ansible 1.5.4

Thanks!

[Michael DeHaan]

Your version of Ansible is rather downlevel.

If you have a problem in 1.6.6 (the latest) let us know.

--
You received this message because you are subscribed to the Google Groups "Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ansible-proje...@googlegroups.com.

To post to this group, send email to ansible...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/e227a999-7ad9-4fe7-b4a6-1cedddb4fa9c%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Ming Qian]

Thanks for your quick reply!
I tried ansible 1.7 (devel 5e27f12ada).
It would appear that the problem still exists.

Thanks!

[Michael DeHaan]

Then perhaps we have an answer :)

If you don't see a related issue in github please do file one.

Thank you!

To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/5a93b905-8a42-43bf-906d-97ccfb81e1f8%40googlegroups.com.

[Ming Qian]

Thanks!

--
You received this message because you are subscribed to a topic in the Google Groups "Ansible Project" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/ansible-project/XmaC_YHWh00/unsubscribe.
To unsubscribe from this group and all its topics, send an email to ansible-proje...@googlegroups.com.

To post to this group, send email to ansible...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/CA%2BnsWgxXrceMOLQFv9NT%2BhoYGT6_0H%3DnMRrGbrmjM%3D%3DOv4ENxA%40mail.gmail.com.