Getting bug fix (pull request) into develop branch

40 views
Skip to first unread message

Patrick Galbraith

unread,
Apr 10, 2014, 11:10:40 AM4/10/14
to ansible...@googlegroups.com
Hi all,

I have a very simple pull request at https://github.com/CaptTofu/ansible/compare/nova_compute. This fix makes it so the ansible module, nova_compute, works with HP Cloud and any cloud provider that has more than one region. It simply does this by providing the region name which is used to discern which endpoint to use, otherwise you get an error.

I also have an impending fix that makes it possible to use newer versions of Nova (such as are used on HP Cloud) where floating IPs have to be explicitly assigned (so you can actually get into the VM to automate it). 

Is a pull request the best means of contributing code to the Ansible project? 

Thanks much!

Patrick aka "CaptTofu" Galbraith

Adam Morris

unread,
Apr 14, 2014, 4:22:07 PM4/14/14
to ansible...@googlegroups.com
Yes, but be aware that the PR queue is pretty long so it might be a while before they get to it.  

You might also want to join the Ansible Development list as well. https://groups.google.com/forum/#!forum/ansible-devel

Adam

Michael DeHaan

unread,
Apr 14, 2014, 10:04:32 PM4/14/14
to ansible...@googlegroups.com
Yeah no need to post to either list about a pull request, we prioritize incomings and do see everything.

For things that are bugfix related that are obviously small, things tend to be serviced *MUCH* quicker, so with this one, you shouldn't have any problems.

Submit a pull request via github if you haven't already.

Thanks!


--
You received this message because you are subscribed to the Google Groups "Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ansible-proje...@googlegroups.com.
To post to this group, send email to ansible...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/50db0eb6-31b8-4a17-8400-07200b5e7a87%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

Reply all
Reply to author
Forward
0 new messages