PR best practices
18 views
Skip to first unread message
Serghei Anicheev
Feb 6, 2017, 9:41:41 AM2/6/17
to Ansible Project
Hey everyone!
I just finished writing several modules for ansible.
However i would like to organize my PR correctly.
So here is the question:
- Should it be within single PR or should i break it into part for each module?
Best Regards
I just finished writing several modules for ansible.
However i would like to organize my PR correctly.
So here is the question:
- Should it be within single PR or should i break it into part for each module?
Best Regards
Brian Coca
Feb 6, 2017, 12:09:48 PM2/6/17
to Ansible Project
One per module, I also recommend you just submit the first module and
iterate with the reviewer, once that is merged you should have better
idea of what we look for and make subsequent module merging much
smoother.
----------
Brian Coca
iterate with the reviewer, once that is merged you should have better
idea of what we look for and make subsequent module merging much
smoother.
----------
Brian Coca
Reply all
Reply to author
Forward
0 new messages