Help testing new module

[Nick Kakouros]

I have created a pull request for a module for google cloud (PR 27194). There are 4 tests that fail, basically all the same:

ansible-test sanity --test import --python xxx

I have no idea how to fix this. The module needs libcloud to work, but perhaps I need to tell the tests where to find libcloud? Can someone give me some hints?

[Kai Stian Olstad]

On 23. juli 2017 17:31, Nick Kakouros wrote:
>
> I have created a pull request for a module for google cloud (PR 27194

> <https://github.com/ansible/ansible/pull/27194>). There are 4 tests that

> fail, basically all the same:
>
> ansible-test sanity --test import --python xxx
>
> I have no idea how to fix this. The module needs libcloud to work, but
> perhaps I need to tell the tests where to find libcloud? Can someone give
> me some hints?

Have you scrolled to the bottom and pressed details on shippable?
( https://app.shippable.com/github/ansible/ansible/runs/29986/1/console )

If you do you will see the following error message for Python 2.6, 2.7,
3.5 and 3.6.

2017-07-23 14:40:26 Run command: importer.py
lib/ansible/modules/cloud/google/gce_firewall.py
lib/ansible/modules/cloud/google/gce_net.py
2017-07-23 14:40:26 ERROR: Found 2 import issue(s) on python 2.6 which
need to be resolved:
2017-07-23 14:40:26 ERROR:
lib/ansible/modules/cloud/google/gce_firewall.py:181:0: NameError: name
'Provider' is not defined (100%)
2017-07-23 14:40:26 ERROR:
lib/ansible/modules/cloud/google/gce_net.py:226:0: NameError: name
'Provider' is not defined (100%)
2017-07-23 14:40:26 ERROR: The 1 sanity test(s) listed below (out of 2)
failed. See error output above for details.


--
Kai Stian Olstad

[Nick Kakouros]

Yes, I had done that, but my understanding of the issue was wrong. Your reply was like a wake up call! Thanks.

[Nick Kakouros]

And here I am stuck again. I have verified locally that Provider exists, but the test still fails. I found the file test/sanity/import/skip.txt. Should I include my module there?

[Kai Stian Olstad]

On 23. juli 2017 18:48, Nick Kakouros wrote:
> And here I am stuck again. I have verified locally that Provider exists,
> but the test still fails. I found the file test/sanity/import/skip.txt.
> Should I include my module there?

I can't help you, but you might have better luck in the developer list
https://groups.google.com/forum/#!forum/ansible-devel

--
Kai Stian Olstad

[Nick Kakouros]

I 'll try that, thanks.