JBoss module enhancements PR

139 views
Skip to first unread message

wre...@redhat.com

unread,
Jul 5, 2017, 9:44:13 AM7/5/17
to Ansible Development
Hi all--

I've submitted a PR that contains enhancements to the JBoss module that have been kicked around in the JBoss/Ansible community (there are dozens of us!!). If someone can take a look and give me some feedback, I'd be most grateful. Ansible has the potential to help a lot of JBoss shops that want to tighten up their development cycle but aren't ready to drink the DevOps kool-aid yet. In order to unlock that potential, we need more features in the JBoss module.

At this juncture, the JBoss module only supports deployment/undeployment via the filesystem using the deployment scanner (a JBoss service that scans a particular fs directory for deployable files and deploys them). This means it either adds or removes a deployment artifact (e.g., a .war file) to a specified deployment directory. In older versions of JBoss, this was the only way to do hot deployments, but starting with JBoss 7, users have the option of using a provided CLI as well as an HTTP interface in addition to the fs method. The fs method is not recommended for production use.

So as a first step towards enhancing the JBoss module, I've added support for deploying via the HTTP API and the CLI. Some of us have also talked about a facts module, possibly using jolokia to gather detailed data on JBoss environments. A jolokia module could also extend deployment capabilities to other Java environments, since it's not specific to JBoss.

Thanks!

Jairo Junior

unread,
Jul 5, 2017, 3:40:29 PM7/5/17
to Ansible Development
Hi,

I think we're working on something very similar: https://github.com/ansible/ansible/pull/25422 

I was discussing this PR at #ansible-devel (IRC) instead of the devel list, but I believe we could contribute to each other work or even combine efforts. (:

Greg DeKoenigsberg

unread,
Jul 7, 2017, 1:02:21 PM7/7/17
to Jairo Junior, Ansible Development
This seems like a good time to ask the question:

Do we want a JBoss Working Group?

Basically, a Working Group is a simple way of putting some structure
around specific project efforts. Gets you your own IRC channel (if you
want it) and some project/wiki space in the ansible/community repo.
It's a good lightweight governance mechanism for working together on
specific projects.

If you're interested, here's how to start one -- dead simple, by design:

https://github.com/ansible/community/blob/master/WORKING-GROUPS.md

--g
> --
> You received this message because you are subscribed to the Google Groups
> "Ansible Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to ansible-deve...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.



--
Greg DeKoenigsberg
Ansible Community Guy

Will Refvem

unread,
Jul 7, 2017, 2:34:28 PM7/7/17
to Greg DeKoenigsberg, Jairo Junior, Ansible Development, Tyler Cross
Greg/Jairo--

This sounds like a great idea. Ideas are floating around the community somewhat aimlessly right now, and it would be great if we had a forum to coordinate my work with the great work that Jairo and others are doing. It would also be great to have a place to send Ansible/JBoss users for info/questions/gripes/etc. 

Here's a wrinkle we might want to think about: the community project formerly known as JBoss is now Wildfly, and JBoss is sort of a Red Hat sub-brand assigned to various  supported (i.e. paid) middleware/app dev products. To my knowledge, no upstream community project carries the JBoss brand. To avoid confusion, we might want to think about calling the WG something like the Wildfly working group, even if we plan to support pre-Widlfly versoins of JBoss AS (i.e. 7.x and earlier), which I think we should. But I'm not married to that idea. I'd love to hear anyone else's thoughts.

If we can agree on a name, and Jairo, if you're interested & available, I'll go ahead and create a request to form the working group with you and I as members, and we can start coordinating work. I'll also search out JBoss-related issues and PR's for other potential members.

You received this message because you are subscribed to a topic in the Google Groups "Ansible Development" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/ansible-devel/nttHHu0nMxI/unsubscribe.
To unsubscribe from this group and all its topics, send an email to ansible-deve...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.
--

WILL REFVEM

SOLUTION ARCHITECT (APP DEV)

Red Hat NA Commercial (Southeast/West)

100 E Davie St

Raleigh, NC 27601

wre...@redhat.com    M: 9194389532    

Antonio Insuasti Recalde

unread,
Jul 7, 2017, 6:18:28 PM7/7/17
to Ansible Development, gr...@ansible.com, junior...@gmail.com, tcr...@redhat.com
Hi all

Let me know if you need some help, I'm working on my own module, but i like the idea to work together 

Jairo Junior

unread,
Jul 7, 2017, 7:51:21 PM7/7/17
to Antonio Insuasti Recalde, Ansible Development, gr...@ansible.com, tcr...@redhat.com
Count me in.

I used JBoss name because of existing modules and I believe JBoss brand is more popular than Wildfly. More popular means more users, so more contributors, feedback and etc... (:

One important thing to notice is that Wildfly is known as the upstream project of JBoss EAP, but other projects that use JBoss' Architecture and even carry JBoss name in their productized version such as Keycloak (Red Hat SSO), Infinispan (JDG), Teiid (JDV) and apiman can also be managed through Management API or JBoss-CLI. You just can't deploy applications to them.

So, they're not Wildfly (Infinispan, Teiid, apiman) but "are JBoss", and in special cases they're neither (Keycloak).


Will Refvem

unread,
Jul 8, 2017, 11:23:21 PM7/8/17
to Jairo Junior, Antonio Insuasti Recalde, Ansible Development, gr...@ansible.com, tcr...@redhat.com

That's a really good point. Let's call the working gorup JBoss, and we can figure out module naming later.


--
You received this message because you are subscribed to a topic in the Google Groups "Ansible Development" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/ansible-devel/nttHHu0nMxI/unsubscribe.
To unsubscribe from this group and all its topics, send an email to ansible-deve...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

wre...@redhat.com

unread,
Jul 10, 2017, 11:01:07 AM7/10/17
to Ansible Development, gr...@ansible.com
All--

I've created a creation request for the JBoss WG. Once we have the IRC channel, we should do an initial planning meeting via IRC, so let's start thinking about when would be a good time for that. For starters, we should figure out which time zone everyone is in. I'm US/Eastern (UTC-4:00).


On Saturday, July 8, 2017 at 11:23:21 PM UTC-4, Will Refvem wrote:

That's a really good point. Let's call the working gorup JBoss, and we can figure out module naming later.


On Fri, Jul 7, 2017, 7:51 PM Jairo Junior <junior...@gmail.com> wrote:
Count me in.

I used JBoss name because of existing modules and I believe JBoss brand is more popular than Wildfly. More popular means more users, so more contributors, feedback and etc... (:

One important thing to notice is that Wildfly is known as the upstream project of JBoss EAP, but other projects that use JBoss' Architecture and even carry JBoss name in their productized version such as Keycloak (Red Hat SSO), Infinispan (JDG), Teiid (JDV) and apiman can also be managed through Management API or JBoss-CLI. You just can't deploy applications to them.

So, they're not Wildfly (Infinispan, Teiid, apiman) but "are JBoss", and in special cases they're neither (Keycloak).



On Fri, Jul 7, 2017 at 7:18 PM Antonio Insuasti Recalde <ant...@insuasti.ec> wrote:
Hi all

Let me know if you need some help, I'm working on my own module, but i like the idea to work together 

--
You received this message because you are subscribed to a topic in the Google Groups "Ansible Development" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/ansible-devel/nttHHu0nMxI/unsubscribe.
To unsubscribe from this group and all its topics, send an email to ansible-devel+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

Antonio Insuasti Recalde

unread,
Jul 10, 2017, 8:45:04 PM7/10/17
to Will Refvem, Ansible Development, gr...@ansible.com
Hi all

I'm  ECT (UTC-5:00)



Antonio Insuasti R.

IBM “Linux System Administrator” #ECUSFQ00228
RHCE No: 130-065-634
dCAP. #2071
ECE. #200571804 – #200576560
identi.ca/twiiter: @wolfantec
Quito-Ecuador-
------------------------------------------------------
Si desea enviarme correos Cifrados puede usar mi llave publica
GPG: 0x021C83744ACDF6F0
https://pgp.mit.edu/pks/lookup?op=get&search=0x021C83744ACDF6F0

Greg DeKoenigsberg

unread,
Jul 11, 2017, 11:38:58 AM7/11/17
to wre...@redhat.com, Ansible Development
I'll be processing this one today. 

wre...@redhat.com

unread,
Jul 11, 2017, 3:25:02 PM7/11/17
to Ansible Development, wre...@redhat.com
Thanks Greg.


On Tuesday, July 11, 2017 at 11:38:58 AM UTC-4, Greg DeKoenigsberg wrote:
I'll be processing this one today. 
On Mon, Jul 10, 2017 at 11:01 AM, <wre...@redhat.com> wrote:
All--

I've created a creation request for the JBoss WG. Once we have the IRC channel, we should do an initial planning meeting via IRC, so let's start thinking about when would be a good time for that. For starters, we should figure out which time zone everyone is in. I'm US/Eastern (UTC-4:00).


On Saturday, July 8, 2017 at 11:23:21 PM UTC-4, Will Refvem wrote:

That's a really good point. Let's call the working gorup JBoss, and we can figure out module naming later.


On Fri, Jul 7, 2017, 7:51 PM Jairo Junior <junior...@gmail.com> wrote:
Count me in.

I used JBoss name because of existing modules and I believe JBoss brand is more popular than Wildfly. More popular means more users, so more contributors, feedback and etc... (:

One important thing to notice is that Wildfly is known as the upstream project of JBoss EAP, but other projects that use JBoss' Architecture and even carry JBoss name in their productized version such as Keycloak (Red Hat SSO), Infinispan (JDG), Teiid (JDV) and apiman can also be managed through Management API or JBoss-CLI. You just can't deploy applications to them.

So, they're not Wildfly (Infinispan, Teiid, apiman) but "are JBoss", and in special cases they're neither (Keycloak).



On Fri, Jul 7, 2017 at 7:18 PM Antonio Insuasti Recalde <ant...@insuasti.ec> wrote:
Hi all

Let me know if you need some help, I'm working on my own module, but i like the idea to work together 

--
You received this message because you are subscribed to a topic in the Google Groups "Ansible Development" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/ansible-devel/nttHHu0nMxI/unsubscribe.
To unsubscribe from this group and all its topics, send an email to ansible-deve...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.
--

WILL REFVEM

SOLUTION ARCHITECT (APP DEV)

Red Hat NA Commercial (Southeast/West)

100 E Davie St

Raleigh, NC 27601

wre...@redhat.com    M: 9194389532    

wre...@redhat.com

unread,
Jul 12, 2017, 3:48:44 PM7/12/17
to Ansible Development
Greg--

Again, thanks for suggesting and facilitating the creation of this group. Can you provide any guidance on where to go from here, besides what's already covered in the docs? Specifically, is there a process we can follow to get PR's reviewed and ultimately merged? 

Greg DeKoenigsberg

unread,
Jul 12, 2017, 4:26:23 PM7/12/17
to wre...@redhat.com, Ansible Development
On Wed, Jul 12, 2017 at 3:48 PM, <wre...@redhat.com> wrote:
Greg--

Again, thanks for suggesting and facilitating the creation of this group. Can you provide any guidance on where to go from here, besides what's already covered in the docs? Specifically, is there a process we can follow to get PR's reviewed and ultimately merged? 

In general, the process for getting module PRs reviewed and merged is ultimately the same -- get the PR Bot to give you the thumbs up on all tests, and get the maintainer of the module to agree that the PR is worth merging.

The tricky thing can be getting everyone on the same page on those things in a timely manner. The async nature of distributed development can be a significant hindrance.  

IMO, that's where Working Groups are valuable: they provide structure for a group of people who are dedicated to solving these problems, in the same place at the same time, to shorten the feedback loops.

So I would say:
* make sure the owners of the various JBoss modules are in your working group;
* make sure to set up regular IRC meetings when they can all be present to review PRs;
* make sure everyone is hanging out in the #ansible-jboss channel so that you have quick/easy access to each other.

The Working Groups really aren't that complicated. They're just a very simple way of encouraging people to work together, with just a little bit of infrastructure/process to help.

Take a look at how the Windows and Testing Working Groups operate. I feel like they're setting the standard right now.

--g
 

--
You received this message because you are subscribed to the Google Groups "Ansible Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ansible-devel+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.



--

Jairo Junior

unread,
Jul 16, 2017, 7:59:56 PM7/16/17
to Ansible Development, wre...@redhat.com
Sorry couldn't answer sooner. Lot of things going on - including joining Red Hat (:

GMT -0300 here
To unsubscribe from this group and stop receiving emails from it, send an email to ansible-deve...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.



--

Will Refvem

unread,
Jul 16, 2017, 10:30:07 PM7/16/17
to Jairo Junior, Ansible Development
Great, well welcome!

How does everyone feel about doing our first meeting an hour before the core team meeting on Tuesday? This would be 3pm for Jairo, 2pm for me, 1pm for Antonio.

Antonio Insuasti Recalde

unread,
Jul 17, 2017, 11:44:53 AM7/17/17
to Will Refvem, Jairo Junior, Ansible Development

It's ok for me... see you all tomorrow #ansible-jboss

--
Antonio Insuasti R.

IBM “Linux System Administrator” #ECUSFQ00228
RHCE No: 130-065-634
dCAP. #2071
ECE. #200571804 – #200576560
identi.ca/twiiter: @wolfantec
Quito-Ecuador-
------------------------------------------------------
Si desea enviarme correos Cifrados puede usar mi llave publica

Jairo Junior

unread,
Jul 17, 2017, 10:13:06 PM7/17/17
to Antonio Insuasti Recalde, Will Refvem, Ansible Development
As I said. Crazy schedule with all the moving, travelling, onboarding and etc.

An async conversation would suit me better right now. So, I promise to read and contribute to whatever you guys discuss regarding JBoss. 

joba...@redhat.com

unread,
Dec 3, 2018, 6:17:29 AM12/3/18
to Ansible Development
Hi,
Looks like there are a few JBoss PRs open that would benefit from a review:


When reviewing if you can detail what you've tested that gives us the confidence to merge the code.

We also have #ansible-jboss on Freendoe


Kind regards,
John "gundalow" Barker
Reply all
Reply to author
Forward
0 new messages