Re: Issue 107 in anomalyjobs: Code Review - Skins as Objects

[anoma...@googlecode.com]

Updates:
Labels: -Milestone-Release6.2 Milestone-Release6.3

Comment #4 on issue 107 by widdis: Code Review - Skins as Objects
http://code.google.com/p/anomalyjobs/issues/detail?id=107

(No comment was entered for this change.)

[anoma...@googlecode.com]

Updates:
Labels: -Milestone-Release6.3 Milestone-Release6.4

Comment #5 on issue 107 by widdis: Code Review - Skins as Objects

[anoma...@googlecode.com]

Updates:
Labels: -Milestone-Release6.4 Milestone-Release6.5

Comment #6 on issue 107 by widdis: Code Review - Skins as Objects

[anoma...@googlecode.com]

Updates:
Labels: -Milestone-Release6.5 Milestone-Release7.0

Comment #7 on issue 107 by wid...@gmail.com: Code Review - Skins as Objects

[anoma...@googlecode.com]

Updates:
Status: Accepted

Comment #8 on issue 107 by Fleety...@gmail.com: Code Review - Skins as
Objects
http://code.google.com/p/anomalyjobs/issues/detail?id=107

I was finally able to take a look at this, however with the caveat that it
was on a 6.4 install.

I had to set VA on the DEFAULT skin object in order for it to work. I had
to wipe the DEFAULT_ and WHITEBG_ skins that exist on the Func Object (VA)
too.

I would suggest the following changes:

A new command (+jobs/colors, perhaps) that lists COLOR_<X> and its default
skin definition, beside what the user's value is (or the default). That is
preferable over setting the skin object visual.

I'd like to include the CHROME skin in the default install, and redo the
LCARS skin to be compatible with the new system, as well (but as a plug-in).

Security appears good.

I don't think documentation or usability is a challenge in this case; it
seems just as straight-forward as the old system was (if that is possible).

I like the fact that any previously-stored skins are retained for backward
compatibility.

I'm all for the inclusion of this change.