Packaging the tool

1 view
Skip to first unread message

Amanpreet Singh

unread,
Aug 7, 2014, 2:07:46 PM8/7/14
to annotation-tool-gsoc
Dear all,
I am in the phase of packaging the plugin and soon it will over and thus Web Annotator will be available to all as a bookmarklet that they can run anywhere on any website. I would like to thanks all for there consistent support.

I am facing some problem with packaging which I would like to discuss with Simone and Chrisitian within 4 days if I am not able to fix it. One issue is also to where to host this bookmarklet.

As I had said while applying for working on this project, I will continue to maintain and develop Web Annotator further, if you further give me your consistent support.

Thanks for all the trust and faith you all put in me. 

--
Amanpreet Singh,

Amanpreet Singh

unread,
Aug 7, 2014, 2:30:07 PM8/7/14
to annotation-tool-gsoc
The problem is I am trying to package the plugin but it just packages the old one instead of packaging the new one with my changes. Also bookmarklet_build.sh seems like it is broken.

Simone Fonda

unread,
Aug 12, 2014, 3:49:41 AM8/12/14
to Amanpreet Singh, annotation-tool-gsoc
On Thu, Aug 7, 2014 at 8:30 PM, Amanpreet Singh
<amanpreet...@gmail.com> wrote:

> The problem is I am trying to package the plugin but it just packages the
> old one instead of packaging the new one with my changes. Also
> bookmarklet_build.sh seems like it is broken.

What do you mean by "it packages the old one instead"? I dont know
_exactly_ what you're doing (or trying to do!) but you should launch
the bookmarklet_build.sh in the repo where your changes are, so that
your code gets compiled.

Why do you think the script is broken? What error do you get? Did you
installed the dojo SDK and patched them?


About hosting the bookmarklet: the best place would be some wikidata
server imho, but github would also work just fine. Check this out
https://pages.github.com/ .

Simone

Amanpreet Singh

unread,
Aug 12, 2014, 12:01:39 PM8/12/14
to Simone Fonda, annotation-tool-gsoc
Hi What I mean to say it the packaging doesn't include the changes I have made to Pundit and thus show the old Pundit like it was before my changes, I need to know how can I incorporate my changes too to the package. For e.g. Push To wikidata button doesn't appear.

i fixed the script as far as possible.

Christian Morbidoni

unread,
Aug 12, 2014, 12:51:17 PM8/12/14
to Amanpreet Singh, Simone Fonda, annotation-tool-gsoc
That sounds really strange. If you run the bookmarklet build script from you local repository, where you made changes, this will be included. 
Are you sure you properly set all the URLs in the bookmarket package files? I do not remember the details but there is a file that contains a link to the actual bookmarklet...


--
You received this message because you are subscribed to the Google Groups "Annotation tool GSoC" group.
To unsubscribe from this group and stop receiving emails from it, send an email to annotation-tool-...@googlegroups.com.
Visit this group at http://groups.google.com/group/annotation-tool-gsoc.
For more options, visit https://groups.google.com/d/optout.

Amanpreet Singh

unread,
Aug 12, 2014, 12:55:36 PM8/12/14
to Christian Morbidoni, Simone Fonda, annotation-tool-gsoc
You can check the code I used to package as I have created a different repo for the purpose https://github.com/apsdehal/WAFBookmarklet/
Here is the build_bookmarkelet.sh https://github.com/apsdehal/WAFBookmarklet/blob/master/bookmarklet_build/build_bookmarklet.sh
Check if you see any error.

Simone Fonda

unread,
Aug 13, 2014, 4:08:28 AM8/13/14
to Amanpreet Singh, annotation-tool-gsoc
On Tue, Aug 12, 2014 at 6:01 PM, Amanpreet Singh
<amanpreet...@gmail.com> wrote:

> Hi What I mean to say it the packaging doesn't include the changes I have
> made to Pundit and thus show the old Pundit like it was before my changes, I
> need to know how can I incorporate my changes too to the package. For e.g.
> Push To wikidata button doesn't appear.

Oh, i might have a weird idea.

Open the browser dev console and check what bookmarklet and from where
you are getting it. Are you sure you are loading *YOUR* bm and not one
of our deployed ones?


You specified https://rawgit.com/apsdehal/WAFBookmarklet/master as
your bookmarklet path, but if i try to load
https://rawgit.com/apsdehal/WAFBookmarklet/master/InitBookmarklet.js i
get a 404.

Simone

Christian Morbidoni

unread,
Aug 18, 2014, 4:01:15 AM8/18/14
to fo...@netseven.it, Amanpreet Singh, annotation-tool-gsoc
Hi Aman, did you solve the bookmaklet issue?

.

Amanpreet Singh

unread,
Aug 18, 2014, 4:11:28 AM8/18/14
to Christian Morbidoni, fo...@netseven.it, annotation-tool-gsoc
Hi,
Yes , thanks to Simone, it has been solved.
Bookmarklet is available at http://apsdehal.in/WAFBookmarklet/bookmarklet/bookmarklet.html, and its currently being loaded via Github CDN.
I am soon going to write a project wrap up report and add it to project's Wikimedia Page, then further continue work on it.

Christian Morbidoni

unread,
Aug 18, 2014, 4:52:42 AM8/18/14
to Amanpreet Singh, fo...@netseven.it, annotation-tool-gsoc
Hi Aman,

I see the bookmarklet is working now.
I created some annotations and here is some feedback:
I annotated the following page:
You should be able to see my annotation if you go there and load the bookmaklet.. I did it by selecting the a text fragment (the first paragraph) and then following your workflow (remove the text fragment from subject and crete triples searching in wikidata). 
One thing is: if I do not include the statement where the fragment I a subject, then Pundit is not able to position the annotation...you see my annotation is shown at the very top in the annotation side bar.
An other thing is: when I click on push to wikidata before saving the annotation in Pundit, I get redirected to this page: http://tools.wmflabs.org/bajo/?9f940a5f. Here I do not understand what happens...it seems my annotation was not received?
finally, sorry for repeating this again, but I think we should have a way to push to wikidata one existing annotation, after I saved it in Pundit...

best,

Christian

Amanpreet Singh

unread,
Aug 18, 2014, 5:06:56 AM8/18/14
to Christian Morbidoni, fo...@netseven.it, annotation-tool-gsoc
One thing is: if I do not include the statement where the fragment I a subject, then Pundit is not able to position the annotation...you see my annotation is shown at the very top in the annotation side bar.

Do you see any solution to Christian, I am not sure, how would I fix this.

An other thing is: when I click on push to wikidata before saving the annotation in Pundit, I get redirected to this page: http://tools.wmflabs.org/bajo/?9f940a5f. Here I do not understand what happens...it seems my annotation was not received?

Are you sure your notebook is public, 
http://tools.wmflabs.org/bajo/?8dcf39e0, Check this for my notebooks annotations, works fine for me.

finally, sorry for repeating this again, but I think we should have a way to push to wikidata one existing annotation, after I saved it in Pundit...

I didn't get you exactly here, We can push the whole notebook, is this bad? What possible solution do you want?
Reply all
Reply to author
Forward
0 new messages