Latest work...

[Jon Frisby]

Folks,

I've attempted to reconcile my branch a bit more with Alex's branch... I think there may still be some differences of opinion to resolve, but setting those aside for a moment, here are the things I think are notable that you guys may be interested in:

1) Adding .bundle directory to .gitignore. This may in fact be the source of the problems with Rails 2.3 / 3.2 hiccups when doing integration tests.

2) Minor fix for gemspec -- it was referring to VERSION.yml and didn't have todo.txt.

3) More consistency about what can be explicitly configured wrt position, and what can be configured wrt exclusion.

4) Hoist option coalescing into one place.

5) I have some order-of-operations / structural changes that are needed to avoid some nasty infinite-recursion type things at least in Rails 3 -- if we want the CLI tool to default to using your configuration (specified in a .rake file).

I'm thinking of hoisting all the logic from the shell script into a module, and then simply making dual binaries. That way we can handle the name clash without having to have two separate gems. Thoughts?

-JF

[Cuong Q. Tran]

Thanks for helping out Jon. What you suggest seem reasonable.

How are you guys coordinating the changes back into the main repo? I
have some time this weekend so let me know what I can do.

> --
> You received this message because you are subscribed to the Google Groups "annotate-models" group.
> To post to this group, send email to annotat...@googlegroups.com.
> To unsubscribe from this group, send email to annotate-mode...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/annotate-models?hl=en.
>

[Alex Chaffee]

Those all sound good. I'll do a proper review when I merge (hopefully
by this Sunday).

- A

On Wed, Mar 28, 2012 at 2:28 PM, Jon Frisby <jfr...@mrjoy.com> wrote:

> --
> You received this message because you are subscribed to the Google Groups "annotate-models" group.
> To post to this group, send email to annotat...@googlegroups.com.
> To unsubscribe from this group, send email to annotate-mode...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/annotate-models?hl=en.
>

--
Alex Chaffee - al...@stinky.com
http://alexchaffee.com
http://twitter.com/alexch

[Alex Chaffee]

On Wed, Mar 28, 2012 at 2:28 PM, Jon Frisby <jfr...@mrjoy.com> wrote:

> I'm thinking of hoisting all the logic from the shell script into a module, and then simply making dual binaries.  That way we can handle the name clash without having to have two separate gems.  Thoughts?

That sounds great, except that I think we also want two separate gems :-)

(It's not a big deal to have 2 gemspecs and load one from the other
for DRY purposes, e.g.
https://github.com/alexch/wrong/blob/master/wrong-java.gemspec )

- A