Directive controller constructor being called twice?

[ItsLeeOwen]

http://jsfiddle.net/ItsLeeOwen/AsD7E/

If I set the directive's controller with an ng-controller tag, it's only called once as expected.  By setting the controller in the directive it is called twice.  Is this a bug, or am I doing something wrong?

thanks

[Dan Doyon]

You probably shdnt be referencing controller on outside of directive

Sent from my iPhone

--
You received this message because you are subscribed to the Google Groups "AngularJS" group.
To view this discussion on the web visit https://groups.google.com/d/msg/angular/-/LY0QupX7pecJ.
To post to this group, send email to ang...@googlegroups.com.
To unsubscribe from this group, send email to angular+u...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/angular?hl=en.

[ItsLeeOwen]

It doesn't make a difference whether I use a controller static variable, or a global variable to count the number of times the constructors are called.

[Dan Doyon]

Could be the first factory construction, try adding another widget

Sent from my iPhone

On Apr 30, 2012, at 3:00 PM, ItsLeeOwen <l...@coderebelbase.com> wrote:

It doesn't make a difference whether I use a controller static variable, or a global variable to count the number of times the constructors are called.

--
You received this message because you are subscribed to the Google Groups "AngularJS" group.

To view this discussion on the web visit https://groups.google.com/d/msg/angular/-/Co8ijJCWIAkJ.

[ItsLeeOwen]

What do you mean by first factory construction?

[Dan Doyon]

Sorry, i wasn't at my computer when i sent response. I took a look at your code more closely this morning. one of the things that threw me was the same name of the controller and directives. 

It appears that having controller: MyElement1 reference inside directives is causing the controller factory to run twice on that controller. Seems like a bug to me.

--dan

---

From: ItsLeeOwen <l...@coderebelbase.com>
To: ang...@googlegroups.com
Sent: Monday, April 30, 2012 8:58 PM
Subject: Re: [angular.js] Directive controller constructor being called twice?

What do you mean by first factory construction?

--
You received this message because you are subscribed to the Google Groups "AngularJS" group.

To view this discussion on the web visit https://groups.google.com/d/msg/angular/-/EcvdX0p6sz8J.

[ItsLeeOwen]

Based on the docs, it looks to me like both are valid controller assignment of an element directive.  MyElement1 firing the constructor twice was found to be the source of issues in an app under-development.

http://docs.angularjs.org/api/angular.module.ng.$compileProvider.directive

[Ali Mills]

I haven't dug deep, but it looks like a bug to me. Interestingly, if
you inline the template in your example instead of using templateUrl,
your constructor is only called once. Check it out:
http://jsfiddle.net/alimills/AsD7E/6/

Ali

> --
> You received this message because you are subscribed to the Google Groups
> "AngularJS" group.
> To view this discussion on the web visit

> https://groups.google.com/d/msg/angular/-/bRxHV8r94uwJ.

[Ali Mills]

And, yet another workaround is to simply swap the 'controller'
attribute with 'link': http://jsfiddle.net/alimills/M8wBa/

Ali

[Ali Mills]

Um... That workaround will only work if your directive only expects to have the three link services scope, attrs, and element injected.

Ali

[ItsLeeOwen]

If this is a bug, it seems fairly major since putting the controller into the template tag will not allow you to use a scope hashtag in the directive without the isolated-scope collision error.  I will try putting the template as an inline string.

multiple directives asking for isolated scope on:

[Igor Minar]

it was a bug and I've just fixed it:

https://github.com/angular/angular.js/pull/931

[ItsLeeOwen]

Thank you Igor, much appreciated!

https://github.com/angular/angular.js/pull/931