My 1.0.8 to 1.2.2 upgrade adventure...

102 views
Skip to first unread message

Eric Jain

unread,
Nov 25, 2013, 2:05:45 AM11/25/13
to ang...@googlegroups.com
Looking at http://docs.angularjs.org/guide/migration, I found only two changes that would affect my code (or so I thought):

  1. ngRoute is now a separate module.

  2. `$location.search()['q']` can now be an array (good news!).


It turned out there were 3 more changes I had to do:

  1. Add target="_self" to Bootstrap tabs to prevent AngularJS from hijacking them.

  2. Replace data-ng-class="form.label.$valid || 'error'" with data-ng-class="!form.label.$valid && 'error'", to avoid the following error:

    TypeError: Object #<error> has no method 'split'
      at ic (http://localhost:9000/js/angular-custom-1.2.2.min.js:61:217)
      at Object.Db.$updateClass (http://localhost:9000/js/angular-custom-1.2.2.min.js:59:330)
      at Object.h [as fn] (http://localhost:9000/js/angular-custom-1.2.2.min.js:126:142)
      at g.$digest (http://localhost:9000/js/angular-custom-1.2.2.min.js:99:141)
      at g.$apply (http://localhost:9000/js/angular-custom-1.2.2.min.js:101:369)
      at HTMLAnchorElement.<anonymous> (http://localhost:9000/js/angular-custom-1.2.2.min.js:177:149)
      at HTMLAnchorElement.x.event.dispatch (http://localhost:9000/js/jquery-1.10.2.min.js:5:14129)
      at HTMLAnchorElement.v.handle (http://localhost:9000/js/jquery-1.10.2.min.js:5:10866)
   
  3. Add a '?' to make certain route parameters optional again, e.g. `$routeProvider..when('/foo/:bar?', { ... })`


Hope this will be useful to someone...

Reply all
Reply to author
Forward
0 new messages