[AngularJS] Key-up / key-down directives - RFC

[Pawel Kozlowski]

Hi!

So, here is this long-opened
https://github.com/angular/angular.js/issues/1035 and a fresh PR:
https://github.com/angular/angular.js/pull/1622 (thnx Mark!)

I wonder what is your opinion on this, functionally speaking?

Would simply reacting to a key event and figuring out keys pressed
from the $event would be enough for you?
Or maybe you would like to specify key codes as a directive attribute?
Or maybe you don't care at all as a directive is easy to write and is
not needed in core?

WDYT?

Cheers,
Pawel

--
Question? Send a fiddle
(http://jsfiddle.net/pkozlowski_opensource/Q2NpJ/) or a plunk
(http://plnkr.co/)
Need help with jsFiddle? Check this:
http://pkozlowskios.wordpress.com/2012/08/12/using-jsfiddle-with-angularjs/

Looking for UI widget library for AngularJS? Here you go:
http://angular-ui.github.com/

[Michael Bielski]

I would like to see this as a directive that is included in the core. Also, I think I'd like to be able to specify what keycode I am looking for as an optional attribute. If it is present when called, then yes, look for that keycode, otherwise just capture the event as a whole.

[digger69]

IMHO, I wouldn't hold this PR for enhancing for ability to specify keycode since could get sticky if we start considering key modifiers (ctrl, alt, shift).

[digger69]

Today I found that angular-ui project has a Keypress directive

http://angular-ui.github.com/#directives-keypress

It allows both binding just on any keypress - or keycode-specific, including aliasing; e.g. instead of binding to "13" you can bind to "enter".

It seems pretty complete. Not sure what the best go-forward is though. I think this does fit better in the ng namespace.

[ProLoser]

Yeah... our UI implementation is pretty thorough, I would think it would be worthwhile to compare the two before moving forward with merging the PR. I realize ours sort of opens new floodgates (such as people asking for EVERY key to be aliased or having multiple non-modifier keys pressed simultaneously) but having keydown, keyup and keypress alone is fairly critical. You can also have multiple key combinations trigger the same function/callback/code

ui-keypress= { 'shift-enter ctrl-enter alt-enter' : ' goHome() ` }

[Michael Bielski]

Damn... I need to look at the UI more... had no idea that was there!

So, if I read ProLoser's post correctly, a combination like "shift-ctrl-enter" is not currently possible in AngularUI?

[ProLoser]

I never said that. That combination is supported, just go try it out!

[Michael Bielski]

Ok, so I was incorrect in my interpretation. Obviously my caffination level is off. I'll certainly check it out! Thanks!