How to implement While loop inside RXJS subscription in my angular code

[rj]

I have an Angular code where in i am trying to subscribe to my 1st api and implementing a while loop inside this subscription. Further i need to subscribe to another api inside the while loop. Reason --> I need to subscribe to the inner api multiple times and the while loop should end based on a flag returned by inner api. I tried implementing the below but its not working. Need some help.

```

CallBanyanToFetchQuotes() {

    const url1 = 'http://ws.integration.banyantechnology.com/services/api/rest/ImportForQuote';

    this.http.post(url1, payload)

      .subscribe(importForQuoteResponse => {

        this.importForQuoteResponse = importForQuoteResponse;

        console.log('LoadID = ' + this.importForQuoteResponse.Load.Loadinfo.LoadID);

        this.loadId = this.importForQuoteResponse.Load.Loadinfo.LoadID;

        while (!this.ratingCompleted) {

          const url2 = 'http://ws.integration.banyantechnology.com/services/api/rest/GetQuotes';

          this.http.post(url2, payload)

            .subscribe(getQuoteResponse => {

              this.getQuoteResponse = getQuoteResponse;

              if (this.getQuoteResponse.RatingCompleted === true) {

                this.ratingCompleted = true;

              }

            });

        }

      });

  }

```

[Sander Elias]

Hi Rj,

I don't have the time right now to rewrite your code. However, subscribing inside a subscribe is a big antipattern and should be avoided.

What you need is to make it a rxjs flow that uses composition.

the following is just a idea, not working code:

function demo() {

const url1 = '';

const payload = '';

const url2 = 'http://ws.integration.banyantechnology.com/services/api/rest/GetQuotes';

const getQuote = () =>

this.http.post(url2, payload).pipe(

tap(getQuoteResponse => {

this.getQuoteResponse = getQuoteResponse;

if (this.getQuoteResponse.RatingCompleted === true) {

this.ratingCompleted = true;

}

})

);

const sub = this.http

.post(url1, payload)

.pipe(

tap(importForQuoteResponse => {

this.importForQuoteResponse = importForQuoteResponse;

this.loadId = this.importForQuoteResponse.Load.Loadinfo.LoadID;

}),

expand(() => (this.this.ratingCompleted ? empty() : getQuote()))

)

.subscribe();

}

Note, `tap` descibes a side-effect, you should limit those to a minimum to create maintainable code