Issue 8592 in angleproject: :TIntermConstantUnion::FoldBinary with void variables

[kkinn… via monorail]

Status: Available
Owner: ----
Components: Translator
OS: All
Priority: Medium
Type: Defect

New issue 8592 by kkinn...@apple.com: :TIntermConstantUnion::FoldBinary with void variables
https://bugs.chromium.org/p/angleproject/issues/detail?id=8592

TEST_F(ParseTest, StructWithVoidAndDivNoCrash)
{
const char kShader[] = R"(
const struct s { void i; } ss = s();
vec3 q=ss.i/ss.i)";
EXPECT_FALSE(compile(kShader));
EXPECT_TRUE(foundErrorInIntermediateTree());
EXPECT_TRUE(foundInIntermediateTree("something"));
}

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[Git Watcher via monorail]

Comment #1 on issue 8592 by Git Watcher: :TIntermConstantUnion::FoldBinary with void variables
https://bugs.chromium.org/p/angleproject/issues/detail?id=8592#c1

The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/ab6dd5b2231217c7e217f680b4cfdb03f6b773f5

commit ab6dd5b2231217c7e217f680b4cfdb03f6b773f5
Author: Nisha Jain <nisha_jain@apple.com>
Date: Thu Mar 07 12:19:58 2024

Avoid asserts when const folding binary ops on void variables

Fix asserts for example with / and % during constant folding when
the operands might be voids.

Bug: angleproject:8592
Change-Id: I22275642dbcdf9066940d3a94114e8daa5cbbe41
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5416376
Auto-Submit: Kimmo Kinnunen <kkin...@apple.com>
Commit-Queue: Geoff Lang <geof...@chromium.org>
Reviewed-by: Geoff Lang <geof...@chromium.org>
Reviewed-by: Kimmo Kinnunen <kkin...@apple.com>

[modify] https://crrev.com/ab6dd5b2231217c7e217f680b4cfdb03f6b773f5/src/compiler/translator/ParseContext.cpp
[modify] https://crrev.com/ab6dd5b2231217c7e217f680b4cfdb03f6b773f5/src/tests/compiler_tests/Parse_test.cpp

[kkinn… via monorail]

Updates:
Status: Verified

Comment #2 on issue 8592 by kkinn...@apple.com: :TIntermConstantUnion::FoldBinary with void variables
https://bugs.chromium.org/p/angleproject/issues/detail?id=8592#c2

(No comment was entered for this change.)