Issue 8689 in angleproject: vulkan-deps rolls fail due to errors on Linux/Intel bot

[abdol… via monorail]

Status: Available
Owner: ----
Labels: Hotlist-Wrangler
Priority: Medium
Type: Defect

New issue 8689 by abdolr...@google.com: vulkan-deps rolls fail due to errors on Linux/Intel bot
https://bugs.chromium.org/p/angleproject/issues/detail?id=8689

The most recent roll fails due to failures on the Linux/Intel bot: https://chromium-review.googlesource.com/c/angle/angle/+/5519982

It seems that these errors have existed from much earlier updates: https://chromium-review.googlesource.com/c/angle/angle/+/5523979

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[abdol… via monorail]

Comment #1 on issue 8689 by abdolr...@google.com: vulkan-deps rolls fail due to errors on Linux/Intel bot
https://bugs.chromium.org/p/angleproject/issues/detail?id=8689#c1

First failing roll: https://chromium-review.googlesource.com/c/angle/angle/+/5524100

[abdol… via monorail]

Comment #2 on issue 8689 by abdolr...@google.com: vulkan-deps rolls fail due to errors on Linux/Intel bot
https://bugs.chromium.org/p/angleproject/issues/detail?id=8689#c2

Sample error backtrace:
```
ContextLostTest.ExtensionStringExposed/ES2_Vulkan
angle::PrintStackBacktrace() at crash_handler_posix.cpp:498
angle::Handler(int) at crash_handler_posix.cpp:659
killpg at ??:?
explicit_bzero at strcmp-sse2-unaligned.S:31
unload_drivers_without_physical_devices at loader.c:6489
vkEnumeratePhysicalDevices at trampoline.c:?
rx::vk::Renderer::initialize(rx::vk::Context*, rx::vk::GlobalOps*, angle::vk::ICD, unsigned int, unsigned int, rx::vk::UseValidationLayers, char const*, char const*, angle::NativeWindowSystem, angle::FeatureOverrides const&) at vk_renderer.cpp:1956
rx::DisplayVk::initialize(egl::Display*) at DisplayVk.cpp:177
rx::DisplayVkXcb::initialize(egl::Display*) at DisplayVkXcb.cpp:65
isError at Error.inc:82
isError at Error.inc:82
EGL_Initialize at ??:?
EGLWindow::initializeDisplay(OSWindow*, angle::Library*, angle::GLESDriverType, EGLPlatformParameters const&) at EGLWindow.cpp:301
ANGLETestBase::ANGLETestSetUp() at ANGLETest.cpp:723
SetUp at ANGLETest.h:645
testing::Test::Run() at gtest.cc:2704
testing::TestInfo::Run() at gtest.cc:2888
testing::TestSuite::Run() at gtest.cc:3040
testing::internal::UnitTestImpl::RunAllTests() at gtest.cc:5898
testing::UnitTest::Run() at gtest.cc:5464
RUN_ALL_TESTS at gtest.h:2492
main at angle_end2end_tests_main.cpp:75
__libc_start_main at libc-start.c:344
_start at ??:?
```

[abdol… via monorail]

Updates:
Cc: ynovi...@chromium.org

Comment #3 on issue 8689 by abdolr...@google.com: vulkan-deps rolls fail due to errors on Linux/Intel bot
https://bugs.chromium.org/p/angleproject/issues/detail?id=8689#c3

The function `unload_drivers_without_physical_devices()` is added to `vkEnumeratePhysicalDevices()` in the following change: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+/a8710bb7fed086159ec0b7c4ae5e62744fe9c60c

[ynovi… via monorail]

Comment #4 on issue 8689 by ynovi...@chromium.org: vulkan-deps rolls fail due to errors on Linux/Intel bot
https://bugs.chromium.org/p/angleproject/issues/detail?id=8689#c4

I commented on https://github.com/KhronosGroup/Vulkan-Loader/pull/1471#issuecomment-2100703945

[abdol… via monorail]

Comment #5 on issue 8689 by abdolr...@google.com: vulkan-deps rolls fail due to errors on Linux/Intel bot
https://bugs.chromium.org/p/angleproject/issues/detail?id=8689#c5

Thanks Yuly!

[abdol… via monorail]

Updates:
Status: Fixed

Comment #6 on issue 8689 by abdolr...@google.com: vulkan-deps rolls fail due to errors on Linux/Intel bot
https://bugs.chromium.org/p/angleproject/issues/detail?id=8689#c6

The fix has been submitted: https://github.com/KhronosGroup/Vulkan-Loader/pull/1484
It seems that it was related to undefined behavior of strcmp() with respect to null inputs.

The latest roll (containing this fix as its last update) no longer fails on the Linux bot: https://chromium-review.googlesource.com/c/angle/angle/+/5525919