Issue 8653 in angleproject: WebGPU: Basic ReadPixels support

[geoff… via monorail]

Status: Available
Owner: l...@chromium.org
Priority: Medium
Renderer: WebGPU
Type: Defect

New issue 8653 by geoff...@chromium.org: WebGPU: Basic ReadPixels support
https://bugs.chromium.org/p/angleproject/issues/detail?id=8653

Add support for glReadPixels on RGBA8 framebuffers.

* Use the bounds clipping logic from other ANGLE backends.
* Copy the framebuffer region to a Buffer. Map the buffer and unpack the data.

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[Git Watcher via monorail]

Comment #1 on issue 8653 by Git Watcher: WebGPU: Basic ReadPixels support
https://bugs.chromium.org/p/angleproject/issues/detail?id=8653#c1

The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/36cd4c1f076df866fdabf1796c81b6840f8c204f

commit 36cd4c1f076df866fdabf1796c81b6840f8c204f
Author: Liza Burakova <li...@chromium.org>
Date: Wed May 08 16:27:22 2024

Adding basic readPixels.

This change adds to methods in ImageHelper to read texture data.
It also implements FramebufferWgpu::readPixels to get the parameters
and read the texture data from an ImageHelper that's stored in
mRenderTargetCache.

Bug: angleproject:8653
Change-Id: I349ed8a0ae3d8d0e187c658f3402c4f8cac23eb8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5441353
Reviewed-by: Geoff Lang <geof...@chromium.org>
Commit-Queue: Liza Burakova <li...@chromium.org>
Reviewed-by: Matthew Denton <mpde...@chromium.org>

[modify] https://crrev.com/36cd4c1f076df866fdabf1796c81b6840f8c204f/src/libANGLE/renderer/renderer_utils.cpp
[modify] https://crrev.com/36cd4c1f076df866fdabf1796c81b6840f8c204f/src/libANGLE/renderer/wgpu/FramebufferWgpu.cpp
[modify] https://crrev.com/36cd4c1f076df866fdabf1796c81b6840f8c204f/src/libANGLE/renderer/wgpu/FramebufferWgpu.h
[modify] https://crrev.com/36cd4c1f076df866fdabf1796c81b6840f8c204f/src/libANGLE/renderer/wgpu/wgpu_helpers.h
[modify] https://crrev.com/36cd4c1f076df866fdabf1796c81b6840f8c204f/src/libANGLE/renderer/renderer_utils.h
[modify] https://crrev.com/36cd4c1f076df866fdabf1796c81b6840f8c204f/src/libANGLE/renderer/wgpu/wgpu_helpers.cpp
[modify] https://crrev.com/36cd4c1f076df866fdabf1796c81b6840f8c204f/src/libANGLE/renderer/vulkan/vk_helpers.cpp
[modify] https://crrev.com/36cd4c1f076df866fdabf1796c81b6840f8c204f/src/tests/angle_end2end_tests_expectations.txt