Issue 6566 in angleproject: Genshin impact rendering issue with SwiftShader - unwritten FB attachments
197 views
Skip to first unread message
jmad… via monorail
Oct 13, 2021, 2:28:45 PM10/13/21
to angleproj...@googlegroups.com
Status: Assigned
Owner: jmad...@chromium.org
Priority: Medium
Renderer: Vulkan
Type: Defect
New issue 6566 by jmad...@chromium.org: Genshin impact rendering issue with SwiftShader - unwritten FB attachments
https://bugs.chromium.org/p/angleproject/issues/detail?id=6566
I was looking at adding trace tests with SwANGLE on ANGLE CI, and ran into some weird rendering artifacts with Genshin Impact. You can see the images at this Skia Gold triage link:
https://angle-gold.skia.org/search?issue=3208646&crs=gerrit&patchsets=6&corpus=angle
In short, I found using RenderDoc that Genshin binds 3 FB outputs and only writes to one in the shader. On some drivers it seems that doesn't end up modifying the FB outputs, but on SwiftShader it seems it overwrites this info with some undefined values.
Looks like we'll need a solve here to ensure defined values if "real" applications depend on this behaviour. We could also check with partners to see if there's special code in their GL drivers here.
--
You received this message because:
1. The project was configured to send all issue notifications to this address
You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings
Owner: jmad...@chromium.org
Priority: Medium
Renderer: Vulkan
Type: Defect
New issue 6566 by jmad...@chromium.org: Genshin impact rendering issue with SwiftShader - unwritten FB attachments
https://bugs.chromium.org/p/angleproject/issues/detail?id=6566
I was looking at adding trace tests with SwANGLE on ANGLE CI, and ran into some weird rendering artifacts with Genshin Impact. You can see the images at this Skia Gold triage link:
https://angle-gold.skia.org/search?issue=3208646&crs=gerrit&patchsets=6&corpus=angle
In short, I found using RenderDoc that Genshin binds 3 FB outputs and only writes to one in the shader. On some drivers it seems that doesn't end up modifying the FB outputs, but on SwiftShader it seems it overwrites this info with some undefined values.
Looks like we'll need a solve here to ensure defined values if "real" applications depend on this behaviour. We could also check with partners to see if there's special code in their GL drivers here.
--
You received this message because:
1. The project was configured to send all issue notifications to this address
You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings
jmad… via monorail
Oct 13, 2021, 2:28:48 PM10/13/21
to angleproj...@googlegroups.com
Updates:
Labels: Priority-High
Comment #1 on issue 6566 by jmad...@chromium.org: Genshin impact rendering issue with SwiftShader - unwritten FB attachments
https://bugs.chromium.org/p/angleproject/issues/detail?id=6566#c1
(No comment was entered for this change.)
Labels: Priority-High
Comment #1 on issue 6566 by jmad...@chromium.org: Genshin impact rendering issue with SwiftShader - unwritten FB attachments
https://bugs.chromium.org/p/angleproject/issues/detail?id=6566#c1
(No comment was entered for this change.)
jmad… via monorail
Oct 13, 2021, 2:30:51 PM10/13/21
to angleproj...@googlegroups.com
Updates:
Cc: cnor...@google.com
Comment #2 on issue 6566 by jmad...@chromium.org: Genshin impact rendering issue with SwiftShader - unwritten FB attachments
https://bugs.chromium.org/p/angleproject/issues/detail?id=6566#c2
Cody FYI .. I doubt it but could be related to issue 6029 as well.
Cc: cnor...@google.com
Comment #2 on issue 6566 by jmad...@chromium.org: Genshin impact rendering issue with SwiftShader - unwritten FB attachments
https://bugs.chromium.org/p/angleproject/issues/detail?id=6566#c2
Cody FYI .. I doubt it but could be related to issue 6029 as well.
jmad… via monorail
Oct 13, 2021, 2:51:42 PM10/13/21
to angleproj...@googlegroups.com
Comment #3 on issue 6566 by jmad...@chromium.org: Genshin impact rendering issue with SwiftShader - unwritten FB attachments
https://bugs.chromium.org/p/angleproject/issues/detail?id=6566#c3
GLES 3.2 spec, 15.2. WHOLE FRAMEBUFFER OPERATIONS, 15.2.1 Selecting Buffers for Writing:
"If a fragment color is undefined after fragment shader execution, or if the value written for a fragment color does not match the format of a draw buffer it is to be written to, the resulting value in the draw buffer is undefined."
jmad… via monorail
Oct 13, 2021, 3:09:43 PM10/13/21
to angleproj...@googlegroups.com
Comment #4 on issue 6566 by jmad...@chromium.org: Genshin impact rendering issue with SwiftShader - unwritten FB attachments
https://bugs.chromium.org/p/angleproject/issues/detail?id=6566#c4
Vulkan 15.1. Shader Input and Output Interfaces states:
"Output variables of a shader stage have undefined values until the shader writes to them or uses the Initializer operand when declaring the variable."
It doesn't clearly state if not declaring these variables makes any difference.
nicol… via monorail
Oct 13, 2021, 4:07:50 PM10/13/21
to angleproj...@googlegroups.com
Comment #5 on issue 6566 by nicol...@google.com: Genshin impact rendering issue with SwiftShader - unwritten FB attachments
https://bugs.chromium.org/p/angleproject/issues/detail?id=6566#c5
Seems closely related to https://issuetracker.google.com/162348737.
Git Watcher via monorail
Oct 14, 2021, 4:25:11 PM10/14/21
to angleproj...@googlegroups.com
Comment #6 on issue 6566 by Git Watcher: Genshin impact rendering issue with SwiftShader - unwritten FB attachments
https://bugs.chromium.org/p/angleproject/issues/detail?id=6566#c6
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/1dc2b7028b4a4f2fd8976ef3bc0fa294df922710
commit 1dc2b7028b4a4f2fd8976ef3bc0fa294df922710
Author: Jamie Madill <jma...@chromium.org>
Date: Wed Oct 13 20:02:37 2021
Vulkan: Pass shader module map to init pipelines.
Instead of pulling out the shader modules from the shader map when
we start the call chain, pull them out right in the init call. This
saves a bunch of boilerplate code.
Refactoring change only.
Bug: angleproject:6566
Change-Id: Ib8d79bd7284d7ddb83522270f3d4df9086ab7300
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3221134
Reviewed-by: Tim Van Patten <ti...@google.com>
Reviewed-by: Shahbaz Youssefi <syou...@chromium.org>
Commit-Queue: Jamie Madill <jma...@chromium.org>
[modify] https://crrev.com/1dc2b7028b4a4f2fd8976ef3bc0fa294df922710/src/libANGLE/renderer/vulkan/vk_cache_utils.h
[modify] https://crrev.com/1dc2b7028b4a4f2fd8976ef3bc0fa294df922710/src/libANGLE/renderer/vulkan/vk_helpers.h
[modify] https://crrev.com/1dc2b7028b4a4f2fd8976ef3bc0fa294df922710/src/libANGLE/renderer/vulkan/vk_utils.h
[modify] https://crrev.com/1dc2b7028b4a4f2fd8976ef3bc0fa294df922710/src/tests/perf_tests/VulkanPipelineCachePerf.cpp
[modify] https://crrev.com/1dc2b7028b4a4f2fd8976ef3bc0fa294df922710/src/libANGLE/renderer/vulkan/vk_cache_utils.cpp
Git Watcher via monorail
Oct 21, 2021, 10:56:05 AM10/21/21
to angleproj...@googlegroups.com
Comment #8 on issue 6566 by Git Watcher: Genshin impact rendering issue with SwiftShader - unwritten FB attachments
https://bugs.chromium.org/p/angleproject/issues/detail?id=6566#c8
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf
commit 7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf
Author: Jamie Madill <jma...@chromium.org>
Date: Fri Oct 15 18:38:03 2021
Add GL_ANGLE_robust_fragment_shader_output.
This extension codifies expected behaviour on Android, where some
applications don't declare shader outputs that are active with the
Framebuffer.
Bug: angleproject:6566
Change-Id: I3538a0aca25b6567e4b11e40d4611f1b240579c7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226724
Commit-Queue: Jamie Madill <jma...@chromium.org>
Reviewed-by: Cody Northrop <cnor...@google.com>
Reviewed-by: Shahbaz Youssefi <syou...@chromium.org>
commit 7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf
Author: Jamie Madill <jma...@chromium.org>
Date: Fri Oct 15 18:38:03 2021
Add GL_ANGLE_robust_fragment_shader_output.
This extension codifies expected behaviour on Android, where some
applications don't declare shader outputs that are active with the
Framebuffer.
Bug: angleproject:6566
Change-Id: I3538a0aca25b6567e4b11e40d4611f1b240579c7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226724
Commit-Queue: Jamie Madill <jma...@chromium.org>
Reviewed-by: Cody Northrop <cnor...@google.com>
Reviewed-by: Shahbaz Youssefi <syou...@chromium.org>
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/src/libANGLE/Context_gles_ext_autogen.h
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/src/tests/angle_end2end_tests.gni
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/doc/ExtensionSupport.md
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/scripts/code_generation_hashes/GL_EGL_entry_points.json
[add] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/src/tests/gl_tests/RobustFragmentShaderOutputTest.cpp
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/scripts/registry_xml.py
[add] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/extensions/ANGLE_robust_fragment_shader_output.txt
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/scripts/code_generation_hashes/GL_EGL_WGL_loader.json
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/scripts/code_generation_hashes/proc_table.json
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/src/libANGLE/gles_extensions_autogen.cpp
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/scripts/code_generation_hashes/Extension_files.json
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/src/libANGLE/gles_extensions_autogen.h
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/scripts/code_generation_hashes/GLenum_value_to_string_map.json
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/src/tests/angle_end2end_tests.gni
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/doc/ExtensionSupport.md
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/scripts/code_generation_hashes/GL_EGL_entry_points.json
[add] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/src/tests/gl_tests/RobustFragmentShaderOutputTest.cpp
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/scripts/registry_xml.py
[add] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/extensions/ANGLE_robust_fragment_shader_output.txt
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/scripts/code_generation_hashes/GL_EGL_WGL_loader.json
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/scripts/code_generation_hashes/proc_table.json
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/src/libANGLE/gles_extensions_autogen.cpp
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/scripts/code_generation_hashes/Extension_files.json
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/src/libANGLE/gles_extensions_autogen.h
[modify] https://crrev.com/7ef9ecf0a6c8546ad3d41eff69f0129f623a35cf/scripts/code_generation_hashes/GLenum_value_to_string_map.json
Git Watcher via monorail
Oct 28, 2021, 12:27:06 PM10/28/21
to angleproj...@googlegroups.com
Comment #9 on issue 6566 by Git Watcher: Genshin impact rendering issue with SwiftShader - unwritten FB attachments
https://bugs.chromium.org/p/angleproject/issues/detail?id=6566#c9
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/3a9f18f135fe82f77cd684d559f73f7030f22525
commit 3a9f18f135fe82f77cd684d559f73f7030f22525
Author: Jamie Madill <jma...@chromium.org>
Date: Mon Oct 18 14:44:38 2021
Refactor program pipeline handling.
In preparation for moving more code from gl::Program to
gl::ProgramExecutable so it can be shared with ProgramPipeline.
Bug: angleproject:6566
Change-Id: Icb7ecccb37ae8e0d7d5fef8968f0dd7ef6fe6150
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226305
commit 3a9f18f135fe82f77cd684d559f73f7030f22525
Author: Jamie Madill <jma...@chromium.org>
Date: Mon Oct 18 14:44:38 2021
Refactor program pipeline handling.
In preparation for moving more code from gl::Program to
gl::ProgramExecutable so it can be shared with ProgramPipeline.
Bug: angleproject:6566
Change-Id: Icb7ecccb37ae8e0d7d5fef8968f0dd7ef6fe6150
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226305
Reviewed-by: Cody Northrop <cnor...@google.com>
Commit-Queue: Jamie Madill <jma...@chromium.org>
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/ProgramLinkedResources.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/renderer/d3d/FramebufferD3D.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/Program.h
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/ProgramExecutable.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/ProgramPipeline.h
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/renderer/vulkan/ProgramExecutableVk.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/ProgramExecutable.h
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/renderer/d3d/d3d11/StateManager11.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/renderer/vulkan/ProgramPipelineVk.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/Context.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/renderer/vulkan/ProgramVk.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/capture/frame_capture_utils.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/renderer/vulkan/ProgramVk.h
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/State.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/renderer/vulkan/FramebufferVk.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/validationES.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/renderer/vulkan/ContextVk.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/renderer/vulkan/ProgramExecutableVk.h
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/Program.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/renderer/vulkan/ProgramPipelineVk.h
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/ProgramPipeline.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/Context.h
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/State.h
Commit-Queue: Jamie Madill <jma...@chromium.org>
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/ProgramLinkedResources.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/renderer/d3d/FramebufferD3D.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/Program.h
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/ProgramExecutable.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/ProgramPipeline.h
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/renderer/vulkan/ProgramExecutableVk.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/ProgramExecutable.h
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/renderer/d3d/d3d11/StateManager11.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/renderer/vulkan/ProgramPipelineVk.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/Context.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/renderer/vulkan/ProgramVk.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/capture/frame_capture_utils.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/renderer/vulkan/ProgramVk.h
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/State.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/renderer/vulkan/FramebufferVk.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/validationES.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/renderer/vulkan/ContextVk.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/renderer/vulkan/ProgramExecutableVk.h
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/Program.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/renderer/vulkan/ProgramPipelineVk.h
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/ProgramPipeline.cpp
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/Context.h
[modify] https://crrev.com/3a9f18f135fe82f77cd684d559f73f7030f22525/src/libANGLE/State.h
Git Watcher via monorail
Oct 29, 2021, 12:43:05 PM10/29/21
to angleproj...@googlegroups.com
Comment #10 on issue 6566 by Git Watcher: Genshin impact rendering issue with SwiftShader - unwritten FB attachments
https://bugs.chromium.org/p/angleproject/issues/detail?id=6566#c10
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/c31855eaf58a1dea14e353d6a326308952beebf9
commit c31855eaf58a1dea14e353d6a326308952beebf9
Author: Jamie Madill <jma...@chromium.org>
Date: Thu Oct 28 17:29:17 2021
translator: Always report gl_FragData array size.
Previously we would report it as size 1 always if the extension
was missing. This was breaking a dEQP. The test may have a bug, but
we need to work around the issue until the upstream test is fixed.
See https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/3259
Bug: angleproject:6566
Change-Id: I5ac654f472f0e227d63804896ecc388081bec5e8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3251586
Reviewed-by: Shahbaz Youssefi <syou...@chromium.org>
Commit-Queue: Jamie Madill <jma...@chromium.org>
[modify] https://crrev.com/c31855eaf58a1dea14e353d6a326308952beebf9/src/tests/compiler_tests/CollectVariables_test.cpp
[modify] https://crrev.com/c31855eaf58a1dea14e353d6a326308952beebf9/src/compiler/translator/CollectVariables.cpp
commit c31855eaf58a1dea14e353d6a326308952beebf9
Author: Jamie Madill <jma...@chromium.org>
Date: Thu Oct 28 17:29:17 2021
translator: Always report gl_FragData array size.
Previously we would report it as size 1 always if the extension
was missing. This was breaking a dEQP. The test may have a bug, but
we need to work around the issue until the upstream test is fixed.
See https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/3259
Bug: angleproject:6566
Change-Id: I5ac654f472f0e227d63804896ecc388081bec5e8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3251586
Reviewed-by: Shahbaz Youssefi <syou...@chromium.org>
Commit-Queue: Jamie Madill <jma...@chromium.org>
[modify] https://crrev.com/c31855eaf58a1dea14e353d6a326308952beebf9/src/tests/compiler_tests/CollectVariables_test.cpp
[modify] https://crrev.com/c31855eaf58a1dea14e353d6a326308952beebf9/src/compiler/translator/CollectVariables.cpp
Git Watcher via monorail
Oct 29, 2021, 4:41:15 PM10/29/21
to angleproj...@googlegroups.com
Comment #11 on issue 6566 by Git Watcher: Genshin impact rendering issue with SwiftShader - unwritten FB attachments
https://bugs.chromium.org/p/angleproject/issues/detail?id=6566#c11
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/4a2446c6b440b45f41294a434b930f9085f57285
commit 4a2446c6b440b45f41294a434b930f9085f57285
Author: Jamie Madill <jma...@chromium.org>
Date: Tue Oct 19 15:55:17 2021
Vulkan: Implement robust shader outputs.
In this CL we change ANGLE to pass the mask of missing shader
outputs down to pipeline creation. We then use the color mask
bits to block SwiftShader writing to unused outputs.
This fixes the undefined behaviour present in Genshin Impact.
Note that the other GLES implementations we tested don't seem
to modify outputs even if they're unused.
It was easier to mask out the color attachments in initialize
rather than set up the pipeline desc to mask out the attachments.
This was because we manipulate the color mask in a fairly complex
way before we initialize the pipeline desc.
Bug: angleproject:6566
Change-Id: Ie659fcd511cd286fa573fd25e3e6a0b9e123ebd6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3232435
Commit-Queue: Shahbaz Youssefi <syou...@chromium.org>
Reviewed-by: Shahbaz Youssefi <syou...@chromium.org>
commit 4a2446c6b440b45f41294a434b930f9085f57285
Author: Jamie Madill <jma...@chromium.org>
Date: Tue Oct 19 15:55:17 2021
Vulkan: Implement robust shader outputs.
In this CL we change ANGLE to pass the mask of missing shader
outputs down to pipeline creation. We then use the color mask
bits to block SwiftShader writing to unused outputs.
This fixes the undefined behaviour present in Genshin Impact.
Note that the other GLES implementations we tested don't seem
to modify outputs even if they're unused.
It was easier to mask out the color attachments in initialize
rather than set up the pipeline desc to mask out the attachments.
This was because we manipulate the color mask in a fairly complex
way before we initialize the pipeline desc.
Bug: angleproject:6566
Change-Id: Ie659fcd511cd286fa573fd25e3e6a0b9e123ebd6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3232435
Commit-Queue: Shahbaz Youssefi <syou...@chromium.org>
Reviewed-by: Shahbaz Youssefi <syou...@chromium.org>
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/Framebuffer.h
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/ProgramExecutable.cpp
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/tests/perf_tests/VulkanPipelineCachePerf.cpp
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/renderer/vulkan/vk_cache_utils.cpp
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/renderer/vulkan/ProgramExecutableVk.cpp
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/queryutils.cpp
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/renderer/vulkan/vk_cache_utils.h
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/include/GLES2/gl2ext_angle.h
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/renderer/vulkan/vk_helpers.h
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/renderer/vulkan/vk_caps_utils.cpp
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/State.cpp
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/renderer/vulkan/UtilsVk.cpp
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/Framebuffer.cpp
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/renderer/vulkan/ProgramExecutableVk.h
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/renderer/vulkan/ContextVk.cpp
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/ProgramExecutable.cpp
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/tests/perf_tests/VulkanPipelineCachePerf.cpp
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/renderer/vulkan/vk_cache_utils.cpp
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/renderer/vulkan/ProgramExecutableVk.cpp
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/queryutils.cpp
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/renderer/vulkan/vk_cache_utils.h
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/include/GLES2/gl2ext_angle.h
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/renderer/vulkan/vk_helpers.h
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/renderer/vulkan/vk_caps_utils.cpp
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/State.cpp
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/renderer/vulkan/UtilsVk.cpp
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/Framebuffer.cpp
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/renderer/vulkan/ProgramExecutableVk.h
[modify] https://crrev.com/4a2446c6b440b45f41294a434b930f9085f57285/src/libANGLE/renderer/vulkan/ContextVk.cpp
jmad… via monorail
Nov 1, 2021, 9:36:14 AM11/1/21
to angleproj...@googlegroups.com
Updates:
Status: Fixed
Comment #12 on issue 6566 by jmad...@chromium.org: Genshin impact rendering issue with SwiftShader - unwritten FB attachments
https://bugs.chromium.org/p/angleproject/issues/detail?id=6566#c12
Status: Fixed
Comment #12 on issue 6566 by jmad...@chromium.org: Genshin impact rendering issue with SwiftShader - unwritten FB attachments
https://bugs.chromium.org/p/angleproject/issues/detail?id=6566#c12
(No comment was entered for this change.)
Git Watcher via monorail
Nov 5, 2021, 4:26:05 PM11/5/21
to angleproj...@googlegroups.com
Comment #13 on issue 6566 by Git Watcher: Genshin impact rendering issue with SwiftShader - unwritten FB attachments
https://bugs.chromium.org/p/angleproject/issues/detail?id=6566#c13
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/4fd4eb5001d2671df1dfee7fc9414674aed52846
commit 4fd4eb5001d2671df1dfee7fc9414674aed52846
Author: Jamie Madill <jma...@chromium.org>
Date: Fri Nov 05 15:14:47 2021
Vulkan: Minor cleanups.
Makes some VkFlags into VkAccessFlags to aid with code search. Also
corrects a few typos.
Bug: angleproject:6566
Change-Id: Ia4d14d38bb6d4e8c4c71fed6038c12edae112be9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3264224
commit 4fd4eb5001d2671df1dfee7fc9414674aed52846
Author: Jamie Madill <jma...@chromium.org>
Date: Fri Nov 05 15:14:47 2021
Vulkan: Minor cleanups.
Makes some VkFlags into VkAccessFlags to aid with code search. Also
corrects a few typos.
Bug: angleproject:6566
Change-Id: Ia4d14d38bb6d4e8c4c71fed6038c12edae112be9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3264224
Commit-Queue: Shahbaz Youssefi <syou...@chromium.org>
Reviewed-by: Shahbaz Youssefi <syou...@chromium.org>
[modify] https://crrev.com/4fd4eb5001d2671df1dfee7fc9414674aed52846/src/libANGLE/renderer/vulkan/vk_helpers.h
[modify] https://crrev.com/4fd4eb5001d2671df1dfee7fc9414674aed52846/src/libANGLE/renderer/vulkan/UtilsVk.cpp
[modify] https://crrev.com/4fd4eb5001d2671df1dfee7fc9414674aed52846/src/libANGLE/renderer/vulkan/vk_helpers.cpp
[modify] https://crrev.com/4fd4eb5001d2671df1dfee7fc9414674aed52846/src/libANGLE/renderer/vulkan/UtilsVk.cpp
[modify] https://crrev.com/4fd4eb5001d2671df1dfee7fc9414674aed52846/src/libANGLE/renderer/vulkan/vk_helpers.cpp
Git Watcher via monorail
Apr 29, 2022, 10:17:41 PM4/29/22
to angleproj...@googlegroups.com
Comment #14 on issue 6566 by Git Watcher: Genshin impact rendering issue with SwiftShader - unwritten FB attachments
https://bugs.chromium.org/p/angleproject/issues/detail?id=6566#c14
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/c7a9f0c6c49cc4a9b848ab308bf39b8309347187
commit c7a9f0c6c49cc4a9b848ab308bf39b8309347187
Author: Shahbaz Youssefi <syou...@chromium.org>
Date: Wed Apr 27 20:20:51 2022
Vulkan: Remove syncval suppressions no longer triggering
Bug: angleproject:6422
Bug: angleproject:6424
Bug: angleproject:6566
Change-Id: If4d6cf097108f71732d093f3debfc30475a3c90c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3612183
Reviewed-by: Jamie Madill <jma...@chromium.org>
Commit-Queue: Shahbaz Youssefi <syou...@chromium.org>
[modify] https://crrev.com/c7a9f0c6c49cc4a9b848ab308bf39b8309347187/src/libANGLE/renderer/vulkan/RendererVk.cpp
commit c7a9f0c6c49cc4a9b848ab308bf39b8309347187
Author: Shahbaz Youssefi <syou...@chromium.org>
Date: Wed Apr 27 20:20:51 2022
Vulkan: Remove syncval suppressions no longer triggering
Bug: angleproject:6422
Bug: angleproject:6424
Bug: angleproject:6566
Change-Id: If4d6cf097108f71732d093f3debfc30475a3c90c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3612183
Reviewed-by: Jamie Madill <jma...@chromium.org>
Commit-Queue: Shahbaz Youssefi <syou...@chromium.org>
[modify] https://crrev.com/c7a9f0c6c49cc4a9b848ab308bf39b8309347187/src/libANGLE/renderer/vulkan/RendererVk.cpp
Git Watcher via monorail
Sep 13, 2022, 1:26:12 PM9/13/22
to angleproj...@googlegroups.com
Comment #15 on issue 6566 by Git Watcher: Genshin impact rendering issue with SwiftShader - unwritten FB attachments
https://bugs.chromium.org/p/angleproject/issues/detail?id=6566#c15
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/d375547ced52fc3aee7a29828a838980e43c75ce
commit d375547ced52fc3aee7a29828a838980e43c75ce
Author: Mohan Maiya <m.m...@samsung.com>
Date: Fri Aug 12 22:54:39 2022
Do not link program pipeline in glUseProgramStages
1. The commit 3a9f18f135fe82 caused a link to occur everytime
glUseProgramStages is called. This is redundant since the program
pipeline can be linked just before usage, thus allowing for multiple
stages to be bound before linking the executable.
2. Mark PPO as a dirty object and link the PPO in dirty object handler
3. Early return if the same program is being bound to the same stage
of the pipeline.
4. Added ProgramPipelineObjectBenchmark perf test that switches programs
before a draw and observed following data -
1. vulkan profile -
1. wall_time before patch - 102000 ns
2. wall_time after patch - 38000 ns
2. vulkan_null profile -
1. wall_time before patch - 125000 ns
2. wall_time after patch - 52000 ns
Bug: angleproject:5102
Bug: angleproject:6566
Test: ContextNoErrorPPOTest31.*Vulkan
Test: ProgramPipelineTest31.*Vulkan
Test: ProgramPipelineObjectBenchmark*
Change-Id: Idbc2fcb4875bbd040e9ec847eb2a8f96f287173c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3830170
Reviewed-by: Shahbaz Youssefi <syou...@chromium.org>
Reviewed-by: Jamie Madill <jma...@chromium.org>
Commit-Queue: mohan maiya <m.m...@samsung.com>
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/libANGLE/ProgramPipeline.h
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/tests/angle_perftests.gni
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/tests/gl_tests/ContextNoErrorTest.cpp
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/libANGLE/Context.cpp
[add] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/tests/perf_tests/ProgramPipelineObjectPerfTest.cpp
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/libANGLE/State.cpp
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/libANGLE/Framebuffer.cpp
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/libANGLE/validationES.cpp
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/libANGLE/validationES3.cpp
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/libANGLE/TransformFeedback.cpp
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/libANGLE/ProgramPipeline.cpp
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/libANGLE/State.h
commit d375547ced52fc3aee7a29828a838980e43c75ce
Author: Mohan Maiya <m.m...@samsung.com>
Date: Fri Aug 12 22:54:39 2022
Do not link program pipeline in glUseProgramStages
1. The commit 3a9f18f135fe82 caused a link to occur everytime
glUseProgramStages is called. This is redundant since the program
pipeline can be linked just before usage, thus allowing for multiple
stages to be bound before linking the executable.
2. Mark PPO as a dirty object and link the PPO in dirty object handler
3. Early return if the same program is being bound to the same stage
of the pipeline.
4. Added ProgramPipelineObjectBenchmark perf test that switches programs
before a draw and observed following data -
1. vulkan profile -
1. wall_time before patch - 102000 ns
2. wall_time after patch - 38000 ns
2. vulkan_null profile -
1. wall_time before patch - 125000 ns
2. wall_time after patch - 52000 ns
Bug: angleproject:5102
Bug: angleproject:6566
Test: ContextNoErrorPPOTest31.*Vulkan
Test: ProgramPipelineTest31.*Vulkan
Test: ProgramPipelineObjectBenchmark*
Change-Id: Idbc2fcb4875bbd040e9ec847eb2a8f96f287173c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3830170
Reviewed-by: Shahbaz Youssefi <syou...@chromium.org>
Reviewed-by: Jamie Madill <jma...@chromium.org>
Commit-Queue: mohan maiya <m.m...@samsung.com>
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/libANGLE/ProgramPipeline.h
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/tests/angle_perftests.gni
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/tests/gl_tests/ContextNoErrorTest.cpp
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/libANGLE/Context.cpp
[add] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/tests/perf_tests/ProgramPipelineObjectPerfTest.cpp
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/libANGLE/State.cpp
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/libANGLE/Framebuffer.cpp
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/libANGLE/validationES.cpp
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/libANGLE/validationES3.cpp
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/libANGLE/TransformFeedback.cpp
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/libANGLE/ProgramPipeline.cpp
[modify] https://crrev.com/d375547ced52fc3aee7a29828a838980e43c75ce/src/libANGLE/State.h
Reply all
Reply to author
Forward
0 new messages