Issue 2962 in angleproject: Update ANGLE Developer Options

0 views
Skip to first unread message

ti… via monorail

unread,
Nov 14, 2018, 6:19:53 PM11/14/18
to angleproj...@googlegroups.com
Status: Accepted
Owner: ti...@google.com
OS: Android
Priority: Medium
Type: Enhancement

New issue 2962 by ti...@google.com: Update ANGLE Developer Options
https://bugs.chromium.org/p/angleproject/issues/detail?id=2962

The ANGLE developer options will be updated to do the following:

1.) Move the developer option code into the ANGLE APK.
2.) Allow forcing multiple apps to default/native/ANGLE.

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

bugdro… via monorail

unread,
Nov 27, 2018, 5:59:46 PM11/27/18
to angleproj...@googlegroups.com

Comment #1 on issue 2962 by bugd...@chromium.org: Update ANGLE Developer Options
https://bugs.chromium.org/p/angleproject/issues/detail?id=2962#c1

The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3

commit fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3
Author: Tim Van Patten <ti...@google.com>
Date: Tue Nov 27 22:59:12 2018

Enhance ANGLE for Android Developer Options

Update ANGLE Developer Options

Update ANGLE developer options to allow selecting the OpenGL driver
(default, ANGLE, native) for each app as well as forcing ANGLE for all
apps.

Bug: angleproject:2962
Test: Verify the default/ANGLE/native values are saved and applied and
used by the loader.

Change-Id: I6041e7e49ca5cc65f90fc8ae6f1b084e4639d769
Reviewed-on: https://chromium-review.googlesource.com/c/1330315
Commit-Queue: Tim Van Patten <ti...@google.com>
Reviewed-by: Geoff Lang <geof...@chromium.org>
Reviewed-by: Jamie Madill <jma...@chromium.org>

[add] https://crrev.com/fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3/android/res/layout/fragment.xml
[add] https://crrev.com/fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3/android/res/values/drivers.xml
[add] https://crrev.com/fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3/android/res/values/global_settings.xml
[add] https://crrev.com/fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3/android/res/values/preference_keys.xml
[add] https://crrev.com/fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3/android/res/xml/main.xml
[add] https://crrev.com/fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3/android/res/values-v17/styles.xml
[add] https://crrev.com/fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3/android/src/com/google/android/angle/MainActivity.java
[modify] https://crrev.com/fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3/src/feature_support_util/a4a_rules.json
[add] https://crrev.com/fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3/android/src/com/google/android/angle/GlobalSettings.java
[modify] https://crrev.com/fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3/.gitignore
[modify] https://crrev.com/fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3/BUILD.gn
[add] https://crrev.com/fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3/android/OWNERS
[add] https://crrev.com/fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3/android/res/values/strings.xml
[delete] https://crrev.com/e0472f3d52a4b55c010ac5bfc6d7c345c3314f7a/AndroidManifest.xml
[add] https://crrev.com/fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3/android/src/com/google/android/angle/Receiver.java
[add] https://crrev.com/fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3/android/AndroidManifest.xml
[add] https://crrev.com/fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3/android/src/com/google/android/angle/MainFragment.java
[add] https://crrev.com/fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3/android/res/values/dimens.xml
[modify] https://crrev.com/fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3/src/feature_support_util/feature_support_util.cpp
[modify] https://crrev.com/fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3/src/feature_support_util/feature_support_util.h

bugdro… via monorail

unread,
Nov 28, 2018, 11:08:58 AM11/28/18
to angleproj...@googlegroups.com

Comment #2 on issue 2962 by bugd...@chromium.org: Update ANGLE Developer Options
https://bugs.chromium.org/p/angleproject/issues/detail?id=2962#c2


The following revision refers to this bug:

Author: Tim Van Patten <ti...@google.com>
Date: Wed Nov 28 16:08:19 2018

Revert "Enhance ANGLE for Android Developer Options"

This reverts commit fdbdb2b247ffa4cf66bc2cd3a5bb45a056bd88a3.

Reason for revert:
I didn't mean to land this quite yet, since we are still working on the Android side of things. It seems doing CQ+2 merges it while I was trying for just a dry run while replying to Jamie's comments with updates (after checking with Boulder folks, I want CQ+1 next time).

Once the Android changes are ready, I'll work on getting this landed again.

Original change's description:

> Enhance ANGLE for Android Developer Options
>
> Update ANGLE Developer Options
>
> Update ANGLE developer options to allow selecting the OpenGL driver
> (default, ANGLE, native) for each app as well as forcing ANGLE for all
> apps.
>
> Bug: angleproject:2962
> Test: Verify the default/ANGLE/native values are saved and applied and
> used by the loader.
>
> Change-Id: I6041e7e49ca5cc65f90fc8ae6f1b084e4639d769
> Reviewed-on: https://chromium-review.googlesource.com/c/1330315
> Commit-Queue: Tim Van Patten <ti...@google.com>
> Reviewed-by: Geoff Lang <geof...@chromium.org>
> Reviewed-by: Jamie Madill <jma...@chromium.org>

TBR=ynov...@chromium.org,geof...@chromium.org,jma...@chromium.org,cnor...@google.com,tob...@google.com,court...@google.com,ianel...@google.com,ti...@google.com

Change-Id: If3a4e917973c56b858244a0ca7f1b164143524f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:2962
Reviewed-on: https://chromium-review.googlesource.com/c/1354099
Reviewed-by: Tim Van Patten <ti...@google.com>

Commit-Queue: Tim Van Patten <ti...@google.com>

[delete] https://crrev.com/83b2f0e8a2e09ae469fe1afd05842ee5dcfb38c2/android/res/layout/fragment.xml
[delete] https://crrev.com/83b2f0e8a2e09ae469fe1afd05842ee5dcfb38c2/android/res/values/drivers.xml
[delete] https://crrev.com/83b2f0e8a2e09ae469fe1afd05842ee5dcfb38c2/android/res/values/global_settings.xml
[delete] https://crrev.com/83b2f0e8a2e09ae469fe1afd05842ee5dcfb38c2/android/res/values/preference_keys.xml
[delete] https://crrev.com/83b2f0e8a2e09ae469fe1afd05842ee5dcfb38c2/android/res/xml/main.xml
[delete] https://crrev.com/83b2f0e8a2e09ae469fe1afd05842ee5dcfb38c2/android/res/values-v17/styles.xml
[delete] https://crrev.com/83b2f0e8a2e09ae469fe1afd05842ee5dcfb38c2/android/src/com/google/android/angle/MainActivity.java
[modify] https://crrev.com/c4e0a1e511fca7996710d1204e968fa0b493d5a0/src/feature_support_util/a4a_rules.json
[delete] https://crrev.com/83b2f0e8a2e09ae469fe1afd05842ee5dcfb38c2/android/src/com/google/android/angle/GlobalSettings.java
[modify] https://crrev.com/c4e0a1e511fca7996710d1204e968fa0b493d5a0/.gitignore
[modify] https://crrev.com/c4e0a1e511fca7996710d1204e968fa0b493d5a0/BUILD.gn
[delete] https://crrev.com/83b2f0e8a2e09ae469fe1afd05842ee5dcfb38c2/android/OWNERS
[delete] https://crrev.com/83b2f0e8a2e09ae469fe1afd05842ee5dcfb38c2/android/res/values/strings.xml
[add] https://crrev.com/c4e0a1e511fca7996710d1204e968fa0b493d5a0/AndroidManifest.xml
[delete] https://crrev.com/83b2f0e8a2e09ae469fe1afd05842ee5dcfb38c2/android/src/com/google/android/angle/Receiver.java
[delete] https://crrev.com/83b2f0e8a2e09ae469fe1afd05842ee5dcfb38c2/android/AndroidManifest.xml
[delete] https://crrev.com/83b2f0e8a2e09ae469fe1afd05842ee5dcfb38c2/android/src/com/google/android/angle/MainFragment.java
[delete] https://crrev.com/83b2f0e8a2e09ae469fe1afd05842ee5dcfb38c2/android/res/values/dimens.xml
[modify] https://crrev.com/c4e0a1e511fca7996710d1204e968fa0b493d5a0/src/feature_support_util/feature_support_util.cpp
[modify] https://crrev.com/c4e0a1e511fca7996710d1204e968fa0b493d5a0/src/feature_support_util/feature_support_util.h

bugdro… via monorail

unread,
Dec 5, 2018, 4:38:36 PM12/5/18
to angleproj...@googlegroups.com

Comment #3 on issue 2962 by bugd...@chromium.org: Update ANGLE Developer Options
https://bugs.chromium.org/p/angleproject/issues/detail?id=2962#c3


The following revision refers to this bug:

Author: Tim Van Patten <ti...@google.com>
Date: Wed Dec 05 21:38:05 2018


Enhance ANGLE for Android Developer Options

Update ANGLE Developer Options

Update ANGLE developer options to allow selecting the OpenGL driver
(default, ANGLE, native) for each app as well as forcing ANGLE for all
apps.

Bug: angleproject:2962
Test: Verify the default/ANGLE/native values are saved and applied and
used by the loader.

Change-Id: I6737b11bc061318cf8438c8161593ca70239590f
Reviewed-on: https://chromium-review.googlesource.com/c/1354101
Reviewed-by: Yuly Novikov <ynov...@chromium.org>
Reviewed-by: Geoff Lang <geof...@chromium.org>

Commit-Queue: Tim Van Patten <ti...@google.com>

[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/res/layout/fragment.xml
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/res/values/drivers.xml
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/res/values/global_settings.xml
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/AndroidManifest.xml.jinja2
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/res/xml/main.xml
[modify] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/angle_apk.gni
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/res/values/preference_keys.xml
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/src/com/google/android/angle/MainActivity.java
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/res/values-v17/styles.xml
[modify] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/src/feature_support_util/a4a_rules.json
[modify] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/.gitignore
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/res/values/strings.xml
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/src/com/android/angle/MainActivity.java
[modify] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/BUILD.gn
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/OWNERS
[delete] https://crrev.com/eae081c6682aea6f754e662a48a5c75f825f6873/AndroidManifest.xml.jinja2
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/src/com/android/angle/common/Receiver.java
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/src/com/android/angle/common/MainFragment.java
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/res/values/dimens.xml
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/src/com/android/angle/common/GlobalSettings.java

ti… via monorail

unread,
Dec 10, 2018, 12:40:19 PM12/10/18
to angleproj...@googlegroups.com
Updates:
Status: Fixed

Comment #4 on issue 2962 by ti...@google.com: Update ANGLE Developer Options
https://bugs.chromium.org/p/angleproject/issues/detail?id=2962#c4

(No comment was entered for this change.)

Git Watcher via monorail

unread,
Apr 23, 2024, 8:33:12 AM4/23/24
to angleproj...@googlegroups.com

Comment #5 on issue 2962 by Git Watcher: Update ANGLE Developer Options
https://bugs.chromium.org/p/angleproject/issues/detail?id=2962#c5


The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83

commit fdccaa3acbcefa7719746345aa0ac7f2a9b29b83
Author: Tim Van Patten <ti...@google.com>
Date: Thu Nov 01 23:47:10 2018


Enhance ANGLE for Android Developer Options

Update ANGLE Developer Options

Update ANGLE developer options to allow selecting the OpenGL driver
(default, ANGLE, native) for each app as well as forcing ANGLE for all
apps.

Bug: angleproject:2962
Test: Verify the default/ANGLE/native values are saved and applied and
used by the loader.

Change-Id: I6737b11bc061318cf8438c8161593ca70239590f
Reviewed-on: https://chromium-review.googlesource.com/c/1354101
Reviewed-by: Yuly Novikov <ynov...@chromium.org>
Reviewed-by: Geoff Lang <geof...@chromium.org>
Commit-Queue: Tim Van Patten <ti...@google.com>

[delete] https://crrev.com/eae081c6682aea6f754e662a48a5c75f825f6873/AndroidManifest.xml.jinja2
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/res/values-v17/styles.xml
[modify] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/.gitignore
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/res/layout/fragment.xml
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/src/com/android/angle/common/MainFragment.java
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/src/com/google/android/angle/MainActivity.java
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/src/com/android/angle/MainActivity.java
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/res/values/drivers.xml
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/AndroidManifest.xml.jinja2
[modify] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/angle_apk.gni
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/res/values/dimens.xml
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/res/values/global_settings.xml
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/OWNERS
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/res/values/preference_keys.xml
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/res/values/strings.xml
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/src/com/android/angle/common/GlobalSettings.java
[modify] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/BUILD.gn
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/res/xml/main.xml
[add] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/android/src/com/android/angle/common/Receiver.java
[modify] https://crrev.com/fdccaa3acbcefa7719746345aa0ac7f2a9b29b83/src/feature_support_util/a4a_rules.json
Reply all
Reply to author
Forward
0 new messages