Issue 5038 in angleproject: Support EXT_color_buffer_half_float on WebGL 2.0 contexts

2 views
Skip to first unread message

jdarpin… via monorail

unread,
Sep 11, 2020, 6:19:35 PM9/11/20
to angleproj...@googlegroups.com
Status: Accepted
Owner: ----
Priority: Medium
Type: Defect

New issue 5038 by jdarp...@chromium.org: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038

EXT_color_buffer_half_float was recently updated to be valid for WebGL 2 contexts becuase iOS can't support EXT_color_buffer_float. https://github.com/KhronosGroup/WebGL/pull/3146

This was done in WebKit and the change should be upstreamed here. https://bugs.webkit.org/show_bug.cgi?id=216010

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

k… via monorail

unread,
Sep 11, 2020, 6:26:04 PM9/11/20
to angleproj...@googlegroups.com
Updates:
Cc: k...@chromium.org geoffl...@chromium.org jon...@google.com
Labels: OS-Mac Renderer-GLES

Comment #1 on issue 5038 by k...@chromium.org: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c1

(No comment was entered for this change.)

k… via monorail

unread,
Sep 11, 2020, 6:26:18 PM9/11/20
to angleproj...@googlegroups.com
Updates:
Owner: jdarp...@chromium.org
Status: Assigned

Comment #2 on issue 5038 by k...@chromium.org: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c2

James, will you be able to upstream this patch?

jdarpin… via monorail

unread,
Sep 11, 2020, 6:44:53 PM9/11/20
to angleproj...@googlegroups.com

Comment #3 on issue 5038 by jdarp...@chromium.org: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c3

Yes, working on it. Forgot to assign it to myself :)

bugdroid via monorail

unread,
Sep 29, 2020, 10:13:24 PM9/29/20
to angleproj...@googlegroups.com

Comment #4 on issue 5038 by bugdroid: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c4

The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/74ed9b653a878a9bd8c74f95940be6894eea5604

commit 74ed9b653a878a9bd8c74f95940be6894eea5604
Author: James Darpinian <jdarp...@chromium.org>
Date: Wed Sep 30 02:12:29 2020


Support EXT_color_buffer_half_float on WebGL 2.0 contexts

EXT_color_buffer_half_float was recently updated to be valid for
WebGL 2 contexts because iOS can't support EXT_color_buffer_float.

Bug: angleproject:5038
Change-Id: Ib0d35c6b26a6cd215ff6725e92c47d1efd64e048
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415187
Commit-Queue: James Darpinian <jdarp...@chromium.org>
Reviewed-by: Geoff Lang <geof...@chromium.org>
Reviewed-by: Kenneth Russell <k...@chromium.org>

[modify] https://crrev.com/74ed9b653a878a9bd8c74f95940be6894eea5604/src/libANGLE/validationES2.cpp
[modify] https://crrev.com/74ed9b653a878a9bd8c74f95940be6894eea5604/src/libANGLE/Context.cpp
[modify] https://crrev.com/74ed9b653a878a9bd8c74f95940be6894eea5604/src/libANGLE/formatutils.cpp
[modify] https://crrev.com/74ed9b653a878a9bd8c74f95940be6894eea5604/src/libANGLE/renderer/gl/renderergl_utils.cpp
[modify] https://crrev.com/74ed9b653a878a9bd8c74f95940be6894eea5604/src/tests/gl_tests/WebGLCompatibilityTest.cpp

bugdroid via monorail

unread,
Sep 30, 2020, 9:51:41 PM9/30/20
to angleproj...@googlegroups.com

Comment #5 on issue 5038 by bugdroid: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c5


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/529c85d58ec9a3545fa3d47fab4b61b1dec9daa0

commit 529c85d58ec9a3545fa3d47fab4b61b1dec9daa0
Author: James Darpinian <jdarp...@chromium.org>
Date: Thu Oct 01 01:46:58 2020


Support EXT_color_buffer_half_float on WebGL 2.0 contexts

EXT_color_buffer_half_float was recently updated to be valid
for WebGL 2 contexts because iOS can't support EXT_color_buffer_float.

Bug: angleproject:5038
Change-Id: I5e5c6681588b3317d116277481d031b6dc36744e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415433
Commit-Queue: James Darpinian <jdarp...@chromium.org>
Reviewed-by: Shrek Shao <shre...@google.com>
Reviewed-by: Kai Ninomiya <kai...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812512}

[modify] https://crrev.com/529c85d58ec9a3545fa3d47fab4b61b1dec9daa0/content/test/gpu/gpu_tests/test_expectations/webgl2_conformance_expectations.txt
[modify] https://crrev.com/529c85d58ec9a3545fa3d47fab4b61b1dec9daa0/content/test/gpu/gpu_tests/webgl_conformance_integration_test.py
[modify] https://crrev.com/529c85d58ec9a3545fa3d47fab4b61b1dec9daa0/third_party/blink/renderer/modules/webgl/ext_color_buffer_half_float.cc
[modify] https://crrev.com/529c85d58ec9a3545fa3d47fab4b61b1dec9daa0/third_party/blink/renderer/modules/webgl/ext_color_buffer_half_float.idl
[modify] https://crrev.com/529c85d58ec9a3545fa3d47fab4b61b1dec9daa0/third_party/blink/renderer/modules/webgl/webgl2_rendering_context.cc
[modify] https://crrev.com/529c85d58ec9a3545fa3d47fab4b61b1dec9daa0/third_party/blink/renderer/modules/webgl/webgl2_rendering_context.h
[modify] https://crrev.com/529c85d58ec9a3545fa3d47fab4b61b1dec9daa0/third_party/blink/renderer/modules/webgl/webgl2_rendering_context_base.cc
[modify] https://crrev.com/529c85d58ec9a3545fa3d47fab4b61b1dec9daa0/third_party/blink/renderer/modules/webgl/webgl_color_buffer_float.idl
[modify] https://crrev.com/529c85d58ec9a3545fa3d47fab4b61b1dec9daa0/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/529c85d58ec9a3545fa3d47fab4b61b1dec9daa0/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h

bugdroid via monorail

unread,
Oct 1, 2020, 5:22:10 AM10/1/20
to angleproj...@googlegroups.com

Comment #6 on issue 5038 by bugdroid: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c6


The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/3d5e8c4c466d5ec179f4d88e4ea566d6c4683ae6

commit 3d5e8c4c466d5ec179f4d88e4ea566d6c4683ae6
Author: angle-autoroll <angle-a...@skia-public.iam.gserviceaccount.com>
Date: Thu Oct 01 09:21:44 2020

Roll Chromium from 18cdc3179c58 to 5efa84e265f7 (627 revisions)

https://chromium.googlesource.com/chromium/src.git/+log/18cdc3179c58..5efa84e265f7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jon...@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/3ede10128b..83b9c33a0b
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/fe12eb7d0a..66ad7ae099
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/bd8e096f1d..921f371807
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6c5b056475..410285a57e
No update to Clang.

Bug: angleproject:5038
Tbr: jon...@google.com
Change-Id: I6d685864226e263081fe146ff3e7d04cfed4d336
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2441981
Reviewed-by: angle-autoroll <angle-a...@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-a...@skia-public.iam.gserviceaccount.com>

[modify] https://crrev.com/3d5e8c4c466d5ec179f4d88e4ea566d6c4683ae6/DEPS

bugdroid via monorail

unread,
Oct 7, 2020, 12:51:12 AM10/7/20
to angleproj...@googlegroups.com

Comment #7 on issue 5038 by bugdroid: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c7


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/41ec219e49919c75a6d8b63cd2e7a9d079011a95

commit 41ec219e49919c75a6d8b63cd2e7a9d079011a95
Author: Shrek Shao <shre...@google.com>
Date: Wed Oct 07 04:50:01 2020

Roll WebGL 91b544d..1a111c2

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/91b544d..1a111c2

TBR=k...@chromium.org

Bug: 1135785, angleproject:5038
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64
Change-Id: I618c5db369e68f8088a215f0a9b74f1e82b09636
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455029
Reviewed-by: Shrek Shao <shre...@google.com>
Commit-Queue: Shrek Shao <shre...@google.com>
Cr-Commit-Position: refs/heads/master@{#814549}

[modify] https://crrev.com/41ec219e49919c75a6d8b63cd2e7a9d079011a95/DEPS
[modify] https://crrev.com/41ec219e49919c75a6d8b63cd2e7a9d079011a95/content/test/gpu/gpu_tests/test_expectations/webgl_conformance_expectations.txt
[modify] https://crrev.com/41ec219e49919c75a6d8b63cd2e7a9d079011a95/content/test/gpu/gpu_tests/webgl_conformance_revision.txt

bugdroid via monorail

unread,
Oct 7, 2020, 3:10:09 PM10/7/20
to angleproj...@googlegroups.com

Comment #8 on issue 5038 by bugdroid: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c8


The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/2d9d904ecb307ba35c60ae81de8e31cbdc8e2c2b

commit 2d9d904ecb307ba35c60ae81de8e31cbdc8e2c2b
Author: Yuke Liao <liao...@chromium.org>
Date: Wed Oct 07 19:08:03 2020

Roll Chromium manually from edbb6564c87b to a5a8696e5087 (458 revisions)

https://chromium.googlesource.com/chromium/src.git/+log/edbb6564c87b..a5a8696e5087


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ti...@google.com on the revert to ensure that a human

is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/6186e428fc..854fdb73c8
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/1c37217884..0fa2c0deee
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c5290b5af7..7e5979b1dd
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5e26fff7a7..cc0ee19df9
No update to Clang.

Bug: angleproject:5038,angleproject:5124
Change-Id: Idcfbd8a5887c76b15d5a8aa424233eaef5de3a96
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2457127
Commit-Queue: Jamie Madill <jma...@chromium.org>
Reviewed-by: Jamie Madill <jma...@chromium.org>

[modify] https://crrev.com/2d9d904ecb307ba35c60ae81de8e31cbdc8e2c2b/DEPS
[modify] https://crrev.com/2d9d904ecb307ba35c60ae81de8e31cbdc8e2c2b/gni/angle.gni

k… via monorail

unread,
Oct 7, 2020, 6:01:55 PM10/7/20
to angleproj...@googlegroups.com
Updates:
Status: Started

Comment #10 on issue 5038 by k...@chromium.org: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c10


(No comment was entered for this change.)

bugdroid via monorail

unread,
Oct 7, 2020, 7:41:50 PM10/7/20
to angleproj...@googlegroups.com

Comment #11 on issue 5038 by bugdroid: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c11


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/0843aa5828d93877e4584c7fb354e341fc63b8af

commit 0843aa5828d93877e4584c7fb354e341fc63b8af
Author: Kai Ninomiya <kai...@chromium.org>
Date: Wed Oct 07 23:39:51 2020

Add webgl2 suppression for ext-color-buffer-half-float.html

Already suppressed for webgl1, just needed for webgl2 to fix our FYI
testing.

TBR: shre...@google.com
Bug: angleproject:5038
Change-Id: I1bb5a6005ecfc09df13150f0f8082834675c5384
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459390
Reviewed-by: Kai Ninomiya <kai...@chromium.org>
Reviewed-by: Shrek Shao <shre...@google.com>
Commit-Queue: Kai Ninomiya <kai...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814947}

[modify] https://crrev.com/0843aa5828d93877e4584c7fb354e341fc63b8af/content/test/gpu/gpu_tests/test_expectations/webgl2_conformance_expectations.txt

kain… via monorail

unread,
Oct 7, 2020, 9:41:42 PM10/7/20
to angleproj...@googlegroups.com
Updates:
Cc: kai...@chromium.org jdarp...@chromium.org shre...@google.com

Comment #12 on issue 5038 by kai...@chromium.org: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c12

Issue chromium:1136233 has been merged into this issue.

kain… via monorail

unread,
Oct 7, 2020, 9:42:12 PM10/7/20
to angleproj...@googlegroups.com
Updates:
Cc: -kai...@chromium.org -shre...@google.com -jdarp...@chromium.org

Comment #13 on issue 5038 by kai...@chromium.org: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c13


(No comment was entered for this change.)

bugdroid via monorail

unread,
Oct 8, 2020, 4:03:44 AM10/8/20
to angleproj...@googlegroups.com

Comment #14 on issue 5038 by bugdroid: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c14


The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/6a09a9d46097815b3df3d297f216d3d73fa479b0

commit 6a09a9d46097815b3df3d297f216d3d73fa479b0
Author: angle-autoroll <angle-a...@skia-public.iam.gserviceaccount.com>
Date: Thu Oct 08 08:03:07 2020

Roll Chromium from a5a8696e5087 to 090102a7065c (466 revisions)

https://chromium.googlesource.com/chromium/src.git/+log/a5a8696e5087..090102a7065c


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ti...@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/854fdb73c8..d058068a4b
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/0fa2c0deee..17295a5c35
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/54a9cb2f54..c89bad5e6d
* tools/luci-go: git_revision:83c3df996b224edf5061840744395707a0e513e7..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb
* tools/luci-go: git_revision:83c3df996b224edf5061840744395707a0e513e7..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb
* tools/luci-go: git_revision:83c3df996b224edf5061840744395707a0e513e7..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/cc0ee19df9..7054864146
* tools/skia_goldctl/linux: dMvix4BkhDJmKBK1tudaxlOMub1Dif3ZPcqzSY72-ZAC..ehm_yIO4CdwsvaJZJPQ2xBXAFv3KXEgrDpTY3AaK7EYC
* tools/skia_goldctl/mac: xJncEfNMb0HaDG9EglMx2YNbKAxqk6qJbckhfn0BXb8C..wIHfWG-DQOw0ISbpkWZrm2f2GoKa3H1Z4I2w8MxhlVIC
* tools/skia_goldctl/win: cLgS219WFD65Hr6NfoCQYA5KEE2FfO3FBl30KYhpTFoC..ixP2POw1dVLvzG-YPiGAJdFrTLwpr--nwyQr_S5FoRkC

No update to Clang.

Bug: angleproject:5038,angleproject:5124
Tbr: ti...@google.com
Change-Id: Ic1b5300ae727a297ac0628c46d37c994eeb6c6fc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2458792

Git Watcher via monorail

unread,
Jul 1, 2022, 2:06:06 AM7/1/22
to angleproj...@googlegroups.com

Comment #15 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c15


The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/7cb0622cb0e1cdf2cff6998c602b6b027beadadb

commit 7cb0622cb0e1cdf2cff6998c602b6b027beadadb
Author: Alexey Knyazev <lexa.k...@gmail.com>
Date: Thu Jun 30 00:00:00 2022

BlitGL: Fix LUMAWorkaround for half-float copies

Use desktop HALF_FLOAT enum when running on desktop OpenGL.

Bug: angleproject:5038
Change-Id: I829f28ca51caa1f98b653d1a456ed775f8d362cb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3738261
Reviewed-by: Kenneth Russell <k...@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.k...@gmail.com>

[modify] https://crrev.com/7cb0622cb0e1cdf2cff6998c602b6b027beadadb/src/libANGLE/renderer/gl/BlitGL.cpp

k… via monorail

unread,
Jul 1, 2022, 1:59:51 PM7/1/22
to angleproj...@googlegroups.com
Updates:
Cc: jdarp...@chromium.org
Labels: Renderer-DesktopGL
Owner: lexa....@gmail.com

Comment #16 on issue 5038 by k...@chromium.org: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c16

Thanks Alexey for tracking that down. Will this fix the ext-color-buffer-half-float.html test so it can be unsuppressed?

lexa.… via monorail

unread,
Jul 1, 2022, 2:13:11 PM7/1/22
to angleproj...@googlegroups.com
Updates:
Owner: ----

Comment #17 on issue 5038 by lexa....@gmail.com: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c17

The fix above makes the test pass on macOS OpenGL. The suppression seems to be universal, so other platforms need to be checked before removing it.

k… via monorail

unread,
Jul 1, 2022, 5:40:13 PM7/1/22
to angleproj...@googlegroups.com
Updates:
Owner: k...@chromium.org

Comment #18 on issue 5038 by k...@chromium.org: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c18

Thanks. ANGLE rolled forward containing this fix in https://chromium-review.googlesource.com/c/chromium/src/+/3739849/ , so trying to unsuppress the test in https://chromium-review.googlesource.com/c/chromium/src/+/3741403 .

k… via monorail

unread,
Jul 1, 2022, 6:30:25 PM7/1/22
to angleproj...@googlegroups.com

Comment #19 on issue 5038 by k...@chromium.org: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c19

Still failing on several configurations, so will narrow the suppression once the results are in.

Git Watcher via monorail

unread,
Jul 1, 2022, 10:53:11 PM7/1/22
to angleproj...@googlegroups.com

Comment #20 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c20


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/11c1874386641fff965f737cfd1099e548d88947

commit 11c1874386641fff965f737cfd1099e548d88947
Author: Kenneth Russell <k...@chromium.org>
Date: Sat Jul 02 02:52:36 2022

Unsuppress ext-color-buffer-half-float.html.

conformance/extensions/ext-color-buffer-half-float.html is passing
on all desired configurations with the latest ANGLE fixes.

Permanently suppress on Win/D3D9, which is obsolete, and ChromeOS
with the validating command decoder, as passthrough+ANGLE will ship
there soon.

Bug: angleproject:5038
Change-Id: I2087ae29b635b6ed7e59f828d1a3c8f5f0810b7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3741403
Commit-Queue: Kenneth Russell <k...@chromium.org>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1020335}

[modify] https://crrev.com/11c1874386641fff965f737cfd1099e548d88947/content/test/gpu/gpu_tests/test_expectations/webgl2_conformance_expectations.txt
[modify] https://crrev.com/11c1874386641fff965f737cfd1099e548d88947/content/test/gpu/gpu_tests/test_expectations/webgl_conformance_expectations.txt

Git Watcher via monorail

unread,
Jul 2, 2022, 4:26:11 PM7/2/22
to angleproj...@googlegroups.com

Comment #21 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c21


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/a8b872aa9fe9cdd6d5bed731fdaa9314bf6d37d3

commit a8b872aa9fe9cdd6d5bed731fdaa9314bf6d37d3
Author: Maggie Chen <mag...@chromium.org>
Date: Sat Jul 02 20:25:16 2022

Revert "Unsuppress ext-color-buffer-half-float.html."

This reverts commit 11c1874386641fff965f737cfd1099e548d88947.

Reason for revert: <ext-color-buffer-half-float.html fails and GPU Android FYI bots turn red.>

Original change's description:

> Unsuppress ext-color-buffer-half-float.html.
>
> conformance/extensions/ext-color-buffer-half-float.html is passing
> on all desired configurations with the latest ANGLE fixes.
>
> Permanently suppress on Win/D3D9, which is obsolete, and ChromeOS
> with the validating command decoder, as passthrough+ANGLE will ship
> there soon.
>
> Bug: angleproject:5038
> Change-Id: I2087ae29b635b6ed7e59f828d1a3c8f5f0810b7a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3741403
> Commit-Queue: Kenneth Russell <k...@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1020335}

Bug: angleproject:5038
Change-Id: Ic6244b253f1ebd02f78589a0f80e1c823d337f69
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3742043
Commit-Queue: Maggie Chen <mag...@chromium.org>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Auto-Submit: Maggie Chen <mag...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1020394}

[modify] https://crrev.com/a8b872aa9fe9cdd6d5bed731fdaa9314bf6d37d3/content/test/gpu/gpu_tests/test_expectations/webgl2_conformance_expectations.txt
[modify] https://crrev.com/a8b872aa9fe9cdd6d5bed731fdaa9314bf6d37d3/content/test/gpu/gpu_tests/test_expectations/webgl_conformance_expectations.txt

magc… via monorail

unread,
Jul 2, 2022, 4:29:53 PM7/2/22
to angleproj...@googlegroups.com

Comment #22 on issue 5038 by mag...@chromium.org: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c22

ext-color-buffer-half-float.html fails on all GPU Android FYI bots.

https://ci.chromium.org/ui/p/chromium/builders/ci/Android%20FYI%20Release%20(Pixel%206)/2104/overview
https://chromium-swarm.appspot.com/task?id=5bd8d7c9a6d2ac11
webgl_conformance_integration_test.py(335): AssertionError: getError expected: NO_ERROR. Was INVALID_ENUM : CopyTexImage2D
FAIL getError expected: NO_ERROR. Was INVALID_ENUM : CopyTexImage2D
getError expected: NO_ERROR. Was INVALID_ENUM : CopyTexImage2D
FAIL getError expected: NO_ERROR. Was INVALID_ENUM : CopyTexImage2D
getError expected: NO_ERROR. Was INVALID_ENUM : CopyTexImage2D
FAIL getError expected: NO_ERROR. Was INVALID_ENUM : CopyTexImage2D
getError expected: NO_ERROR. Was INVALID_ENUM : CopyTexImage2D
FAIL getError expected: NO_ERROR. Was INVALID_ENUM : CopyTexImage2D

Git Watcher via monorail

unread,
Jul 7, 2022, 6:05:07 PM7/7/22
to angleproj...@googlegroups.com

Comment #23 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c23


The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/9931dfd51e8d89eea51eb122d3be361d8c905b10

commit 9931dfd51e8d89eea51eb122d3be361d8c905b10
Author: Alexey Knyazev <lexa.k...@gmail.com>
Date: Mon May 02 00:00:00 2022

D3D9: Implement float sources for Image9::copyFromRTInternal

Bug: angleproject:5038
Bug: angleproject:6257
Change-Id: I4f21fb1e37a985e2179d9c06101fa5bd2fedb100
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3738143
Reviewed-by: Kenneth Russell <k...@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jon...@google.com>
Commit-Queue: Jonah Ryan-Davis <jon...@google.com>

[modify] https://crrev.com/9931dfd51e8d89eea51eb122d3be361d8c905b10/src/libANGLE/renderer/d3d/d3d9/Image9.cpp

k… via monorail

unread,
Jul 8, 2022, 6:06:53 PM7/8/22
to angleproj...@googlegroups.com

Comment #24 on issue 5038 by k...@chromium.org: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c24

Links to the first failing builds on the Pixel bots on chromium.gpu.fyi:

https://ci.chromium.org/ui/p/chromium/builders/ci/Android%20FYI%20Release%20(Pixel%202)/31352/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/Android%20FYI%20Release%20(Pixel%204)/17985/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/Android%20FYI%20Release%20(Pixel%206)/2098/overview

Happening with both the validating and passthrough command decoder.

Will re-suppress on that platform temporarily so we can at least test on macOS, Linux, etc.

Git Watcher via monorail

unread,
Jul 8, 2022, 9:33:11 PM7/8/22
to angleproj...@googlegroups.com

Comment #25 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c25


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/62857c4f4471392caf11b74221f7f395e7b30243

commit 62857c4f4471392caf11b74221f7f395e7b30243
Author: Kenneth Russell <k...@chromium.org>
Date: Sat Jul 09 01:32:54 2022

(Reland) Unsuppress ext-color-buffer-half-float.html.

conformance/extensions/ext-color-buffer-half-float.html is passing
on multiple desired configurations with the latest ANGLE fixes.

Permanently suppress on:
ChromeOS + Android with validating command decoder
as passthrough + ANGLE will ship there soon.

There is one remaining failure on Android + passthrough which still
needs to be investigated.

Bug: angleproject:5038
Change-Id: I8bd2d266a4a93eeac1e27dcad0a08f2ae6ee9adb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3753323

Commit-Queue: Kenneth Russell <k...@chromium.org>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>

Git Watcher via monorail

unread,
Jul 11, 2022, 4:07:05 AM7/11/22
to angleproj...@googlegroups.com

Comment #26 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c26


The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/659fb3c50e7c48c454cae1b269607b5a99ceb24e

commit 659fb3c50e7c48c454cae1b269607b5a99ceb24e
Author: angle-autoroll <angle-a...@skia-public.iam.gserviceaccount.com>
Date: Mon Jul 11 07:01:14 2022

Roll Chromium from 14abb4e33fdf to eb8af3adeed3 (542 revisions)

https://chromium.googlesource.com/chromium/src.git/+log/14abb4e33fdf..eb8af3adeed3


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC abdolr...@google.com on the revert to ensure that a human

is aware of the problem.



To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/91f4f755f5..0b8f9f66dd
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/7cb0c1ac02..cf8f275dd5
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1dee059cfe
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bb07d9eb0b..1601b3eba0
* third_party/fuchsia-sdk/sdk: version:8.20220707.3.1..version:8.20220710.3.1
* third_party/r8: Zmb3PQpaMmxHLKO-7rV_Zl3UzVWX40QwqDQQibl5kkYC.._URv1DxbFnQYhwPNbUIf6cm2s5SkiWjaYLFJa3Zw4ysC
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/8bd72d6250..0ca99b7456
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/9dfcf9de8e..0c95a81c8e
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3464548264..baba431593
Clang version changed llvmorg-15-init-15116-g7c4b90a9:llvmorg-15-init-15652-g89a99ec9
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/8bd72d6250bbb3a2c30151a5920ebc6f644dc51c..0ca99b7456f6522fd7f3b2198f355f1851d1e9f4/scripts/update.py

Bug: angleproject:5038
Tbr: abdolr...@google.com
Change-Id: I623131785bbf13cdf7c571d76206aad2bb31fcc7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3754670
Commit-Queue: angle-autoroll <angle-a...@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-a...@skia-public.iam.gserviceaccount.com>

[modify] https://crrev.com/659fb3c50e7c48c454cae1b269607b5a99ceb24e/DEPS

khasl… via monorail

unread,
Jul 11, 2022, 7:24:16 PM7/11/22
to angleproj...@googlegroups.com

Comment #27 on issue 5038 by khas...@chromium.org: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c27

I see this test failing on a few more bots.

CrOS amd64-generic:
webgl2_conformance_gles_passthrough_tests

Lacros x64:
webgl2_conformance_validating_tests on Intel GPU on Linux
webgl_conformance_validating_tests on Intel GPU on Linux


@Ken, does it make sense to update expectations on these configurations as well?

Git Watcher via monorail

unread,
Jul 12, 2022, 4:55:08 PM7/12/22
to angleproj...@googlegroups.com

Comment #28 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c28


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/ca6ba7e38b966aa6fe8689ef2b5d125cd39dab1b

commit ca6ba7e38b966aa6fe8689ef2b5d125cd39dab1b
Author: Kevin Haslett <khas...@chromium.org>
Date: Tue Jul 12 20:53:57 2022

Update expectations for ext-color-buffer-half-float.html test

crrev.com/c/3753323 recently changed these expectations which
caused GPU.fyi bots to fail:
- Lacros FYI x64 Release (Intel)
- ChromeOS FYI Release (amd64-generic)
- ChromeOS FYI Release (kevin)

Bug: https://crbug.com/angleproject/5038
Change-Id: I0f5c5d0c89aacc06e481707ecf836f7c565e2fdc
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3758033
Commit-Queue: Kevin Haslett <khas...@chromium.org>
Reviewed-by: Kenneth Russell <k...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1023400}

[modify] https://crrev.com/ca6ba7e38b966aa6fe8689ef2b5d125cd39dab1b/content/test/gpu/gpu_tests/test_expectations/webgl2_conformance_expectations.txt
[modify] https://crrev.com/ca6ba7e38b966aa6fe8689ef2b5d125cd39dab1b/content/test/gpu/gpu_tests/test_expectations/webgl_conformance_expectations.txt

Git Watcher via monorail

unread,
Jul 13, 2022, 3:11:06 PM7/13/22
to angleproj...@googlegroups.com

Comment #29 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c29


The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/5897d6f594b3b9950de3a5fb52424185ca4d9985

commit 5897d6f594b3b9950de3a5fb52424185ca4d9985
Author: Alexey Knyazev <lexa.k...@gmail.com>
Date: Thu Jul 07 00:00:00 2022

GL: Add emulateCopyTexImage2D workaround

Using texImage2D + copyTexSubImage2D seems to be
more stable than using copyTexImage2D directly.

Added missing HALF_FLOAT fix to the code path that
requires target texture initialization.

Fixed target texture dimensions when initialization
is not required.

Fixes Apple GPU crashes in:
* CopyTexImageTest.DeleteAfterCopyingToTextures
* conformance/textures/misc/texture-copying-and-deletion.html
* conformance/textures/misc/texture-copying-feedback-loops.html

Bug: angleproject:5038
Bug: angleproject:5360
Bug: chromium:1130703
Change-Id: I5cce087983601e768902f01b3462ec2106e2500a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3749921
Commit-Queue: Kenneth Russell <k...@chromium.org>
Reviewed-by: Gregg Tavares <gm...@chromium.org>
Reviewed-by: Kenneth Russell <k...@chromium.org>

[modify] https://crrev.com/5897d6f594b3b9950de3a5fb52424185ca4d9985/util/angle_features_autogen.cpp
[modify] https://crrev.com/5897d6f594b3b9950de3a5fb52424185ca4d9985/src/tests/gl_tests/TextureTest.cpp
[modify] https://crrev.com/5897d6f594b3b9950de3a5fb52424185ca4d9985/src/tests/gl_tests/CopyTexImageTest.cpp
[modify] https://crrev.com/5897d6f594b3b9950de3a5fb52424185ca4d9985/util/angle_features_autogen.h
[modify] https://crrev.com/5897d6f594b3b9950de3a5fb52424185ca4d9985/src/libANGLE/renderer/gl/renderergl_utils.cpp
[modify] https://crrev.com/5897d6f594b3b9950de3a5fb52424185ca4d9985/src/tests/angle_end2end_tests_expectations.txt
[modify] https://crrev.com/5897d6f594b3b9950de3a5fb52424185ca4d9985/include/platform/FeaturesGL_autogen.h
[modify] https://crrev.com/5897d6f594b3b9950de3a5fb52424185ca4d9985/src/libANGLE/renderer/gl/TextureGL.cpp
[modify] https://crrev.com/5897d6f594b3b9950de3a5fb52424185ca4d9985/scripts/code_generation_hashes/ANGLE_features.json
[modify] https://crrev.com/5897d6f594b3b9950de3a5fb52424185ca4d9985/include/platform/gl_features.json

h… via monorail

unread,
Sep 1, 2022, 11:32:47 AM9/1/22
to angleproj...@googlegroups.com

Comment #30 on issue 5038 by h...@chromium.org: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c30

FYI: ext-color-buffer-half-float.html also fails on CrOS passthrough, so I'm disabling it in https://chromium-review.googlesource.com/c/chromium/src/+/3864256. It fails on CrOS validating as well, but I thought I'd flag it here so it can also be re-enabled on CrOS passthrough when this bug gets resolved.

k… via monorail

unread,
Sep 1, 2022, 6:29:27 PM9/1/22
to angleproj...@googlegroups.com

Comment #31 on issue 5038 by k...@chromium.org: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c31

Thanks for the heads up Brian. Could you provide about:gpu from a CrOS system where it's failing with ANGLE + passthrough?

Git Watcher via monorail

unread,
Jan 8, 2023, 2:46:24 AM1/8/23
to angleproj...@googlegroups.com

Comment #32 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c32


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/e1d51e497c44879738d668de5cabdb2319999606

commit e1d51e497c44879738d668de5cabdb2319999606
Author: Expectation File Editor <chrome-automat...@chops-service-accounts.iam.gserviceaccount.com>
Date: Sun Jan 08 07:45:41 2023

Remove stale WebGL 1 expectations

Autogenerated CL from running:

//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 200 --suite webgl1_conformance --jobs 4

Affected bugs for CL description:

R=rubber-...@appspot.gserviceaccount.com

Bug: 1122644, 1175371, 1347077, 478572, 844311
Bug: 849572, 903903, 957807, angleproject:5038, angleproject:6245
Change-Id: I381ab7674a11e968605f491abee3c67a2d3e2f68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4146178
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Auto-Submit: chrome-automat...@chops-service-accounts.iam.gserviceaccount.com <chrome-automat...@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1090109}

[modify] https://crrev.com/e1d51e497c44879738d668de5cabdb2319999606/content/test/gpu/gpu_tests/test_expectations/webgl_conformance_expectations.txt

Git Watcher via monorail

unread,
Jan 9, 2023, 3:44:48 AM1/9/23
to angleproj...@googlegroups.com

Comment #33 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c33


The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/d53c520e84439c62ab80ee9deb59134843803195

commit d53c520e84439c62ab80ee9deb59134843803195
Author: angle-autoroll <angle-a...@skia-public.iam.gserviceaccount.com>
Date: Mon Jan 09 08:14:05 2023

Roll Chromium from 20196e335c59 to 02451be6fd41 (589 revisions)

https://chromium.googlesource.com/chromium/src.git/+log/20196e335c59..02451be6fd41


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC sri...@google.com on the revert to ensure that a human

is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/12734d306c..0c2eadc5bb
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/120e9f1884..809529a935
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/e38c901c6f..278c5821d6
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..163b421317
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/50985d5fdd..6f905470df
* third_party/fuchsia-sdk/sdk: version:11.20230105.2.1..version:11.20230108.3.1
* third_party/r8: jyDAFIKO9nDUNWJzgjzSp6qvRE8di6dCoBtierYMedEC..3VqLjArDzdJ3Rgq8SH04G_33VEV5H7Wk5KquOg8OMkUC
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/5c711ec7ea..e8c31f937f
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3b09d7430e..0d00eb2837
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/34faa777c7..574936f02f
No update to Clang.

Bug: angleproject:3685,angleproject:4242,angleproject:5038,angleproject:5223,angleproject:6245,angleproject:7079,angleproject:7234,angleproject:7421
Tbr: sri...@google.com
Change-Id: I190b669737645c62d7e4fef7e94071ab62070d91
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4146543

Git Watcher via monorail

unread,
Jan 21, 2023, 8:09:16 AM1/21/23
to angleproj...@googlegroups.com

Comment #34 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c34


The following revision refers to this bug:
Date: Sat Jan 21 13:08:16 2023

Remove stale WebGL 2 expectations

Autogenerated CL from running:

//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 200 --suite webgl2_conformance --jobs 4


Affected bugs for CL description:

R=rubber-...@appspot.gserviceaccount.com

Bug: 1210240, 1215700, 1218607, 1336010, 891953
Bug: angleproject:4417, angleproject:5038
Change-Id: I051f61788a1a4e1e450505eb92017c0423dead2d
Fixed: 1060012, 1231736
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4185815
Auto-Submit: chrome-automat...@chops-service-accounts.iam.gserviceaccount.com <chrome-automat...@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1095367}

[modify] https://crrev.com/ca0f4f2d61b5281d35b21254312ccca80cbe0022/content/test/gpu/gpu_tests/test_expectations/webgl2_conformance_expectations.txt

Git Watcher via monorail

unread,
Jan 23, 2023, 3:09:27 AM1/23/23
to angleproj...@googlegroups.com

Comment #35 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c35


The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/df202660de19da8e96078a4d35ba90131aadbce6

commit df202660de19da8e96078a4d35ba90131aadbce6
Author: angle-autoroll <angle-a...@skia-public.iam.gserviceaccount.com>
Date: Mon Jan 23 07:00:23 2023

Roll Chromium from 4303e3d5e898 to d184372e4c92 (604 revisions)

https://chromium.googlesource.com/chromium/src.git/+log/4303e3d5e898..d184372e4c92


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC geof...@google.com on the revert to ensure that a human

is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/dac013f262..b775173320
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/dc82f3042d..d520d582aa
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/8aa310ace3..427915c5f6
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/da69f777a0..99ddc1e97f
* third_party/android_sdk/public: oWlET2yQhaPKQ66tYNuSPaueU78Z9VlxpyxOoUjwRuIC..3Yn5Sn7BMObm8gsoZCF0loJMKg9_PpgU07G9DObCLdQC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c4e9d16032
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/aec39c38f8..e852391441
* third_party/fuchsia-sdk/sdk: version:11.20230118.2.1..version:11.20230122.2.1
* third_party/r8: P1d7YJypbKC2Tv6UCo5QRdo1UwIyECszSGO583AzYigC..XBkol4a9AeFOtX-9cvNPpKCbqj9UAqZuoVvFop6AX9wC
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/16bb37bbfe..bae2f662bc
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6d7ad776de..f03c9412cd
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c3af70bb40..680d5e2c82
No update to Clang.

Bug: angleproject:4417,angleproject:5038
Tbr: geof...@google.com
Change-Id: I3e29bec797c48c988f2f3c6ffccb0d696fa632f0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4185761

Git Watcher via monorail

unread,
Apr 12, 2023, 3:15:13 AM4/12/23
to angleproj...@googlegroups.com

Comment #36 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c36


The following revision refers to this bug:
Date: Wed Apr 12 07:14:37 2023


Remove stale WebGL 2 expectations

Autogenerated CL from running:

//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite webgl2_conformance --jobs 4


Affected bugs for CL description:

R=rubber-...@appspot.gserviceaccount.com

Bug: 1380411, angleproject:5038
Change-Id: I46f37d6aa946178626c47d19f067e6e694f741f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4416321

Git Watcher via monorail

unread,
Apr 13, 2023, 4:21:24 AM4/13/23
to angleproj...@googlegroups.com

Comment #37 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c37


The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/70f1bf2aad5939ac54ae1b08138cdb10a2680b7e

commit 70f1bf2aad5939ac54ae1b08138cdb10a2680b7e
Author: angle-autoroll <angle-a...@skia-public.iam.gserviceaccount.com>
Date: Thu Apr 13 07:00:15 2023

Roll Chromium from 86be736f34ce to 902dbf2d8350 (593 revisions)

https://chromium.googlesource.com/chromium/src.git/+log/86be736f34ce..902dbf2d8350


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle...@google.com,ynov...@google.com on the revert to

ensure that a human
is aware of the problem.

To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/5a74261ac4..6f07ee5fdb
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/544591b9da..607434bddd
* buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/4156a29aab..a112d60e2f
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/695316e1aa..46d77edb73
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/1a0760c1b1..8024c48463
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/6d2ed7db89..7714db17ca
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c5af5d5bf5
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a896d5a92c..3ca8d0d0ca
* third_party/fuchsia-sdk/sdk: version:12.20230412.0.1..version:12.20230413.0.1
* third_party/r8: ItqtrDm-XZNQVaHFUexhSZ_ziQ5Ukb_9gGMJKggWKnEC..Qs7IdwPHgKR42jCzqTBPNEMjs0uPNpDXs29NfiBcsHIC
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/26ed975357..6b35b5895f
* tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/13f0b81ce5..a295e5b288
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/0d91892c61..acbd861bd1
No update to Clang.

Bug: angleproject:5038
Tbr: ynov...@google.com
Change-Id: I86b31377702d9ec6e9962e2c176c16c73143133b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4420283
Bot-Commit: angle-autoroll <angle-a...@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-a...@skia-public.iam.gserviceaccount.com>

[modify] https://crrev.com/70f1bf2aad5939ac54ae1b08138cdb10a2680b7e/DEPS

Git Watcher via monorail

unread,
May 2, 2023, 2:53:27 AM5/2/23
to angleproj...@googlegroups.com

Comment #38 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c38


The following revision refers to this bug:
Date: Tue May 02 06:52:22 2023

Remove stale WebGL 1 expectations

Autogenerated CL from running:

//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite webgl1_conformance --jobs 4


Affected bugs for CL description:

R=rubber-...@appspot.gserviceaccount.com


Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>

Git Watcher via monorail

unread,
May 2, 2023, 6:39:13 AM5/2/23
to angleproj...@googlegroups.com

Comment #39 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c39


The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/acbba2222ec7aa5c27054df853c25417631cad80

commit acbba2222ec7aa5c27054df853c25417631cad80
Author: angle-autoroll <angle-a...@skia-public.iam.gserviceaccount.com>
Date: Tue May 02 07:59:37 2023

Roll Chromium from fe2d690d4674 to 4c9976e5d118 (429 revisions)

https://chromium.googlesource.com/chromium/src.git/+log/fe2d690d4674..4c9976e5d118


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle...@google.com,cnor...@google.com on the revert to

ensure that a human
is aware of the problem.

To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Changed dependencies

No update to Clang.

Bug: angleproject:5038
Tbr: cnor...@google.com
Change-Id: Ib158f3b3092b525c56ac89311df3b7de3cf87ac2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4498302

Git Watcher via monorail

unread,
Feb 4, 2024, 2:46:33 AM2/4/24
to angleproj...@googlegroups.com

Comment #40 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c40


The following revision refers to this bug:
Date: Sun Feb 04 07:45:45 2024

Remove stale WebGL 2 expectations

Autogenerated CL from running:

//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite webgl2_conformance --jobs 4


Affected bugs for CL description:

R=rubber-...@appspot.gserviceaccount.com

Bug: 1336010, angleproject:5038, angleproject:6245
Change-Id: I08f3a7cb1a23b37de947d1ce035f78a1991b6b8d
Fixed: 1210240, 1215700, 1218607, 1232106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5265658

Git Watcher via monorail

unread,
Feb 4, 2024, 2:51:30 AM2/4/24
to angleproj...@googlegroups.com

Comment #41 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c41


The following revision refers to this bug:
Date: Sun Feb 04 07:50:27 2024

Remove stale WebGL 1 expectations

Autogenerated CL from running:

//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite webgl1_conformance --jobs 4


Affected bugs for CL description:

R=rubber-...@appspot.gserviceaccount.com

Bug: 1357064, 1448573, 1448743, 1509927, angleproject:5038
Change-Id: I1daf09a510fc8b07905addd8ca295b96a0ab0996
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5266077

Git Watcher via monorail

unread,
Feb 5, 2024, 3:38:29 AM2/5/24
to angleproj...@googlegroups.com

Comment #42 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c42


The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/9d165231e13c6aeda89ac7d6ca6198d31c9bf911

commit 9d165231e13c6aeda89ac7d6ca6198d31c9bf911
Author: angle-autoroll <angle-a...@skia-public.iam.gserviceaccount.com>
Date: Mon Feb 05 07:00:51 2024

Roll Chromium from 37f9e1b14cf7 to c1ca24b91ed5 (609 revisions)

https://chromium.googlesource.com/chromium/src.git/+log/37f9e1b14cf7..c1ca24b91ed5


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle...@google.com,yux...@google.com on the revert to

ensure that a human
is aware of the problem.

To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/78ad07d164..90c5422aa9
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/43e76969b9..fc9e646cb3
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/32ff18c00f..d1cf265406
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e8367e6d6e..432aa4ae6c
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7142bf166c..af6eabff53
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/030b3ed3a4..3c2f3884e6
* third_party/r8: Cwp-cRksMvELPD_6Gt9Cse08DbIIA8_am3yQuDCx_wYC..X4a6wa4_8gQP775zUTVOXJEtzMNByOt6xLvdOc2_i_MC
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/de6b303a89..262783cfa8
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f5c1c96a7b..0f0ac05e41
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c6dfd64fd9..132e8c9896
No update to Clang.

Bug: angleproject:5038,angleproject:6245
Tbr: yux...@google.com
Change-Id: I0d092d7a6e4e111c68a0ac4aae284396d87cc388
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5266694

Git Watcher via monorail

unread,
May 9, 2024, 3:45:49 AM5/9/24
to angleproj...@googlegroups.com

Comment #43 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c43


The following revision refers to this bug:
Date: Thu May 09 07:44:23 2024

Remove stale WebGL 2 expectations

Autogenerated CL from running:

//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite webgl2_conformance --jobs 4


Affected bugs for CL description:

R=rubber-...@appspot.gserviceaccount.com

Bug: 1475765, angleproject:5038
Change-Id: I48216c86cef983265ccef2a6a58901fb817befe9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528148

Git Watcher via monorail

unread,
May 11, 2024, 12:25:28 PM5/11/24
to angleproj...@googlegroups.com

Comment #44 on issue 5038 by Git Watcher: Support EXT_color_buffer_half_float on WebGL 2.0 contexts
https://bugs.chromium.org/p/angleproject/issues/detail?id=5038#c44


The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/9eaf12d38169696a29895366eaeed1ff8386e57a

commit 9eaf12d38169696a29895366eaeed1ff8386e57a
Author: angle-autoroll <angle-a...@skia-public.iam.gserviceaccount.com>
Date: Fri May 10 09:45:03 2024

Roll Chromium from 4fea14b56dd7 to e8c93a04c96c (1172 revisions)

https://chromium.googlesource.com/chromium/src.git/+log/4fea14b56dd7..e8c93a04c96c


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC abdolr...@google.com,angle...@google.com on the revert to

ensure that a human
is aware of the problem.

To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/7796c50af5..b2163519a9
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9703d9137f..4e0e9c73a0
* buildtools/linux64: git_revision:f284b6b47039a2d7edfcbfc51f52664f82b5a789..git_revision:b0c2742896b6b9f869dc0eb35ae4785cbf2a4512
* buildtools/mac: git_revision:f284b6b47039a2d7edfcbfc51f52664f82b5a789..git_revision:b0c2742896b6b9f869dc0eb35ae4785cbf2a4512
* buildtools/win: git_revision:f284b6b47039a2d7edfcbfc51f52664f82b5a789..git_revision:b0c2742896b6b9f869dc0eb35ae4785cbf2a4512
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/a2a6e48c98..46a35f0196
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/31bdf8fec4..8c54b7dae4
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/47d3198a95..3a1d1cc096
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/df437783c2..6e32e926e9
* third_party/r8: ntlyos9oLHW_q1AeZovqFuTYzog9dKd2lITTowptHuYC..DcVi2RjfFH55zitouMx3JJtwdiShMM2rWsdAoGYUIRsC
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/964cf5c799..091120aa21
* tools/luci-go: git_revision:91ca2f5af39c4feb1c748c353f4d616e1c2332e7..git_revision:0353d07d5edeb62305e13f17d808e8523cd5bac2
* tools/luci-go: git_revision:91ca2f5af39c4feb1c748c353f4d616e1c2332e7..git_revision:0353d07d5edeb62305e13f17d808e8523cd5bac2
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/54a120d570..42052bb1dc
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7ef4ff5ba3..a38be67561
* tools/skia_goldctl/linux: rnVa2tBzy_bWBzhMbfGN9LWVREg2oX7FIWTizcil9nAC..EYKOn-l9uvmHtsVw_fmqj8vxXKpMyXt2sXvEJ3snsUQC
* tools/skia_goldctl/mac_amd64: Y1vx6zBEl8AgYA0BE99RK71LoJPAJMdFcFZUiiH4ItIC..U1MAiUkDGvUVuk6G3tRhjjtmA3gDgW4HkyWhy8xTfrQC
* tools/skia_goldctl/mac_arm64: 1QeDGa3HwvjmY-wV4NK81PTGZGJ_uSZ0FSC0dHAosIsC..KzRIDh9i73vYu6zVorKIEt7qrq38TuL9MZEWbf3Glw4C
* tools/skia_goldctl/win: qWfDi1N2HXBm5wLJgsy6fImu51jqJ6JafFDWjWJPuMQC..gEDTtt_VQOAPHQedAzUUVJ79216-Wz_H9A-EfvVGYyAC

No update to Clang.

Bug: angleproject:5038
Tbr: abdolr...@google.com
Change-Id: I8b5f1641d70bd03e253722264f19f427ed35cf9d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5530989
Bot-Commit: angle-autoroll <angle-a...@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynov...@chromium.org>

[modify] https://crrev.com/9eaf12d38169696a29895366eaeed1ff8386e57a/tools/perf
[modify] https://crrev.com/9eaf12d38169696a29895366eaeed1ff8386e57a/third_party/depot_tools
[modify] https://crrev.com/9eaf12d38169696a29895366eaeed1ff8386e57a/build
[modify] https://crrev.com/9eaf12d38169696a29895366eaeed1ff8386e57a/tools/mb
[modify] https://crrev.com/9eaf12d38169696a29895366eaeed1ff8386e57a/buildtools
[modify] https://crrev.com/9eaf12d38169696a29895366eaeed1ff8386e57a/tools/clang
[modify] https://crrev.com/9eaf12d38169696a29895366eaeed1ff8386e57a/testing
[modify] https://crrev.com/9eaf12d38169696a29895366eaeed1ff8386e57a/third_party/catapult
[modify] https://crrev.com/9eaf12d38169696a29895366eaeed1ff8386e57a/third_party/abseil-cpp
[modify] https://crrev.com/9eaf12d38169696a29895366eaeed1ff8386e57a/DEPS
Reply all
Reply to author
Forward
0 new messages