Issue 8593 in angleproject: Assert parsing coherent coherent

[kkinn… via monorail]

Status: Available
Owner: ----
Components: Translator
OS: All
Priority: Medium
Type: Defect

New issue 8593 by kkinn...@apple.com: Assert parsing coherent coherent
https://bugs.chromium.org/p/angleproject/issues/detail?id=8593

TEST_F(ParseTest, CoherentCoherentNoCrash)
{
const char kShader[] = R"(#version 310 es
coherent coherent;)";
EXPECT_FALSE(compile(kShader));
EXPECT_TRUE(foundErrorInIntermediateTree());
EXPECT_TRUE(foundInIntermediateTree("something"));
}

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[Git Watcher via monorail]

Comment #1 on issue 8593 by Git Watcher: Assert parsing coherent coherent
https://bugs.chromium.org/p/angleproject/issues/detail?id=8593#c1

The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/0f110098cc4e1c8a13f40b2847b322fe62a32d8b

commit 0f110098cc4e1c8a13f40b2847b322fe62a32d8b
Author: Erica Li <ler...@apple.com>
Date: Fri Mar 08 10:40:09 2024

Avoid assert with multiple memory qualifiers

Add missing qualifier strings.

Bug: angleproject:8593
Change-Id: I484571c33effd85d52712b4876f6a3a5c73d8fde
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5352255
Reviewed-by: Shahbaz Youssefi <syou...@chromium.org>
Auto-Submit: Kimmo Kinnunen <kkin...@apple.com>
Commit-Queue: Shahbaz Youssefi <syou...@chromium.org>

[modify] https://crrev.com/0f110098cc4e1c8a13f40b2847b322fe62a32d8b/src/compiler/translator/BaseTypes.h
[modify] https://crrev.com/0f110098cc4e1c8a13f40b2847b322fe62a32d8b/src/tests/compiler_tests/Parse_test.cpp

[kkinn… via monorail]

Updates:
Status: Verified

Comment #2 on issue 8593 by kkinn...@apple.com: Assert parsing coherent coherent
https://bugs.chromium.org/p/angleproject/issues/detail?id=8593#c2

(No comment was entered for this change.)